refactor(cdk): use polymorphic enums for mint and melt quotes#1875
Merged
thesimplekid merged 2 commits intocashubtc:mainfrom Apr 19, 2026
Merged
refactor(cdk): use polymorphic enums for mint and melt quotes#1875thesimplekid merged 2 commits intocashubtc:mainfrom
thesimplekid merged 2 commits intocashubtc:mainfrom
Conversation
d7486ac to
989091e
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1875 +/- ##
==========================================
+ Coverage 63.76% 64.32% +0.56%
==========================================
Files 329 329
Lines 55178 55608 +430
==========================================
+ Hits 35184 35771 +587
+ Misses 19994 19837 -157 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
989091e to
e533a35
Compare
lescuer97
reviewed
Apr 14, 2026
lescuer97
reviewed
Apr 14, 2026
Contributor
lescuer97
left a comment
There was a problem hiding this comment.
I know the pr is not ready yet but I wanted to add some small comments.
on double clone() there are more that I signaled.
bbeb39c to
bd90d1c
Compare
feafcf2 to
580fc21
Compare
580fc21 to
eb31565
Compare
eb31565 to
bb82a73
Compare
bb82a73 to
05fc5fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Notes to the reviewers
Suggested CHANGELOG Updates
CHANGED
ADDED
REMOVED
FIXED
Checklist
just quick-checkbefore committingcrates/cdk-ffi)