Skip to content

refactor(cdk): use polymorphic enums for mint and melt quotes#1875

Merged
thesimplekid merged 2 commits intocashubtc:mainfrom
thesimplekid:use_enums_for_quotes
Apr 19, 2026
Merged

refactor(cdk): use polymorphic enums for mint and melt quotes#1875
thesimplekid merged 2 commits intocashubtc:mainfrom
thesimplekid:use_enums_for_quotes

Conversation

@thesimplekid
Copy link
Copy Markdown
Collaborator

@thesimplekid thesimplekid commented Apr 10, 2026

Description


Notes to the reviewers


Suggested CHANGELOG Updates

CHANGED

ADDED

REMOVED

FIXED


Checklist

  • I followed the code style guidelines
  • I ran just quick-check before committing
  • If the Wallet API was modified (added/removed/changed), I have reflected those changes in the FFI bindings (crates/cdk-ffi)

@github-project-automation github-project-automation Bot moved this to Backlog in CDK Apr 10, 2026
@thesimplekid thesimplekid force-pushed the use_enums_for_quotes branch from d7486ac to 989091e Compare April 12, 2026 20:39
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 12, 2026

Codecov Report

❌ Patch coverage is 80.69106% with 95 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.32%. Comparing base (2fed066) to head (05fc5fe).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/cdk-axum/src/custom_handlers.rs 0.00% 50 Missing ⚠️
crates/cdk-common/src/mint.rs 79.52% 26 Missing ⚠️
crates/cdk/src/mint/subscription.rs 0.00% 5 Missing ⚠️
crates/cdk-fake-wallet/src/lib.rs 80.95% 4 Missing ⚠️
crates/cdk/src/mint/melt/mod.rs 50.00% 4 Missing ⚠️
crates/cdk/src/mint/issue/mod.rs 50.00% 2 Missing ⚠️
crates/cdk/src/wallet/test_utils.rs 0.00% 2 Missing ⚠️
crates/cdk-integration-tests/src/lib.rs 0.00% 1 Missing ⚠️
crates/cdk/src/wallet/melt/saga/mod.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1875      +/-   ##
==========================================
+ Coverage   63.76%   64.32%   +0.56%     
==========================================
  Files         329      329              
  Lines       55178    55608     +430     
==========================================
+ Hits        35184    35771     +587     
+ Misses      19994    19837     -157     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thesimplekid thesimplekid force-pushed the use_enums_for_quotes branch from 989091e to e533a35 Compare April 13, 2026 18:15
Comment thread crates/cashu/src/nuts/nut23.rs Outdated
Copy link
Copy Markdown
Contributor

@lescuer97 lescuer97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the pr is not ready yet but I wanted to add some small comments.
on double clone() there are more that I signaled.

Comment thread crates/cdk/src/mint/melt/tests/htlc_spending_conditions_tests.rs Outdated
Comment thread crates/cdk/src/mint/melt/tests/htlc_spending_conditions_tests.rs Outdated
Comment thread crates/cdk/src/mint/melt/tests/htlc_spending_conditions_tests.rs Outdated
Comment thread crates/cdk/src/mint/mod.rs
@thesimplekid thesimplekid mentioned this pull request Apr 14, 2026
6 tasks
@thesimplekid thesimplekid force-pushed the use_enums_for_quotes branch 2 times, most recently from bbeb39c to bd90d1c Compare April 14, 2026 21:18
@thesimplekid thesimplekid requested review from crodas and lescuer97 and removed request for lescuer97 April 14, 2026 21:24
@thesimplekid thesimplekid changed the title Use enums for quotes refactor(cdk): use polymorphic enums for mint and melt quotes Apr 15, 2026
@thesimplekid thesimplekid force-pushed the use_enums_for_quotes branch 3 times, most recently from feafcf2 to 580fc21 Compare April 17, 2026 14:59
@thesimplekid thesimplekid added the stacked hold PR is based on top of another PR, so should be merged in sequence. See comments for details. label Apr 17, 2026
@thesimplekid thesimplekid force-pushed the use_enums_for_quotes branch from 580fc21 to eb31565 Compare April 18, 2026 16:07
@thesimplekid thesimplekid mentioned this pull request Apr 18, 2026
4 tasks
@thesimplekid thesimplekid force-pushed the use_enums_for_quotes branch from eb31565 to bb82a73 Compare April 18, 2026 19:34
@thesimplekid thesimplekid force-pushed the use_enums_for_quotes branch from bb82a73 to 05fc5fe Compare April 19, 2026 08:07
@thesimplekid thesimplekid merged commit 05fc5fe into cashubtc:main Apr 19, 2026
5 of 7 checks passed
@thesimplekid thesimplekid deleted the use_enums_for_quotes branch April 19, 2026 08:07
@github-project-automation github-project-automation Bot moved this from Backlog to Done in CDK Apr 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stacked hold PR is based on top of another PR, so should be merged in sequence. See comments for details.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants