Skip to content

fix: persist melt extra_json#1910

Merged
thesimplekid merged 1 commit intocashubtc:mainfrom
thesimplekid:fix_persist_extra_json
Apr 19, 2026
Merged

fix: persist melt extra_json#1910
thesimplekid merged 1 commit intocashubtc:mainfrom
thesimplekid:fix_persist_extra_json

Conversation

@thesimplekid
Copy link
Copy Markdown
Collaborator

Description


Notes to the reviewers


Suggested CHANGELOG Updates

CHANGED

ADDED

REMOVED

FIXED


Checklist

  • I followed the code style guidelines
  • I ran just quick-check before committing
  • If the Wallet API was modified (added/removed/changed), I have reflected those changes in the FFI bindings (crates/cdk-ffi)

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 18, 2026

Codecov Report

❌ Patch coverage is 98.02372% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.12%. Comparing base (2fed066) to head (5b333b0).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/cdk/src/mint/subscription.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1910      +/-   ##
==========================================
+ Coverage   63.76%   64.12%   +0.36%     
==========================================
  Files         329      329              
  Lines       55178    55407     +229     
==========================================
+ Hits        35184    35531     +347     
+ Misses      19994    19876     -118     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thesimplekid thesimplekid force-pushed the fix_persist_extra_json branch from b7ffcc7 to bc316e0 Compare April 18, 2026 20:11
@thesimplekid thesimplekid force-pushed the fix_persist_extra_json branch from bc316e0 to 5b333b0 Compare April 18, 2026 20:20
@thesimplekid thesimplekid merged commit 5b333b0 into cashubtc:main Apr 19, 2026
45 of 48 checks passed
@thesimplekid thesimplekid deleted the fix_persist_extra_json branch April 19, 2026 08:07
@github-project-automation github-project-automation Bot moved this from Backlog to Done in CDK Apr 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant