Embed icon in NuGet package

[generik0]

Remove PackageIconUrl in favour of the new PackageIcon configuration

Fixes #518

[generik0]

H @jonorossi looks good locally:

But from the build server the project Icon still present.. Very strange. Why would the build be different locally v's appveyor

[generik0]

@jonorossi This is incredibly strange. The AppVeyor build is not adding the icon to the nuspec. Can it be due to the AppVeyor build using an old nuget/VS version?

[jonorossi]

This is incredibly strange. The AppVeyor build is not adding the icon to the nuspec. Can it be due to the AppVeyor build using an old nuget/VS version?

Very possible. We are using VS2017:

Windsor/appveyor.yml

Line 1 in b12304f

image: Visual Studio 2017

According to AppVeyor's docs, it has "NuGet 4.9.2".

[generik0]

Can we upgrade to Vs2019? I have not experienced any issues with MSBuild in 2019 vs 2017. All my upgrades went fluently:-)

[generik0]

Hi @jonorossi. Sorry about the delay. Busy with work and family. Haven't had the time I needed for anything else (excuses excuses)..
Now i have the projecticon and projecticonurl in the props

[stakx]

LGTM. I haven't tested this change here, but I've verified the same change over at castleproject/Core (in VS 2017 & 2019's NuGet Package Manager console, and in the build script's MSBuild output), so I expect this will be fine, too.

⚠️ For Windsor, there may still be the VS 2017 / 2019 toolchain issue to resolve, however.

[jonorossi]

Thanks