Skip to content

feat: Support for DCA 1 block interval#6025

Merged
j4m1ef0rd merged 3 commits intomainfrom
feat/one_block_interval
Aug 6, 2025
Merged

feat: Support for DCA 1 block interval#6025
j4m1ef0rd merged 3 commits intomainfrom
feat/one_block_interval

Conversation

@j4m1ef0rd
Copy link
Contributor

Pull Request

Closes: PRO-2354

Checklist

  • I am confident that the code works.
  • I have written sufficient tests.
  • I have written and tested required migrations.
  • I have updated documentation where appropriate.

Summary

  • Refactored the dca state to hold a List of scheduled swap ids instead of just one.
  • Refactored the swap queue so we do not need to know the block a swap is in to reschedule/cancel it.
  • Refunding a failed swap will also cancel any other swaps that are scheduled for that swap request.
    • New event SwapCanceled.
  • Rescheduling a swap will also reschedule any other swaps that are scheduled for that swap request.
  • Refactored the dca state functions to split them up for more control.
  • Init swap request now schedules 2 chunks if the interval is 1.
  • When a swap completes it schedules the next chunk for the swap request, not necessarily a consecutive chunk.
  • Added tests to cover the new 1 block interval.
  • Changed the dca test in the bouncer to cover the 1 block interval.
  • Refactored cf_scheduled_swaps rpc.
  • Added migrations for the swap queue and the dca state

@coderabbitai
Copy link

coderabbitai bot commented Jul 29, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/one_block_interval

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov
Copy link

codecov bot commented Jul 29, 2025

@j4m1ef0rd j4m1ef0rd changed the title feat: DCA 1 block interval feat: Support for DCA 1 block interval Jul 31, 2025
@j4m1ef0rd j4m1ef0rd added this pull request to the merge queue Aug 6, 2025
Merged via the queue into main with commit e181bc5 Aug 6, 2025
54 checks passed
@j4m1ef0rd j4m1ef0rd deleted the feat/one_block_interval branch August 6, 2025 05:51
syan095 added a commit that referenced this pull request Aug 15, 2025
…reward

* origin/main:
  feat: delegated staking auction integration (#6022)
  ci: improve secret passing 🥷 (#6042)
  feat: generate backspin chain spec (#6041)
  refactor: return `Ok(None)` instead of error if sol egress witnessing cannot find a tx (#6036)
  feat: add operator to validator info (#6040)
  feat: Support for DCA 1 block interval (#6025)
  feat: added account balance of operator (#6035)
  fix: remove race condition in bouncer observe event (#6023)
  fix: use `any::Asset` instead of `ChainlinkAssetpair` in internal price API (#6034)
  feat: price oracle elections (#5971)
  feat: don't error if tx is Confirmed (#6019)
  chore: process all events in a block in parallel (#6013)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants