Skip to content

feat: added account balance of operator#6035

Merged
acdibble merged 3 commits intomainfrom
feat/pro-2448/add-flip-balance
Aug 5, 2025
Merged

feat: added account balance of operator#6035
acdibble merged 3 commits intomainfrom
feat/pro-2448/add-flip-balance

Conversation

@Janislav
Copy link
Contributor

@Janislav Janislav commented Aug 1, 2025

Pull Request

Closes: PRO-2448

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have written sufficient tests.
  • I have written and tested required migrations.
  • I have updated documentation where appropriate.

Summary

Adds the operator balance to the account info RPC.

@coderabbitai
Copy link

coderabbitai bot commented Aug 1, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/pro-2448/add-flip-balance

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov
Copy link

codecov bot commented Aug 1, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
state-chain/runtime/src/lib.rs 0% 0 Missing and 1 partial ⚠️
state-chain/runtime/src/runtime_apis.rs 0% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Janislav Janislav marked this pull request as ready for review August 4, 2025 07:12
@Janislav Janislav requested a review from dandanlen as a code owner August 4, 2025 07:12
Copy link
Contributor

@acdibble acdibble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the other account types in this RPC return flip_balance

allowed,
blocked,
delegators: pallet_cf_validator::Pallet::<Runtime>::get_all_associations_by_operator(account_id, AssociationToOperator::Delegator),
account_balance: pallet_cf_flip::Account::<Runtime>::get(account_id).total(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
account_balance: pallet_cf_flip::Account::<Runtime>::get(account_id).total(),
flip_balance: pallet_cf_flip::Account::<Runtime>::get(account_id).total(),

allowed: self.allowed,
blocked: self.blocked,
delegators: self.delegators.into_iter().map(|(k, v)| (k, f(v))).collect(),
account_balance: f(self.account_balance),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
account_balance: f(self.account_balance),
flip_balance: f(self.account_balance),

@Janislav Janislav requested a review from ramizhasan111 August 5, 2025 11:14
@acdibble acdibble added this pull request to the merge queue Aug 5, 2025
Merged via the queue into main with commit 33afd84 Aug 5, 2025
54 checks passed
@acdibble acdibble deleted the feat/pro-2448/add-flip-balance branch August 5, 2025 14:07
syan095 added a commit that referenced this pull request Aug 15, 2025
…reward

* origin/main:
  feat: delegated staking auction integration (#6022)
  ci: improve secret passing 🥷 (#6042)
  feat: generate backspin chain spec (#6041)
  refactor: return `Ok(None)` instead of error if sol egress witnessing cannot find a tx (#6036)
  feat: add operator to validator info (#6040)
  feat: Support for DCA 1 block interval (#6025)
  feat: added account balance of operator (#6035)
  fix: remove race condition in bouncer observe event (#6023)
  fix: use `any::Asset` instead of `ChainlinkAssetpair` in internal price API (#6034)
  feat: price oracle elections (#5971)
  feat: don't error if tx is Confirmed (#6019)
  chore: process all events in a block in parallel (#6013)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants