Skip to content

Conversation

@veeceey
Copy link

@veeceey veeceey commented Feb 6, 2026

Summary

  • Fix typo in clients/js/README.md: "compatiblity" -> "compatibility"

Fixes #6193

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor

@kylediaz kylediaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

Please make sure you name the repo "[DOC] Fix type in JS client README" or else CI won't pass

@veeceey veeceey changed the title Fix typo in JS client README [DOC] Fix typo in JS client README Feb 6, 2026
@veeceey
Copy link
Author

veeceey commented Feb 7, 2026

Thanks for the approval @kylediaz! The title already has the [DOC] prefix — it's currently [DOC] Fix typo in JS client README. Should be good to go!

@veeceey
Copy link
Author

veeceey commented Feb 8, 2026

Review Summary for PR #6360

Status: APPROVED but CI needs attention

Finding: The PR has been approved by @kylediaz and the title is correctly formatted as [DOC] Fix typo in JS client README. However, the GitHub Actions "Check PR Title" workflow is reporting action_required status even though the title matches the required pattern.

CI Status:

  • ✅ PR checks: PASSED
  • ⚠️ Check PR Title: action_required (despite correct title format)

The most recent CI run (21765642751) shows the Check PR Title workflow with action_required status. This appears to be a workflow issue rather than a problem with the PR itself, as the title clearly contains the required [DOC] prefix matching the regex pattern \[(ENH|BUG|DOC|TST|BLD|PERF|TYP|CLN|CHORE|RELEASE|HOTFIX)\].*

Recommendation: The workflow may need to be retriggered or there may be a caching issue with the GitHub Actions check. The PR is ready for merge from a code perspective.

@veeceey
Copy link
Author

veeceey commented Feb 8, 2026

PR approved and ready. Requesting CI retrigger to confirm all checks pass before merge.

@veeceey
Copy link
Author

veeceey commented Feb 10, 2026

Hi team, friendly follow-up on this approved PR. It was approved by @kylediaz a few days ago but CI shows no checks have run on this branch. Could a maintainer help retrigger CI or merge when convenient? The PR title already has the [DOC] prefix as requested. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: typo issue in chroma/clients/js/README.md

2 participants