Conversation
WalkthroughUpdated rust-executor/Cargo.toml to bump three Holochain-related dependencies (holochain, holochain_cli_bundle, holochain_types) from 0.5.5 to 0.5.6 and switch their git branches from 0.5.5-coasys to 0.5.6-coasys. No code or feature flags changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
rust-executor/Cargo.toml (1)
98-100: Pin git dependencies to a commit for reproducible builds.Branch heads can move; add
rev(or a taggedgitref) to lock exact sources. Optional, but recommended for RCs/releases.Apply after replacing placeholders with the 0.5.6-coasys commit SHA:
- holochain = { version = "0.5.6", features = ["test_utils", "default", "backend-go-pion"], git = "https://github.com/coasys/holochain.git", branch = "0.5.6-coasys" } + holochain = { version = "0.5.6", features = ["test_utils", "default", "backend-go-pion"], git = "https://github.com/coasys/holochain.git", rev = "<commit-sha-0.5.6-coasys>" } - holochain_cli_bundle = { version = "0.5.6", git = "https://github.com/coasys/holochain.git", branch = "0.5.6-coasys" } + holochain_cli_bundle = { version = "0.5.6", git = "https://github.com/coasys/holochain.git", rev = "<commit-sha-0.5.6-coasys>" } - holochain_types = { version = "0.5.6", git = "https://github.com/coasys/holochain.git", branch = "0.5.6-coasys" } + holochain_types = { version = "0.5.6", git = "https://github.com/coasys/holochain.git", rev = "<commit-sha-0.5.6-coasys>" }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
rust-executor/Cargo.toml(1 hunks)
🔇 Additional comments (3)
rust-executor/Cargo.toml (3)
98-100: Bump looks good and aligns the trio on 0.5.6.No obvious manifest issues; versions and branches are consistent across holochain, holochain_cli_bundle, and holochain_types.
98-100: If CI targets multiple OSes, verify “backend-go-pion” builds everywhere.That feature can add platform build deps; make sure Linux/macOS/Windows CI jobs are green before merging.
98-100: Run local sanity checks to prevent mixed Holochain sources
Execute locally:cargo metadata --format-version 1 | jq -r '.packages[] | select(.name=="holochain" or .name=="holochain_types" or .name=="holochain_cli_bundle") | "\(.name)\t\(.source)"' cargo tree -d | rg -nP '^(holo(chain|chain_types|chain_zome_types)|holo_hash)\b' cargo tree -e features -p holochainEnsure all three crates resolve to the same git revision and that the enabled
holochainfeatures match those declared in Cargo.toml.
Summary by CodeRabbit