Conversation
WalkthroughThe changes update dependency versions in the Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
rust-executor/Cargo.toml(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: lucksus
PR: coasys/ad4m#605
File: rust-executor/src/js_core/options.rs:59-68
Timestamp: 2025-06-05T11:39:48.641Z
Learning: In the rust-executor project, CUSTOM_DENO_SNAPSHOT.bin is a build-time generated artifact created by the generate_snapshot binary (with --features generate_snapshot). The file is not checked into source control but is created during the build process via pnpm build-deno-snapshot script and then included in subsequent builds via include_bytes! macro.
Learnt from: lucksus
PR: coasys/ad4m#605
File: rust-executor/src/js_core/options.rs:70-78
Timestamp: 2025-06-05T11:39:40.217Z
Learning: In Deno upgrades around version 0.212.0, the extension initialization API was simplified from using `init_ops_and_esm()` to just `init()` for extension initialization in rust-executor/src/js_core/options.rs.
rust-executor/Cargo.toml (2)
Learnt from: lucksus
PR: coasys/ad4m#605
File: rust-executor/src/js_core/options.rs:59-68
Timestamp: 2025-06-05T11:39:48.641Z
Learning: In the rust-executor project, CUSTOM_DENO_SNAPSHOT.bin is a build-time generated artifact created by the generate_snapshot binary (with --features generate_snapshot). The file is not checked into source control but is created during the build process via pnpm build-deno-snapshot script and then included in subsequent builds via include_bytes! macro.
Learnt from: lucksus
PR: coasys/ad4m#605
File: rust-executor/src/js_core/options.rs:70-78
Timestamp: 2025-06-05T11:39:40.217Z
Learning: In Deno upgrades around version 0.212.0, the extension initialization API was simplified from using `init_ops_and_esm()` to just `init()` for extension initialization in rust-executor/src/js_core/options.rs.
🔇 Additional comments (1)
rust-executor/Cargo.toml (1)
96-96: Double-check kitsune2 / kitsune_p2p version skew
kitsune2_apiwas bumped to0.1.9butkitsune_p2p_typesremains on0.5.0-dev.9.
The kitsune crates try to stay in lock-step with each other and with Holochain; a minor bump has broken compilation for us in the past. Please run the test/CI matrix or a localcargo checkto ensure there are no trait/struct mismatches introduced by this uneven upgrade.
| holochain = { version = "0.5.3-rc.0", features = ["test_utils", "default"], git = "https://github.com/coasys/holochain.git", branch = "0.5.3-rc0-coasys" } | ||
| holochain_cli_bundle = { version = "0.5.3-rc.0", git = "https://github.com/coasys/holochain.git", branch = "0.5.3-rc0-coasys" } | ||
| holochain_types = { version = "0.5.3-rc.0", git = "https://github.com/coasys/holochain.git", branch = "0.5.3-rc0-coasys" } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
❓ Verification inconclusive
Pin the Holochain RC crates to a commit for repeatable builds
Using a moving branch (0.5.3-rc0-coasys) together with a pre-release version string (0.5.3-rc.0) makes today’s build succeed but leaves tomorrow’s builds non-deterministic—any force-push to that branch will silently change the code you compile.
Strongly recommend locking each crate to an immutable revision:
-holochain = { version = "0.5.3-rc.0", features = ["test_utils","default"], git = "https://github.com/coasys/holochain.git", branch = "0.5.3-rc0-coasys" }
+# Find the commit you validated locally and pin to it
+holochain = { version = "0.5.3-rc.0", features = ["test_utils","default"],
+ git = "https://github.com/coasys/holochain.git",
+ rev = "abcdef1234567890" }Do the same for holochain_cli_bundle and holochain_types.
Besides reproducibility, this avoids accidental compilation against an RC that introduces breaking changes without your notice.
Pin the Holochain RC crates to a commit for repeatable builds
Using a moving branch (0.5.3-rc0-coasys) together with a pre-release version string (0.5.3-rc.0) makes today’s build succeed but leaves tomorrow’s builds non-deterministic—any force-push to that branch will silently change the code you compile.
Strongly recommend locking each crate to an immutable revision:
-holochain = { version = "0.5.3-rc.0", features = ["test_utils","default"], git = "https://github.com/coasys/holochain.git", branch = "0.5.3-rc0-coasys" }
+# Find the commit you validated locally and pin to it
+holochain = { version = "0.5.3-rc.0", features = ["test_utils","default"],
+ git = "https://github.com/coasys/holochain.git",
+ rev = "abcdef1234567890" }Do the same for holochain_cli_bundle and holochain_types.
Besides reproducibility, this avoids accidental compilation against an RC that introduces breaking changes without your notice.
🤖 Prompt for AI Agents
In rust-executor/Cargo.toml around lines 97 to 99, the dependencies for
holochain, holochain_cli_bundle, and holochain_types are pinned to a moving
branch which causes non-deterministic builds. To fix this, replace the branch
specification with a specific commit hash for each crate by adding a `rev` field
with the commit SHA instead of the `branch` field. This ensures repeatable
builds and prevents accidental updates from force-pushed changes on the branch.
1 participant
Summary by CodeRabbit