Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on December 4
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| version = "0.6.0-rc.0" | ||
| source = "git+https://github.com/coasys/holochain.git?branch=0.6.0-rc.0-coasys#556a189c3ed008fd15c37863604d2d61f38d05f7" | ||
| version = "0.6.0-rc.1" | ||
| source = "git+https://github.com/coasys/holochain.git?branch=0.6.0-rc.2-coasys#dc5480b4b3adc4a87b3edb6e655e3a46bbe23c01" |
There was a problem hiding this comment.
Bug: Holochain RC Dependency Mismatch
The holochain_sqlite package version is set to 0.6.0-rc.1 while the git branch is updated to 0.6.0-rc.2-coasys. This creates a version mismatch inconsistent with the PR's intent to bump all Holochain RC dependencies to 0.6.0-rc.2. All other Holochain packages are correctly updated to 0.6.0-rc.2.
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughThe PR updates three holochain-related dependencies in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
rust-executor/Cargo.toml(1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: lucksus
Repo: coasys/ad4m PR: 630
File: bootstrap-languages/p-diff-sync/hc-dna/zomes/perspective_diff_sync/Cargo.toml:28-29
Timestamp: 2025-11-13T12:18:07.305Z
Learning: For Holochain 0.6.0-rc.0 (branch 0.6.0-rc.0-coasys), the correct and compatible HDI/HDK pairing is: hdi version 0.7.0-rc.0 and hdk version 0.6.0-rc.0. HDI is intentionally one minor version ahead of HDK in this release.
Learnt from: lucksus
Repo: coasys/ad4m PR: 630
File: bootstrap-languages/p-diff-sync/hc-dna/workdir/dna.yaml:2-2
Timestamp: 2025-11-13T12:17:37.357Z
Learning: For Holochain 0.6.0-rc.0, the correct manifest_version in DNA YAML files (dna.yaml) is 0, not 1. The mr_bundle library in Holochain 0.6.0-rc.0 errors when manifest_version is set to 1. The versioning appears to have been reset in this release.
📚 Learning: 2025-11-13T12:17:37.357Z
Learnt from: lucksus
Repo: coasys/ad4m PR: 630
File: bootstrap-languages/p-diff-sync/hc-dna/workdir/dna.yaml:2-2
Timestamp: 2025-11-13T12:17:37.357Z
Learning: For Holochain 0.6.0-rc.0, the correct manifest_version in DNA YAML files (dna.yaml) is 0, not 1. The mr_bundle library in Holochain 0.6.0-rc.0 errors when manifest_version is set to 1. The versioning appears to have been reset in this release.
Applied to files:
rust-executor/Cargo.toml
📚 Learning: 2025-11-13T12:18:07.305Z
Learnt from: lucksus
Repo: coasys/ad4m PR: 630
File: bootstrap-languages/p-diff-sync/hc-dna/zomes/perspective_diff_sync/Cargo.toml:28-29
Timestamp: 2025-11-13T12:18:07.305Z
Learning: For Holochain 0.6.0-rc.0 (branch 0.6.0-rc.0-coasys), the correct and compatible HDI/HDK pairing is: hdi version 0.7.0-rc.0 and hdk version 0.6.0-rc.0. HDI is intentionally one minor version ahead of HDK in this release.
Applied to files:
rust-executor/Cargo.toml
| holochain = { version = "0.6.0-rc.2", features = ["test_utils", "default", "backend-go-pion"], git = "https://github.com/coasys/holochain.git", branch = "0.6.0-rc.2-coasys" } | ||
| holochain_cli_bundle = { version = "0.6.0-rc.2", git = "https://github.com/coasys/holochain.git", branch = "0.6.0-rc.2-coasys" } | ||
| holochain_types = { version = "0.6.0-rc.2", git = "https://github.com/coasys/holochain.git", branch = "0.6.0-rc.2-coasys" } |
There was a problem hiding this comment.
🧩 Analysis chain
Verify dependency compatibility and testing coverage for rc.2 release.
This version bump to 0.6.0-rc.2 requires validation across the codebase, particularly given the learnings from prior rc.0 work around HDI/HDK version pairing. Additionally, the "backend-go-pion" feature flag is newly introduced and should be verified.
Please address the following before merging:
-
HDI/HDK Compatibility: From previous work (PR 630), HDI 0.7.0-rc.0 and HDK 0.6.0-rc.0 were the correct pairing for rc.0. Confirm whether rc.2 changes this pairing and verify all bootstrap language
Cargo.tomlfiles (inbootstrap-languages/*/hc-dna/zomes/*/Cargo.toml) have compatible HDI/HDK versions. -
Feature Flag Verification: The "backend-go-pion" feature is newly added to the holochain dependency. Confirm this feature is required, stable, and compatible with the rest of the codebase.
-
Cross-version Compatibility: Verify that
holochain_cli_run_local_services(0.5.0-dev.12) andkitsune_p2p_types(0.5.0-dev.9) remain compatible with holochain 0.6.0-rc.2. -
Testing: Confirm this rc.2 version has been tested in the environment and that all critical paths function as expected.
🏁 Script executed:
#!/bin/bash
# Description: Verify HDI/HDK versions in bootstrap languages are compatible with 0.6.0-rc.2
# Find all zome Cargo.toml files
fd -e Cargo.toml 'bootstrap-languages.*/hc-dna/zomes' --exec rg -n 'hdi|hdk' {} +Length of output: 0
🏁 Script executed:
#!/bin/bash
# Find all Cargo.toml files and search for hdi/hdk versions
echo "=== Searching for HDI/HDK versions in all Cargo.toml files ==="
fd -e Cargo.toml --exec rg -n 'hdi|hdk' {} +
echo ""
echo "=== Listing bootstrap-languages directory structure ==="
fd -t d 'bootstrap-languages' | head -20
echo ""
echo "=== Checking rust-executor Cargo.toml for holochain dependencies ==="
if [ -f "rust-executor/Cargo.toml" ]; then
rg -n 'holochain|hdi|hdk|kitsune_p2p' rust-executor/Cargo.toml
fiLength of output: 938
🏁 Script executed:
#!/bin/bash
# Find all Cargo.toml files and search for hdi/hdk versions
echo "=== Searching for HDI/HDK versions in all Cargo.toml files ==="
fd -e Cargo.toml --exec rg -n 'hdi|hdk' {} +
echo ""
echo "=== Listing bootstrap-languages directory structure ==="
find . -type d -name "bootstrap-languages" 2>/dev/null
echo ""
echo "=== Checking rust-executor Cargo.toml for holochain dependencies ==="
if [ -f "rust-executor/Cargo.toml" ]; then
rg -n 'holochain|hdi|hdk|kitsune_p2p' rust-executor/Cargo.toml
fi
echo ""
echo "=== Searching for backend-go-pion feature usage ==="
rg -n 'backend-go-pion' --type tomlLength of output: 1195
🏁 Script executed:
#!/bin/bash
# Deep dive into bootstrap-languages structure
echo "=== Listing bootstrap-languages directory contents ==="
ls -la bootstrap-languages/ 2>/dev/null || echo "Directory empty or missing"
echo ""
echo "=== Recursive file search in bootstrap-languages ==="
find bootstrap-languages -type f -name "*.toml" 2>/dev/null | head -20
echo ""
echo "=== Check for git submodules ==="
cat .gitmodules 2>/dev/null || echo "No .gitmodules file"
echo ""
echo "=== Search for any zome references ==="
rg -n 'zome|hdi|hdk' bootstrap-languages/ 2>/dev/null | head -20
echo ""
echo "=== Check rust-executor Cargo.toml full context around the changes ==="
sed -n '90,105p' rust-executor/Cargo.tomlLength of output: 5893
🏁 Script executed:
#!/bin/bash
# Check specific zome Cargo.toml files for dependencies
echo "=== p-diff-sync perspective_diff_sync/Cargo.toml ==="
cat bootstrap-languages/p-diff-sync/hc-dna/zomes/perspective_diff_sync/Cargo.toml 2>/dev/null || echo "File not found"
echo ""
echo "=== p-diff-sync perspective_diff_sync_integrity/Cargo.toml ==="
cat bootstrap-languages/p-diff-sync/hc-dna/zomes/perspective_diff_sync_integrity/Cargo.toml 2>/dev/null || echo "File not found"
echo ""
echo "=== agent-language agent_store/Cargo.toml ==="
cat bootstrap-languages/agent-language/hc-dna/zomes/agent_store/Cargo.toml 2>/dev/null || echo "File not found"
echo ""
echo "=== file-storage file_storage/Cargo.toml ==="
cat bootstrap-languages/file-storage/hc-dna/zomes/file_storage/Cargo.toml 2>/dev/null || echo "File not found"
echo ""
echo "=== Search for holochain, hdi, hdk with explicit paths ==="
rg 'holochain|hdi|hdk' bootstrap-languages/*/hc-dna/zomes/*/Cargo.tomlLength of output: 8303
🌐 Web query:
holochain 0.6.0-rc.2 backend-go-pion feature
💡 Result:
Yes — Holochain still exposes a backend-go-pion feature (the Pion WebRTC backend) as an optional WebRTC backend, but libdatachannel is the default. [1][2]
Sources:
[1] tx5 crate docs (describes backend-go-pion vs backend-libdatachannel).
[2] Holochain changelog (notes switch to libdatachannel as default while keeping go-pion as an option).
🏁 Script executed:
#!/bin/bash
# Check if bootstrap languages were modified in this PR
echo "=== Git status of bootstrap-languages files ==="
git status bootstrap-languages/ 2>/dev/null | head -30
echo ""
echo "=== Check git diff for bootstrap-languages ==="
git diff bootstrap-languages/ 2>/dev/null | head -50
echo ""
echo "=== List recent commits touching bootstrap-languages ==="
git log --oneline -10 -- bootstrap-languages/ 2>/dev/null
echo ""
echo "=== Check if any changes are staged ==="
git diff --cached bootstrap-languages/ 2>/dev/null | head -50Length of output: 738
🏁 Script executed:
#!/bin/bash
# Double-check bootstrap language Cargo.toml versions to confirm rc.0
echo "=== Confirming bootstrap language versions are still rc.0 ==="
rg 'version.*0.6.0-rc' bootstrap-languages/*/hc-dna/zomes/*/Cargo.toml | head -20
echo ""
echo "=== Compare with rust-executor rc.2 ==="
rg 'version.*0.6.0-rc' rust-executor/Cargo.tomlLength of output: 4205
Bootstrap language holochain versions must be updated to rc.2 to match rust-executor upgrade.
Verification reveals a critical version mismatch: rust-executor has been upgraded to holochain 0.6.0-rc.2 (branch 0.6.0-rc.2-coasys), but all bootstrap language zome dependencies remain pinned to 0.6.0-rc.0 (branch 0.6.0-rc.0-coasys). These are on different git branches and incompatible RC versions, which will cause build and runtime failures.
Update the following files to use version 0.6.0-rc.2 with branch 0.6.0-rc.2-coasys:
bootstrap-languages/agent-language/hc-dna/zomes/agent_store/Cargo.toml: hdk, holo_hashbootstrap-languages/agent-language/hc-dna/zomes/agent_store_integrity/Cargo.toml: hdi, hdk, holo_hashbootstrap-languages/direct-message-language/hc-dna/zomes/direct-message/Cargo.toml: hdk, holo_hashbootstrap-languages/direct-message-language/hc-dna/zomes/direct-message-integrity/Cargo.toml: hdi, holo_hashbootstrap-languages/file-storage/hc-dna/zomes/file_storage/Cargo.toml: hdk, holo_hashbootstrap-languages/file-storage/hc-dna/zomes/integrity/Cargo.toml: hdi, hdk, holo_hashbootstrap-languages/p-diff-sync/hc-dna/zomes/perspective_diff_sync/Cargo.toml: hdi, hdkbootstrap-languages/p-diff-sync/hc-dna/zomes/perspective_diff_sync_integrity/Cargo.toml: hdi, hdk, holo_hash
Also verify that holochain_cli_run_local_services (0.5.0-dev.12) and kitsune_p2p_types (0.5.0-dev.9) remain compatible with the new rc.2 versions, or update them accordingly.
1 participant
Simple version bump from
0.6.0-rc.0to0.6.0-rc.2.Note
Upgrades Holochain ecosystem crates to 0.6.0-rc.2 (sqlite to 0.6.0-rc.1) and updates rust-executor dependencies accordingly.
0.6.0-rc.0to0.6.0-rc.2inCargo.lock(e.g.,holochain,hdi,hdk,holo_hash,holochain_types,holochain_p2p,holochain_cascade,holochain_state,holochain_conductor_*,holochain_websocket,holochain_wasm_test_utils,holochain_zome_types,holochain_keystore,holochain_nonce,holochain_metrics,holochain_chc,mr_bundle, etc.).holochain_sqliteupdated to0.6.0-rc.1.rust-executor/Cargo.toml:holochain,holochain_cli_bundle,holochain_typesto0.6.0-rc.2withbranch = "0.6.0-rc.2-coasys".Written by Cursor Bugbot for commit d89bcdd. This will update automatically on new commits. Configure here.
Summary by CodeRabbit