Skip to content

Bump Holochain RC to 0.6.0-rc.2 #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lucksus wants to merge 1 commit into from
Closed

Bump Holochain RC to 0.6.0-rc.2 #631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 41 additions & 41 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions rust-executor/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,9 @@ webbrowser = "0.8.12"
holochain_cli_run_local_services = { version = "0.5.0-dev.12" }
kitsune_p2p_types = { version = "0.5.0-dev.9" }
kitsune2_api = "0.1.15"
holochain = { version = "0.6.0-rc.0", features = ["test_utils", "default", "backend-go-pion"], git = "https://github.com/coasys/holochain.git", branch = "0.6.0-rc.0-coasys" }
holochain_cli_bundle = { version = "0.6.0-rc.0", git = "https://github.com/coasys/holochain.git", branch = "0.6.0-rc.0-coasys" }
holochain_types = { version = "0.6.0-rc.0", git = "https://github.com/coasys/holochain.git", branch = "0.6.0-rc.0-coasys" }
holochain = { version = "0.6.0-rc.2", features = ["test_utils", "default", "backend-go-pion"], git = "https://github.com/coasys/holochain.git", branch = "0.6.0-rc.2-coasys" }
holochain_cli_bundle = { version = "0.6.0-rc.2", git = "https://github.com/coasys/holochain.git", branch = "0.6.0-rc.2-coasys" }
holochain_types = { version = "0.6.0-rc.2", git = "https://github.com/coasys/holochain.git", branch = "0.6.0-rc.2-coasys" }
Comment on lines +98 to +100
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Verify dependency compatibility and testing coverage for rc.2 release.

This version bump to 0.6.0-rc.2 requires validation across the codebase, particularly given the learnings from prior rc.0 work around HDI/HDK version pairing. Additionally, the "backend-go-pion" feature flag is newly introduced and should be verified.

Please address the following before merging:

  1. HDI/HDK Compatibility: From previous work (PR 630), HDI 0.7.0-rc.0 and HDK 0.6.0-rc.0 were the correct pairing for rc.0. Confirm whether rc.2 changes this pairing and verify all bootstrap language Cargo.toml files (in bootstrap-languages/*/hc-dna/zomes/*/Cargo.toml) have compatible HDI/HDK versions.

  2. Feature Flag Verification: The "backend-go-pion" feature is newly added to the holochain dependency. Confirm this feature is required, stable, and compatible with the rest of the codebase.

  3. Cross-version Compatibility: Verify that holochain_cli_run_local_services (0.5.0-dev.12) and kitsune_p2p_types (0.5.0-dev.9) remain compatible with holochain 0.6.0-rc.2.

  4. Testing: Confirm this rc.2 version has been tested in the environment and that all critical paths function as expected.

🏁 Script executed:

#!/bin/bash
# Description: Verify HDI/HDK versions in bootstrap languages are compatible with 0.6.0-rc.2

# Find all zome Cargo.toml files
fd -e Cargo.toml 'bootstrap-languages.*/hc-dna/zomes' --exec rg -n 'hdi|hdk' {} +

Length of output: 0

🏁 Script executed:

#!/bin/bash
# Find all Cargo.toml files and search for hdi/hdk versions
echo "=== Searching for HDI/HDK versions in all Cargo.toml files ==="
fd -e Cargo.toml --exec rg -n 'hdi|hdk' {} +

echo ""
echo "=== Listing bootstrap-languages directory structure ==="
fd -t d 'bootstrap-languages' | head -20

echo ""
echo "=== Checking rust-executor Cargo.toml for holochain dependencies ==="
if [ -f "rust-executor/Cargo.toml" ]; then
  rg -n 'holochain|hdi|hdk|kitsune_p2p' rust-executor/Cargo.toml
fi

Length of output: 938

🏁 Script executed:

#!/bin/bash
# Find all Cargo.toml files and search for hdi/hdk versions
echo "=== Searching for HDI/HDK versions in all Cargo.toml files ==="
fd -e Cargo.toml --exec rg -n 'hdi|hdk' {} +

echo ""
echo "=== Listing bootstrap-languages directory structure ==="
find . -type d -name "bootstrap-languages" 2>/dev/null

echo ""
echo "=== Checking rust-executor Cargo.toml for holochain dependencies ==="
if [ -f "rust-executor/Cargo.toml" ]; then
  rg -n 'holochain|hdi|hdk|kitsune_p2p' rust-executor/Cargo.toml
fi

echo ""
echo "=== Searching for backend-go-pion feature usage ==="
rg -n 'backend-go-pion' --type toml

Length of output: 1195

🏁 Script executed:

#!/bin/bash
# Deep dive into bootstrap-languages structure
echo "=== Listing bootstrap-languages directory contents ==="
ls -la bootstrap-languages/ 2>/dev/null || echo "Directory empty or missing"

echo ""
echo "=== Recursive file search in bootstrap-languages ==="
find bootstrap-languages -type f -name "*.toml" 2>/dev/null | head -20

echo ""
echo "=== Check for git submodules ==="
cat .gitmodules 2>/dev/null || echo "No .gitmodules file"

echo ""
echo "=== Search for any zome references ==="
rg -n 'zome|hdi|hdk' bootstrap-languages/ 2>/dev/null | head -20

echo ""
echo "=== Check rust-executor Cargo.toml full context around the changes ==="
sed -n '90,105p' rust-executor/Cargo.toml

Length of output: 5893

🏁 Script executed:

#!/bin/bash
# Check specific zome Cargo.toml files for dependencies
echo "=== p-diff-sync perspective_diff_sync/Cargo.toml ==="
cat bootstrap-languages/p-diff-sync/hc-dna/zomes/perspective_diff_sync/Cargo.toml 2>/dev/null || echo "File not found"

echo ""
echo "=== p-diff-sync perspective_diff_sync_integrity/Cargo.toml ==="
cat bootstrap-languages/p-diff-sync/hc-dna/zomes/perspective_diff_sync_integrity/Cargo.toml 2>/dev/null || echo "File not found"

echo ""
echo "=== agent-language agent_store/Cargo.toml ==="
cat bootstrap-languages/agent-language/hc-dna/zomes/agent_store/Cargo.toml 2>/dev/null || echo "File not found"

echo ""
echo "=== file-storage file_storage/Cargo.toml ==="
cat bootstrap-languages/file-storage/hc-dna/zomes/file_storage/Cargo.toml 2>/dev/null || echo "File not found"

echo ""
echo "=== Search for holochain, hdi, hdk with explicit paths ==="
rg 'holochain|hdi|hdk' bootstrap-languages/*/hc-dna/zomes/*/Cargo.toml

Length of output: 8303

🌐 Web query:

holochain 0.6.0-rc.2 backend-go-pion feature

💡 Result:

Yes — Holochain still exposes a backend-go-pion feature (the Pion WebRTC backend) as an optional WebRTC backend, but libdatachannel is the default. [1][2]

Sources:
[1] tx5 crate docs (describes backend-go-pion vs backend-libdatachannel).
[2] Holochain changelog (notes switch to libdatachannel as default while keeping go-pion as an option).

🏁 Script executed:

#!/bin/bash
# Check if bootstrap languages were modified in this PR
echo "=== Git status of bootstrap-languages files ==="
git status bootstrap-languages/ 2>/dev/null | head -30

echo ""
echo "=== Check git diff for bootstrap-languages ==="
git diff bootstrap-languages/ 2>/dev/null | head -50

echo ""
echo "=== List recent commits touching bootstrap-languages ==="
git log --oneline -10 -- bootstrap-languages/ 2>/dev/null

echo ""
echo "=== Check if any changes are staged ==="
git diff --cached bootstrap-languages/ 2>/dev/null | head -50

Length of output: 738

🏁 Script executed:

#!/bin/bash
# Double-check bootstrap language Cargo.toml versions to confirm rc.0
echo "=== Confirming bootstrap language versions are still rc.0 ==="
rg 'version.*0.6.0-rc' bootstrap-languages/*/hc-dna/zomes/*/Cargo.toml | head -20

echo ""
echo "=== Compare with rust-executor rc.2 ==="
rg 'version.*0.6.0-rc' rust-executor/Cargo.toml

Length of output: 4205

Bootstrap language holochain versions must be updated to rc.2 to match rust-executor upgrade.

Verification reveals a critical version mismatch: rust-executor has been upgraded to holochain 0.6.0-rc.2 (branch 0.6.0-rc.2-coasys), but all bootstrap language zome dependencies remain pinned to 0.6.0-rc.0 (branch 0.6.0-rc.0-coasys). These are on different git branches and incompatible RC versions, which will cause build and runtime failures.

Update the following files to use version 0.6.0-rc.2 with branch 0.6.0-rc.2-coasys:

  • bootstrap-languages/agent-language/hc-dna/zomes/agent_store/Cargo.toml: hdk, holo_hash
  • bootstrap-languages/agent-language/hc-dna/zomes/agent_store_integrity/Cargo.toml: hdi, hdk, holo_hash
  • bootstrap-languages/direct-message-language/hc-dna/zomes/direct-message/Cargo.toml: hdk, holo_hash
  • bootstrap-languages/direct-message-language/hc-dna/zomes/direct-message-integrity/Cargo.toml: hdi, holo_hash
  • bootstrap-languages/file-storage/hc-dna/zomes/file_storage/Cargo.toml: hdk, holo_hash
  • bootstrap-languages/file-storage/hc-dna/zomes/integrity/Cargo.toml: hdi, hdk, holo_hash
  • bootstrap-languages/p-diff-sync/hc-dna/zomes/perspective_diff_sync/Cargo.toml: hdi, hdk
  • bootstrap-languages/p-diff-sync/hc-dna/zomes/perspective_diff_sync_integrity/Cargo.toml: hdi, hdk, holo_hash

Also verify that holochain_cli_run_local_services (0.5.0-dev.12) and kitsune_p2p_types (0.5.0-dev.9) remain compatible with the new rc.2 versions, or update them accordingly.

lair_keystore_api = { version = "0.6.3", git = "https://github.com/coasys/lair.git", branch = "0.6.3-coasys" }
sodoken = "=0.1.0"

Expand Down