ProgressStyle enable/disable colors based on draw target#699
Merged
djc merged 3 commits intoconsole-rs:mainfrom Mar 24, 2025
tonywu6:feat/progressstyle-color-stderr
Merged
ProgressStyle enable/disable colors based on draw target#699djc merged 3 commits intoconsole-rs:mainfrom tonywu6:feat/progressstyle-color-stderr
ProgressStyle enable/disable colors based on draw target#699djc merged 3 commits intoconsole-rs:mainfrom
tonywu6:feat/progressstyle-color-stderr
Conversation
2 tasks
djc
reviewed
Mar 24, 2025
Member
djc
left a comment
djc
left a comment
There was a problem hiding this comment.
Thanks, this looks like a nice improvement!
djc
reviewed
Mar 24, 2025
djc
approved these changes
Mar 24, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #698
A
ProgressBarusing stderr as the draw target will now implicitly use stderr to determine if colors are enabled (by configuring itsProgressStyle).Previously, this was not configured, so the default behavior was to detect colors using stdout no matter what.