Skip to content

ci, go.mod: bump to go 1.23#1094

Merged
mmorel-35 merged 3 commits intocontainernetworking:mainfrom
squeed:go1.23
Sep 17, 2024
Merged

ci, go.mod: bump to go 1.23#1094
mmorel-35 merged 3 commits intocontainernetworking:mainfrom
squeed:go1.23

Conversation

@squeed
Copy link
Copy Markdown
Member

@squeed squeed commented Sep 17, 2024

This should stop dependabot from adding a toolchain directive.

@squeed
Copy link
Copy Markdown
Member Author

squeed commented Sep 17, 2024

Whoops, need to bump golangci-lint too.

@squeed
Copy link
Copy Markdown
Member Author

squeed commented Sep 17, 2024

@mmorel-35 oops, looks like we stepped on each other's toes.

Now that go.mod matches our go version, we can stop setting go version
in CI separately.

Signed-off-by: Casey Callendrello <c1@caseyc.net>
Bumping golangci-lint to v1.61 introduced some new reasonable checks;
fix the errors they found.

Signed-off-by: Casey Callendrello <c1@caseyc.net>
Also, fix some deprecated config directives.

Signed-off-by: Casey Callendrello <c1@caseyc.net>
@squeed
Copy link
Copy Markdown
Member Author

squeed commented Sep 17, 2024

whew. @mmorel-35 that should have it :-).

@mmorel-35 mmorel-35 merged commit e5df283 into containernetworking:main Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants