Skip to content

Bump Go version to 1.23 in scripts/release.sh#1123

Merged
s1061123 merged 1 commit intocontainernetworking:mainfrom
jingyuanliang:patch-1
Jan 6, 2025
Merged

Bump Go version to 1.23 in scripts/release.sh#1123
s1061123 merged 1 commit intocontainernetworking:mainfrom
jingyuanliang:patch-1

Conversation

@jingyuanliang
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems right to me to match up the version bumped in #1094.
/cc @squeed

Signed-off-by: Jingyuan Liang <jingyuanliang@google.com>
Copy link
Copy Markdown
Contributor

@s1061123 s1061123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Merge it soon.

BTW, we no longer uses this script file because it is for 'manual release process that is used previously'. Now we use github action to automate process. So this file (scripts/release.sh) will be removed soon. Just FYI.

@s1061123 s1061123 merged commit ba8bc7d into containernetworking:main Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants