fix(proof-libs) Remove fields that shouldn't be in PartialOrd.#1473
Merged
maximebuyse merged 2 commits intomainfrom May 26, 2025
Merged
fix(proof-libs) Remove fields that shouldn't be in PartialOrd.#1473maximebuyse merged 2 commits intomainfrom
maximebuyse merged 2 commits intomainfrom
Conversation
W95Psp
reviewed
May 26, 2025
Contributor
W95Psp
left a comment
There was a problem hiding this comment.
Those function are somehow legit: they are indeed part of that trait, but are default.
The F* backend doesn't add the default methods automatically, see #888.
But here those function will probably be missing as well if we remove them.
Can you make standalone functions named the same? e.g.
let f_lt #v_Self #v_Rhs {| t_PartialOrd v_Self v_Rhs |} (self: v_Self) (rhs: v_Rhs) = (* something with partial_cmp *)Not sure about the naming, let's try to make something where calling f_lt works.
W95Psp
approved these changes
May 26, 2025
Contributor
W95Psp
left a comment
There was a problem hiding this comment.
Thanks, that looks good to me!
Contributor
|
With this change, fstar still supports the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1472