Skip to content

fix(proof-libs) Remove fields that shouldn't be in PartialOrd. #1473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maximebuyse merged 2 commits into from
May 26, 2025
Merged

fix(proof-libs) Remove fields that shouldn't be in PartialOrd. #1473

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23ad549
Remove fields that shouldn't be in PartialOrd.
maximebuyse May 26, 2025
a71c5fb
Define comparisons when partial ord is implemented.
maximebuyse May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 20 additions & 16 deletions proof-libs/fstar/core/Core.Cmp.fsti
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,24 +32,28 @@ class t_PartialOrd (v_Self: Type) (v_Rhs:Type) = {
f_partial_cmp_pre: v_Self -> v_Rhs -> Type0;
f_partial_cmp_post: v_Self -> v_Rhs -> Core.Option.t_Option t_Ordering -> Type0;
f_partial_cmp:v_Self -> v_Rhs -> Core.Option.t_Option t_Ordering;

f_ge_pre: v_Self -> v_Rhs -> Type0;
f_ge_post: v_Self -> v_Rhs -> Type0;
f_ge: v_Self -> v_Rhs -> bool;

f_gt_pre: v_Self -> v_Rhs -> Type0;
f_gt_post: v_Self -> v_Rhs -> Type0;
f_gt: v_Self -> v_Rhs -> bool;

f_le_pre: v_Self -> v_Rhs -> Type0;
f_le_post: v_Self -> v_Rhs -> Type0;
f_le: v_Self -> v_Rhs -> bool;

f_lt_pre: v_Self -> v_Rhs -> Type0;
f_lt_post: v_Self -> v_Rhs -> Type0;
f_lt: v_Self -> v_Rhs -> bool;
}

let f_lt #v_Self #v_Rhs {| t_PartialOrd v_Self v_Rhs |} (self: v_Self) (rhs: v_Rhs) =
match f_partial_cmp self rhs with
Core.Option.Option_Some Ordering_Less -> true
| _ -> false

let f_le #v_Self #v_Rhs {| t_PartialOrd v_Self v_Rhs |} (self: v_Self) (rhs: v_Rhs) =
match f_partial_cmp self rhs with
Core.Option.Option_Some Ordering_Greater -> false
| _ -> true

let f_gt #v_Self #v_Rhs {| t_PartialOrd v_Self v_Rhs |} (self: v_Self) (rhs: v_Rhs) =
match f_partial_cmp self rhs with
Core.Option.Option_Some Ordering_Greater -> true
| _ -> false

let f_ge #v_Self #v_Rhs {| t_PartialOrd v_Self v_Rhs |} (self: v_Self) (rhs: v_Rhs) =
match f_partial_cmp self rhs with
Core.Option.Option_Some Ordering_Less -> false
| _ -> true

class t_Ord (v_Self: Type) = {
_super_641474646876120386: t_Eq v_Self;
_super_12012119932897234219: t_PartialOrd v_Self v_Self;
Expand Down
Loading