Skip to content

feat(rengine): resugaring: add FunctionsToConstants#1659

Merged
W95Psp merged 3 commits intomainfrom
rengine-resugargin-FunctionsToConstants
Sep 8, 2025
Merged

feat(rengine): resugaring: add FunctionsToConstants#1659
W95Psp merged 3 commits intomainfrom
rengine-resugargin-FunctionsToConstants

Conversation

@W95Psp
Copy link
Copy Markdown
Contributor

@W95Psp W95Psp commented Sep 4, 2025

Transforms ItemKind::Fn of arity zero into ResugaredItemKind::Constant.
Rust const items are encoded by the ImportThir phase of the hax engine as function of arity zero.
Functions of arity zero themselves are encoded as functions operating on one argument of type ().

@W95Psp W95Psp force-pushed the rengine-resugargin-FunctionsToConstants branch 2 times, most recently from 34db5f9 to b5b4680 Compare September 4, 2025 12:33
@W95Psp W95Psp marked this pull request as ready for review September 4, 2025 12:34
@W95Psp W95Psp requested a review from a team as a code owner September 4, 2025 12:34
Copy link
Copy Markdown
Member

@keks keks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one question, out of curiosity :)

@W95Psp W95Psp requested review from maximebuyse and removed request for clementblaudeau September 8, 2025 15:08
@W95Psp W95Psp force-pushed the rengine-resugargin-FunctionsToConstants branch from be2682d to 9a6031d Compare September 8, 2025 15:09
@W95Psp W95Psp enabled auto-merge September 8, 2025 15:24
@W95Psp W95Psp added this pull request to the merge queue Sep 8, 2025
github-merge-queue bot pushed a commit that referenced this pull request Sep 8, 2025
…onstants

feat(rengine): resugaring: add `FunctionsToConstants`
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 8, 2025
@W95Psp W95Psp added this pull request to the merge queue Sep 8, 2025
Merged via the queue into main with commit 2b548b6 Sep 8, 2025
17 of 19 checks passed
@W95Psp W95Psp deleted the rengine-resugargin-FunctionsToConstants branch September 8, 2025 19:01
@W95Psp W95Psp restored the rengine-resugargin-FunctionsToConstants branch January 15, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants