feat(lean): Use FunctionsToConstants#1738
Merged
clementblaudeau merged 4 commits intomainfrom Oct 21, 2025
Merged
Conversation
maximebuyse
approved these changes
Oct 9, 2025
Contributor
maximebuyse
left a comment
There was a problem hiding this comment.
Looks good, only one comment.
52023fe to
dc931f9
Compare
Contributor
Author
|
Rebased on main, let's merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves lean support for constants, using the
FunctionToConstantsresugaring. It removes the ad-hoc treatment of litteral consts.Overview
A rust const can contain possibly panicking computation, like:
However, this is computed at compile time by rustc, so we can expect panic-freedom at extraction-time. In the Lean prelude, we add the two functions:
The extracted code hardcodes a proof of panic-freedom by computation
(by rfl), which should always work:Closes #1614