fix(codex): preserve apps in managed remote startup#310
fix(codex): preserve apps in managed remote startup#310danshapiro wants to merge 7 commits intocodex/fix-codex-appserver-boot-stall-basefrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3d214162d3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| session, | ||
| paneContent: paneContentRef.current, | ||
| currentTab, | ||
| currentTab: tabHasSinglePane ? currentTab : undefined, |
There was a problem hiding this comment.
Avoid unconditional flush for split agent-chat panes
When tabHasSinglePane is false, this passes undefined as currentTab into buildAgentChatPersistedIdentityUpdate, but that helper still treats the missing tab session as a mismatch and sets shouldFlush to true. In split tabs, any subsequent session updates can therefore keep dispatching flushPersistedLayoutNow() even when neither pane nor tab identity actually changed, causing unnecessary immediate persistence work and write churn.
Useful? React with 👍 / 👎.
Summary
codex --remote,codex_apps, and Freshell MCP instead of disabling Apps-c mcp_servers.freshell...config andFRESHELL_*environment into the managedcodex app-serversidecar, which is the process that actually bootscodex_apps/api/tabsand/api/runfeatures.apps=falseworkaroundRoot cause
codex --remoteTUI processcodex --remotedid not forward that local config to the externalcodex app-server; tracedthread/startshowedconfig: nullBooting MCP server: codex_appsValidation
npm run test:server -- --run test/unit/server/coding-cli/codex-app-server/launch-planner.test.ts test/integration/server/codex-session-flow.test.tsnpm run test:server -- --run test/server/agent-panes-write.test.ts test/server/agent-run.test.ts test/server/agent-tabs-write.test.ts test/server/ws-protocol.test.ts test/server/ws-terminal-create-reuse-running-codex.test.tsFRESHELL_TEST_SUMMARY='codex app-server no-loss startup fix before local main landing' npm testfreshellandcodex_appsMCP readiness, and the Codex prompt appears without disabling Apps