Disable Codex Apps in managed remote launches#311
Conversation
# Conflicts: # server/coding-cli/codex-app-server/launch-planner.ts # test/fixtures/coding-cli/codex-app-server/fake-app-server.mjs # test/integration/server/codex-session-flow.test.ts # test/unit/server/coding-cli/codex-app-server/launch-planner.test.ts
|
Closing this PR because it was created against remote |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b59ef8b81
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| private readonly createSidecar: (input: PlanCreateInput) => Pick<CodexTerminalSidecar, 'ensureReady' | 'attachTerminal' | 'shutdown'> | ||
| = (input) => new CodexTerminalSidecar({ cwd: input.cwd }), | ||
| ) {} |
There was a problem hiding this comment.
CodexLaunchPlanner.planCreate now builds a sidecar using only cwd, and the model/sandbox/approvalPolicy fields in PlanCreateInput are never applied anywhere in this flow. Before this change, those values were forwarded via startThread; now codex terminals launched through this planner silently ignore configured model/sandbox preferences and always use Codex defaults.
Useful? React with 👍 / 👎.
| try { | ||
| process.kill(pid, 'SIGTERM') | ||
| } catch (error) { |
There was a problem hiding this comment.
reapOrphanedSidecars sends SIGTERM to any process matching a metadata file, but those metadata files are also written for healthy, currently attached sidecars. Because startup unconditionally runs this reaper, bringing up a second Freshell process can kill codex sidecars that are still active in another running instance, dropping live codex sessions unexpectedly.
Useful? React with 👍 / 👎.
1 participant
Summary
codex app-serversidecars.codex --remoteCodex panes.Validation
npm run test:vitest -- --config vitest.server.config.ts test/unit/server/coding-cli/codex-app-server/runtime.test.ts test/unit/server/terminal-registry.test.ts test/integration/server/codex-session-flow.test.tsFRESHELL_TEST_SUMMARY=codex-managed-remote-apps npm testcodex -c features.apps=false app-server --listen ws://127.0.0.1:<port>initialized successfully over websocket.