feat: Initial WSL1 support#1207
Merged
facekapow merged 1 commit intodarlinghq:masterfrom Aug 22, 2022
Merged
Conversation
facekapow
reviewed
Aug 21, 2022
Member
facekapow
left a comment
facekapow
left a comment
There was a problem hiding this comment.
Looks great! Let me do some testing locally to check it doesn't break Darling outside of WSL1.
- mldr: Replaced `mmap` calls with `compatible_mmap`, a function that removes `MAP_GROWSDOWN` on incompatible systems, and emulates `MAP_FIXED_NOREPLACE` on older kernels. - mldr: Implemented lifetime pipes. These pipes are created during process creation and sent to darlingserver. The pipe is preserved through exec calls and automatically closes on process termination. - kernel/emulation: `execve` now preserves mldr lifetime pipes through the `__mldr_lifetime_pipe` environment variable. - kernel/emulation: Parameters for calls to `dserver_rpc_checkin` have been updated to reflect changes in darlingserver.
trungnt2910
force-pushed
the
dev/trungnt2910/wsl1-support
branch
from
be9c27e to
7ca12cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1206.
Should not be reviewed/merged before darlinghq/darlingserver#4.
mmapcalls withcompatible_mmap, a functionthat removes
MAP_GROWSDOWNon incompatible systems, and emulatesMAP_FIXED_NOREPLACEon older kernels.process creation and sent to darlingserver. The pipe is preserved
through exec calls and automatically closes on process termination.
execvenow preserves mldr lifetime pipes throughthe
__mldr_lifetime_pipeenvironment variable.dserver_rpc_checkinhavebeen updated to reflect changes in darlingserver.