Merged
Conversation
- Implemented an alternative to pidfd_open for kernels older than 5.3. mldr should send a "lifetime pipe" to darlingserver during process start. When the process dies, darlingserver should receive a POLLHUP event. - Set increased_limit.rlim_cur to default_limit.rlim_max on systems without /proc/sys/fs/nr_open. On WSL1, this greatly increases the number of open file descriptors available. - For systems without NSpid in /proc/self/status, implemented a way to manage thread IDs in darlingserver during checkin. darlingserver should receive a hint address on the thread's stack, and then compare it with a stack pointer retrieved using PTRACE_GETREGS - Avoided sending socket messages when msg_hdr.msg_name->sun_path is an empty string. A null msg_name is used instead, otherwise, on some systems, this would fail with EINVAL.
This was referenced Aug 21, 2022
facekapow
reviewed
Aug 21, 2022
Member
facekapow
left a comment
facekapow
left a comment
There was a problem hiding this comment.
Everything looks great! Let me just do some testing to ensure this doesn't break Darling on non-WSL1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of darlinghq/darling#1206.
mldr should send a "lifetime pipe" to darlingserver during process start.
When the process dies, darlingserver should receive a POLLHUP event.
/proc/sys/fs/nr_open. On WSL1, this greatly increases the number of open file
descriptors available.
thread IDs in darlingserver during checkin. darlingserver should receive a hint
address on the thread's stack, and then compare it with a stack pointer retrieved using
PTRACE_GETREGS
A null msg_name is used instead, otherwise, on some systems, this would fail with EINVAL.