breaking: pt: remove data stat from model init#3245
Merged
wanghan-iapcm merged 9 commits intodeepmodeling:develfrom Feb 10, 2024
Merged
breaking: pt: remove data stat from model init#3245wanghan-iapcm merged 9 commits intodeepmodeling:develfrom
wanghan-iapcm merged 9 commits intodeepmodeling:develfrom
Conversation
Restore deepmodeling#3233 with resolved conflicts and conversations.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## devel #3245 +/- ##
==========================================
+ Coverage 75.19% 75.30% +0.10%
==========================================
Files 372 372
Lines 33136 33220 +84
Branches 1608 1608
==========================================
+ Hits 24916 25015 +99
+ Misses 7347 7332 -15
Partials 873 873 ☔ View full report in Codecov by Sentry. |
wanghan-iapcm
requested changes
Feb 8, 2024
Collaborator
wanghan-iapcm
left a comment
wanghan-iapcm
left a comment
There was a problem hiding this comment.
Are the data stats of descriptor and fitting tested by UTs?
njzjz
reviewed
Feb 8, 2024
Member
Author
source/tests/pt/test_stat.py has the UTs to compare the consistence of data stats between tf and pt, on both descriptor and fitting but only on se_a model. |
Signed-off-by: Duo <50307526+iProzd@users.noreply.github.com>
for more information, see https://pre-commit.ci
| } | ||
|
|
||
| def init_desc_stat(self, sumr, suma, sumn, sumr2, suma2): | ||
| def init_desc_stat(self, sumr, suma, sumn, sumr2, suma2, **kwargs): |
Check warning
Code scanning / CodeQL
Signature mismatch in overriding method
| } | ||
|
|
||
| def init_desc_stat(self, sumr, suma, sumn, sumr2, suma2): | ||
| def init_desc_stat(self, sumr, suma, sumn, sumr2, suma2, **kwargs): |
Check warning
Code scanning / CodeQL
Signature mismatch in overriding method
| } | ||
|
|
||
| def init_desc_stat(self, sumr, suma, sumn, sumr2, suma2): | ||
| def init_desc_stat(self, sumr, suma, sumn, sumr2, suma2, **kwargs): |
Check warning
Code scanning / CodeQL
Signature mismatch in overriding method
njzjz
approved these changes
Feb 9, 2024
wanghan-iapcm
requested changes
Feb 9, 2024
wanghan-iapcm
approved these changes
Feb 10, 2024
njzjz
pushed a commit
to njzjz/deepmd-kit
that referenced
this pull request
Feb 10, 2024
Restore deepmodeling#3233 with resolved conflicts and conversations. This PR clean up the data stat process from model init. Please note that this code PR is just an initial cleanup and refinement of the data stat, and a more detailed design of the data stat will be completed in the next PR: - independent data stat from dataloader - data stat support for hybrid descriptors --------- Signed-off-by: Duo <50307526+iProzd@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore #3233 with resolved conflicts and conversations.
This PR clean up the data stat process from model init.
Please note that this code PR is just an initial cleanup and refinement of the data stat, and a more detailed design of the data stat will be completed in the next PR: