Skip to content

Add missing package reference to System.Data.Common#4063

Open
cheenamalhotra wants to merge 1 commit intomainfrom
dev/cheena/fix-dependency
Open

Add missing package reference to System.Data.Common#4063
cheenamalhotra wants to merge 1 commit intomainfrom
dev/cheena/fix-dependency

Conversation

@cheenamalhotra
Copy link
Member

@cheenamalhotra cheenamalhotra commented Mar 18, 2026

Fixes #4062

Copilot AI review requested due to automatic review settings March 18, 2026 00:51
@github-project-automation github-project-automation bot moved this to To triage in SqlClient Board Mar 18, 2026
@cheenamalhotra cheenamalhotra added this to the 7.0.1 milestone Mar 18, 2026
@cheenamalhotra cheenamalhotra moved this from To triage to In progress in SqlClient Board Mar 18, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an explicit System.Data.Common dependency to the SqlClient build and packaging metadata so the net462 target has a direct/declared reference instead of relying on implicit or transitive resolution.

Changes:

  • Add System.Data.Common as a PackageReference for the net462 build of Microsoft.Data.SqlClient.
  • Add System.Data.Common to the netfx reference-assembly project’s package references.
  • Pin System.Data.Common centrally and declare it as a net462 dependency in the .nuspec.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
tools/specs/Microsoft.Data.SqlClient.nuspec Declares System.Data.Common (4.3.0) as a net462 NuGet dependency.
src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.csproj Adds System.Data.Common package reference for the net462 target.
src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.csproj Adds System.Data.Common package reference for the net462 reference assembly build.
Directory.Packages.props Centrally pins System.Data.Common to 4.3.0.

You can also share your feedback on Copilot code review. Take the survey.

@codecov
Copy link

codecov bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.44%. Comparing base (ce38e64) to head (e856b24).
⚠️ Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (ce38e64) and HEAD (e856b24). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (ce38e64) HEAD (e856b24)
CI-SqlClient 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4063      +/-   ##
==========================================
- Coverage   75.09%   68.44%   -6.66%     
==========================================
  Files         280      275       -5     
  Lines       43830    66930   +23100     
==========================================
+ Hits        32914    45807   +12893     
- Misses      10916    21123   +10207     
Flag Coverage Δ
CI-SqlClient ?
PR-SqlClient-Project 68.44% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cheenamalhotra cheenamalhotra marked this pull request as ready for review March 18, 2026 17:59
@cheenamalhotra cheenamalhotra requested a review from a team as a code owner March 18, 2026 17:59
@cheenamalhotra cheenamalhotra moved this from In progress to In review in SqlClient Board Mar 18, 2026
@mdaigle
Copy link
Contributor

mdaigle commented Mar 18, 2026

@copilot When were these references removed? Can you point to a specific PR?

Copy link
Contributor

Copilot AI commented Mar 18, 2026

@mdaigle I've opened a new pull request, #4066, to work on those changes. Once the pull request is ready, I'll request review from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

System.Data.Common required on net classic after updating to v7

5 participants