Skip to content

Add missing System.Data.Common package reference for net462#4066

Closed
Copilot wants to merge 1 commit intodev/cheena/fix-dependencyfrom
copilot/sub-pr-4063
Closed

Add missing System.Data.Common package reference for net462#4066
Copilot wants to merge 1 commit intodev/cheena/fix-dependencyfrom
copilot/sub-pr-4063

Conversation

Copy link
Contributor

Copilot AI commented Mar 18, 2026

System.Data.Common was accidentally dropped from the net462 build and packaging metadata in PR #3686 (Adding support for .NET 10), which cleaned up packages now included in the .NET 10 BCL. System.Data.Common is still a required dependency for the net462 target.

Description

  • Re-adds System.Data.Common 4.3.0 to Directory.Packages.props (central version management)
  • Re-adds PackageReference for System.Data.Common in the net462 ItemGroup of Microsoft.Data.SqlClient.csproj
  • Re-adds PackageReference for System.Data.Common to the netfx reference assembly project (netfx/ref/Microsoft.Data.SqlClient.csproj)
  • Re-adds System.Data.Common 4.3.0 as a net462 dependency in tools/specs/Microsoft.Data.SqlClient.nuspec

Issues

Fixes #4062

Testing

No test changes required — this restores a missing package reference that was inadvertently removed. The existing net462 build and packaging pipeline validates the dependency graph.

Guidelines

Please review the contribution guidelines before submitting a pull request:


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@github-project-automation github-project-automation bot moved this to To triage in SqlClient Board Mar 18, 2026
Copilot AI changed the title [WIP] [4062] Add missing package reference to System.Data.Common Add missing System.Data.Common package reference for net462 Mar 18, 2026
Copilot AI requested a review from mdaigle March 18, 2026 18:30
@cheenamalhotra cheenamalhotra marked this pull request as ready for review March 18, 2026 19:46
Copilot AI review requested due to automatic review settings March 18, 2026 19:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


You can also share your feedback on Copilot code review. Take the survey.

@paulmedynski paulmedynski moved this from To triage to In review in SqlClient Board Mar 19, 2026
@paulmedynski paulmedynski added this to the 7.0.1 milestone Mar 19, 2026
@paulmedynski
Copy link
Contributor

No content to merge. This was meant to be a conversation with Copilot - not a work item.

@github-project-automation github-project-automation bot moved this from In review to Done in SqlClient Board Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants