Skip to content

Move SB metadata to intermediates#4487

Merged
MichaelSimons merged 3 commits intodotnet:mainfrom
ellahathaway:sb-metadata
Feb 2, 2024
Merged

Move SB metadata to intermediates#4487
MichaelSimons merged 3 commits intodotnet:mainfrom
ellahathaway:sb-metadata

Conversation

@ellahathaway
Copy link
Copy Markdown
Member

The changes in this pull request aim to improve the UX and guideance around the SourceBuild metadata by placing the metadata on explicit source-build intermediates.

The changes include:

  • Removing existing SourceBuild metadata from all non-intermediate dependencies.
  • Defining new explicit intermediate dependencies and adding SourceBuild metadata to those dependencies.

Related to dotnet/source-build#3373 and dotnet/source-build#4073

@ellahathaway
Copy link
Copy Markdown
Member Author

@mthalman Are you able to merge this for me? I can't do it myself since I'm not an authorized user. Thanks in advance!

Comment thread eng/Versions.props Outdated
@mthalman
Copy link
Copy Markdown
Member

mthalman commented Feb 2, 2024

@mthalman Are you able to merge this for me? I can't do it myself since I'm not an authorized user. Thanks in advance!

I don't have permission

@MichaelSimons
Copy link
Copy Markdown
Member

@mthalman Are you able to merge this for me? I can't do it myself since I'm not an authorized user. Thanks in advance!

I don't have permission

I can merge it for you.

@MichaelSimons MichaelSimons merged commit 05ee3cf into dotnet:main Feb 2, 2024
@ellahathaway ellahathaway deleted the sb-metadata branch February 2, 2024 20:58
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants