Merged
Conversation
b3fe3d8 to
942fbd9
Compare
rmarinho
approved these changes
Feb 1, 2024
PureWeen
pushed a commit
that referenced
this pull request
Feb 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
We have a bug in iOS when using an Entry's Next ReturnType. If the next 'available' entry/editor is not visible, we skip it and go on to the next available entry/editor. However, if the parent of the next 'available' entry/editor is not visible and the 'available' entry/editor is not marked as not visible, we will still go into it.
In the search for the next entry/editor, we go through the current controls siblings, then go up a level to the parent's siblings and look into their children. Because of this, we can simply check if the parent is visible and go onto the next parent if so.
HiddenEntry-Before.mov
HiddenEntry-After.mov
Code Snippet from original issue (click me!)
Issues Fixed
Fixes #19139