Applying visibility change to child controls by kubaflo · Pull Request #20154 · dotnet/maui

kubaflo · 2024-01-25T12:40:37Z

Description of Change

Applying visibility change to child controls

Issues Fixed

Fixes #19139
Fixes #23573
Fixes #28012

Screen.Recording.2024-01-25.at.13.28.42.mov

ghost · 2024-01-25T12:40:43Z

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

jsuarezruiz

@tj-devel709 Could we include a device or ui tests here?

rmarinho

This will need more description about the change and maybe some discussion first. I m not sure we want to add this to our public API.

Also this would need device and unit tests for the new api

kubaflo · 2024-01-28T23:09:55Z

@rmarinho there was a short discussion in this issue #19139
Hmmm if the changes of IsEnabled or Input transparent propagate to child controls then that should be the case with isVisible Of course it is my opinion and I'm happy to find out why it might not be a good idea.

I will write tests once there is a decision on whether this change makes sense or not.

tj-devel709 · 2024-01-29T14:26:33Z

I added this PR here to address specifically with the next entry capability. I don't think we will need this PR (in regards to the next entry issue), but it could possibly be helpful for a different scenario!

mattleibow · 2024-02-05T16:39:17Z

This PR seems sensible, but both WPF and UWP chose not to propagate this value. So I am asking some teams why they decided this: dotnet/wpf#8774

mattleibow

Looking good, we just need a bunch more tests for a good few combinations so we can ensure we don't break somerthing later on and all things stay working as expected.

src/Controls/tests/Core.UnitTests/GridTests.cs

mattleibow · 2024-02-05T18:45:55Z

Can you rebase?

mattleibow · 2024-02-06T15:46:48Z

/azp run

azure-pipelines · 2024-02-06T15:47:09Z

Azure Pipelines successfully started running 3 pipeline(s).

mattleibow · 2024-02-06T15:47:36Z

Now the question is... Is this a breaking change for a SR that means it should wait for net9.0? Or is it OK and people need to be aware of the change?

src/Controls/src/Core/VisualElement/VisualElement.cs

jsuarezruiz · 2024-06-11T09:59:09Z

@kubaflo Could you rebase and fix the conflicts?. Thanks.
Let me know if can help with something.

kubaflo · 2024-06-13T00:02:43Z

@jsuarezruiz done :)

mattleibow · 2025-02-12T10:35:00Z

/azp run

azure-pipelines · 2025-02-20T09:18:17Z

Azure Pipelines successfully started running 3 pipeline(s).

jfversluis · 2025-02-20T10:13:09Z

Issue1549.ResourcesInNonXFBaseClassesAreFound() unit test fails is that one relevant?

kubaflo · 2025-02-20T13:05:17Z

@jfversluis Because of how propagation works I had to modify the test

azure-pipelines · 2025-02-20T13:06:48Z

Azure Pipelines successfully started running 3 pipeline(s).

Feedback addressed

maonaoda · 2025-02-28T03:30:58Z

@kubaflo
Something seems wrong

Unhandled Exception:
System.InvalidOperationException: Collection was modified; enumeration operation may not execute.
at System.Collections.Generic.List1.Enumerator[[Microsoft.Maui.Controls.Element, Microsoft.Maui.Controls, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null]].MoveNextRare()
at System.Collections.Generic.List1.Enumerator[[Microsoft.Maui.Controls.Element, Microsoft.Maui.Controls, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null]].MoveNext()
at Microsoft.Maui.Controls.Internals.PropertyPropagationExtensions.PropagatePropertyChanged(String propertyName, Element element, IEnumerable children) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/Internals/PropertyPropagationExtensions.cs:line 29
at Microsoft.Maui.Controls.VisualElement.Microsoft.Maui.Controls.IPropertyPropagationController.PropagatePropertyChanged(String propertyName) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/VisualElement/VisualElement.cs:line 1781
at Microsoft.Maui.Controls.VisualElement.OnIsVisibleChanged(Boolean oldValue, Boolean newValue) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/VisualElement/VisualElement.cs:line 1535
at Microsoft.Maui.Controls.VisualElement.<>c.<.cctor>b__435_6(BindableObject bindable, Object oldvalue, Object newvalue) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/VisualElement/VisualElement.cs:line 276
at Microsoft.Maui.Controls.BindableObject.OnBindablePropertySet(BindableProperty property, Object original, Object value, Boolean didChange, Boolean willFirePropertyChanged) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/BindableObject.cs:line 676
at Microsoft.Maui.Controls.Element.OnBindablePropertySet(BindableProperty property, Object original, Object value, Boolean changed, Boolean willFirePropertyChanged) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/Element/Element.cs:line 642
at Microsoft.Maui.Controls.BindableObject.SetValueActual(BindableProperty property, BindablePropertyContext context, Object value, Boolean currentlyApplying, SetValueFlags attributes, SetterSpecificity specificity, Boolean silent) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/BindableObject.cs:line 663
at Microsoft.Maui.Controls.BindableObject.SetValueCore(BindableProperty property, Object value, SetValueFlags attributes, SetValuePrivateFlags privateAttributes, SetterSpecificity specificity) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/BindableObject.cs:line 591
at Microsoft.Maui.Controls.Internals.TypedBinding2[[XXX.ViewModels.ConsultationHistoryPageViewModel, XXX, Version=3.3.0.0, Culture=neutral, PublicKeyToken=null],[System.Boolean, System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].ApplyCore(Object sourceObject, BindableObject target, BindableProperty property, Boolean fromTarget, SetterSpecificity specificity) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/TypedBinding.cs:line 325
at Microsoft.Maui.Controls.Internals.TypedBinding2[[XXX.ViewModels.ConsultationHistoryPageViewModel, XXX, Version=3.3.0.0, Culture=neutral, PublicKeyToken=null],[System.Boolean, System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].Apply(Boolean fromTarget) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/TypedBinding.cs:line 167
at Microsoft.Maui.Controls.Internals.TypedBinding2.PropertyChangedProxy[[XXX.ViewModels.ConsultationHistoryPageViewModel, XXX, Version=3.3.0.0, Culture=neutral, PublicKeyToken=null],[System.Boolean, System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].<OnPropertyChanged>b__16_0() in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/TypedBinding.cs:line 506
at Microsoft.Maui.Dispatching.Dispatcher.<>c__DisplayClass9_0.<DispatchImplementation>b__0() in /Users/wangyk/Projects/Practice/my_maui/src/Core/src/Dispatching/Dispatcher.iOS.cs:line 21
at CoreFoundation.DispatchQueue.static_dispatcher_to_managed(IntPtr context) in /Users/builder/azdo/_work/1/s/xamarin-macios/src/CoreFoundation/Dispatch.cs:line 379
at UIKit.UIApplication.UIApplicationMain(Int32 argc, String[] argv, IntPtr principalClassName, IntPtr delegateClassName) in /Users/builder/azdo/_work/1/s/xamarin-macios/src/UIKit/UIApplication.cs:line 61
at UIKit.UIApplication.Main(String[] args, Type principalClass, Type delegateClass) in /Users/builder/azdo/_work/1/s/xamarin-macios/src/UIKit/UIApplication.cs:line 96
at XXX.Program.Main(String[] args) in /Users/wangyk/Projects/app-maui/XXX/Platforms/iOS/Program.cs:line 15
2025-02-28 11:19:18.763430+0800 XXX[53310:3897398] Received unhandled Objective-C exception that was marshalled from a managed exception: Collection was modified; enumeration operation may not execute. (System.InvalidOperationException)
at System.Collections.Generic.List1.Enumerator[[Microsoft.Maui.Controls.Element, Microsoft.Maui.Controls, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null]].MoveNextRare()
at System.Collections.Generic.List1.Enumerator[[Microsoft.Maui.Controls.Element, Microsoft.Maui.Controls, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null]].MoveNext()
at Microsoft.Maui.Controls.Internals.PropertyPropagationExtensions.PropagatePropertyChanged(String propertyName, Element element, IEnumerable children) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/Internals/PropertyPropagationExtensions.cs:line 29
at Microsoft.Maui.Controls.VisualElement.Microsoft.Maui.Controls.IPropertyPropagationController.PropagatePropertyChanged(String propertyName) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/VisualElement/VisualElement.cs:line 1781
at Microsoft.Maui.Controls.VisualElement.OnIsVisibleChanged(Boolean oldValue, Boolean newValue) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/VisualElement/VisualElement.cs:line 1535
at Microsoft.Maui.Controls.VisualElement.<>c.<.cctor>b__435_6(BindableObject bindable, Object oldvalue, Object newvalue) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/VisualElement/VisualElement.cs:line 276
at Microsoft.Maui.Controls.BindableObject.OnBindablePropertySet(BindableProperty property, Object original, Object value, Boolean didChange, Boolean willFirePropertyChanged) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/BindableObject.cs:line 676
at Microsoft.Maui.Controls.Element.OnBindablePropertySet(BindableProperty property, Object original, Object value, Boolean changed, Boolean willFirePropertyChanged) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/Element/Element.cs:line 642
at Microsoft.Maui.Controls.BindableObject.SetValueActual(BindableProperty property, BindablePropertyContext context, Object value, Boolean currentlyApplying, SetValueFlags attributes, SetterSpecificity specificity, Boolean silent) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/BindableObject.cs:line 663
at Microsoft.Maui.Controls.BindableObject.SetValueCore(BindableProperty property, Object value, SetValueFlags attributes, SetValuePrivateFlags privateAttributes, SetterSpecificity specificity) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/BindableObject.cs:line 591
at Microsoft.Maui.Controls.Internals.TypedBinding2[[XXX.ViewModels.ConsultationHistoryPageViewModel, XXX, Version=3.3.0.0, Culture=neutral, PublicKeyToken=null],[System.Boolean, System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].ApplyCore(Object sourceObject, BindableObject target, BindableProperty property, Boolean fromTarget, SetterSpecificity specificity) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/TypedBinding.cs:line 325
at Microsoft.Maui.Controls.Internals.TypedBinding2[[XXX.ViewModels.ConsultationHistoryPageViewModel, XXX, Version=3.3.0.0, Culture=neutral, PublicKeyToken=null],[System.Boolean, System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].Apply(Boolean fromTarget) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/TypedBinding.cs:line 167
at Microsoft.Maui.Controls.Internals.TypedBinding2.PropertyChangedProxy[[XXX.ViewModels.ConsultationHistoryPageViewModel, XXX, Version=3.3.0.0, Culture=neutral, PublicKeyToken=null],[System.Boolean, System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].<OnPropertyChanged>b__16_0() in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/TypedBinding.cs:line 506
at Microsoft.Maui.Dispatching.Dispatcher.<>c__DisplayClass9_0.<DispatchImplementation>b__0() in /Users/wangyk/Projects/Practice/my_maui/src/Core/src/Dispatching/Dispatcher.iOS.cs:line 21
at CoreFoundation.DispatchQueue.static_dispatcher_to_managed(IntPtr context) in /Users/builder/azdo/_work/1/s/xamarin-macios/src/CoreFoundation/Dispatch.cs:line 379
at UIKit.UIApplication.UIApplicationMain(Int32 argc, String[] argv, IntPtr principalClassName, IntPtr delegateClassName) in /Users/builder/azdo/_work/1/s/xamarin-macios/src/UIKit/UIApplication.cs:line 61
at UIKit.UIApplication.Main(String[] args, Type principalClass, Type delegateClass) in /Users/builder/azdo/_work/1/s/xamarin-macios/src/UIKit/UIApplication.cs:line 96
at XXX.Program.Main(String[] args) in /Users/wangyk/Projects/app-maui/XXX/Platforms/iOS/Program.cs:line 15

maonaoda · 2025-02-28T06:38:57Z

I think, added
(this as IPropertyPropagationController)?.PropagatePropertyChanged(IsVisibleProperty.PropertyName);
may affect the control that changes the child element through ItemsSource

kubaflo · 2025-03-02T00:20:22Z

@kubaflo Something seems wrong

Unhandled Exception:
System.InvalidOperationException: Collection was modified; enumeration operation may not execute.
at System.Collections.Generic.List1.Enumerator[[Microsoft.Maui.Controls.Element, Microsoft.Maui.Controls, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null]].MoveNextRare()
at System.Collections.Generic.List1.Enumerator[[Microsoft.Maui.Controls.Element, Microsoft.Maui.Controls, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null]].MoveNext()
at Microsoft.Maui.Controls.Internals.PropertyPropagationExtensions.PropagatePropertyChanged(String propertyName, Element element, IEnumerable children) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/Internals/PropertyPropagationExtensions.cs:line 29
at Microsoft.Maui.Controls.VisualElement.Microsoft.Maui.Controls.IPropertyPropagationController.PropagatePropertyChanged(String propertyName) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/VisualElement/VisualElement.cs:line 1781
at Microsoft.Maui.Controls.VisualElement.OnIsVisibleChanged(Boolean oldValue, Boolean newValue) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/VisualElement/VisualElement.cs:line 1535
at Microsoft.Maui.Controls.VisualElement.<>c.<.cctor>b__435_6(BindableObject bindable, Object oldvalue, Object newvalue) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/VisualElement/VisualElement.cs:line 276
at Microsoft.Maui.Controls.BindableObject.OnBindablePropertySet(BindableProperty property, Object original, Object value, Boolean didChange, Boolean willFirePropertyChanged) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/BindableObject.cs:line 676
at Microsoft.Maui.Controls.Element.OnBindablePropertySet(BindableProperty property, Object original, Object value, Boolean changed, Boolean willFirePropertyChanged) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/Element/Element.cs:line 642
at Microsoft.Maui.Controls.BindableObject.SetValueActual(BindableProperty property, BindablePropertyContext context, Object value, Boolean currentlyApplying, SetValueFlags attributes, SetterSpecificity specificity, Boolean silent) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/BindableObject.cs:line 663
at Microsoft.Maui.Controls.BindableObject.SetValueCore(BindableProperty property, Object value, SetValueFlags attributes, SetValuePrivateFlags privateAttributes, SetterSpecificity specificity) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/BindableObject.cs:line 591
at Microsoft.Maui.Controls.Internals.TypedBinding2[[XXX.ViewModels.ConsultationHistoryPageViewModel, XXX, Version=3.3.0.0, Culture=neutral, PublicKeyToken=null],[System.Boolean, System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].ApplyCore(Object sourceObject, BindableObject target, BindableProperty property, Boolean fromTarget, SetterSpecificity specificity) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/TypedBinding.cs:line 325
at Microsoft.Maui.Controls.Internals.TypedBinding2[[XXX.ViewModels.ConsultationHistoryPageViewModel, XXX, Version=3.3.0.0, Culture=neutral, PublicKeyToken=null],[System.Boolean, System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].Apply(Boolean fromTarget) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/TypedBinding.cs:line 167
at Microsoft.Maui.Controls.Internals.TypedBinding2.PropertyChangedProxy[[XXX.ViewModels.ConsultationHistoryPageViewModel, XXX, Version=3.3.0.0, Culture=neutral, PublicKeyToken=null],[System.Boolean, System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].<OnPropertyChanged>b__16_0() in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/TypedBinding.cs:line 506
at Microsoft.Maui.Dispatching.Dispatcher.<>c__DisplayClass9_0.<DispatchImplementation>b__0() in /Users/wangyk/Projects/Practice/my_maui/src/Core/src/Dispatching/Dispatcher.iOS.cs:line 21
at CoreFoundation.DispatchQueue.static_dispatcher_to_managed(IntPtr context) in /Users/builder/azdo/_work/1/s/xamarin-macios/src/CoreFoundation/Dispatch.cs:line 379
at UIKit.UIApplication.UIApplicationMain(Int32 argc, String[] argv, IntPtr principalClassName, IntPtr delegateClassName) in /Users/builder/azdo/_work/1/s/xamarin-macios/src/UIKit/UIApplication.cs:line 61
at UIKit.UIApplication.Main(String[] args, Type principalClass, Type delegateClass) in /Users/builder/azdo/_work/1/s/xamarin-macios/src/UIKit/UIApplication.cs:line 96
at XXX.Program.Main(String[] args) in /Users/wangyk/Projects/app-maui/XXX/Platforms/iOS/Program.cs:line 15
2025-02-28 11:19:18.763430+0800 XXX[53310:3897398] Received unhandled Objective-C exception that was marshalled from a managed exception: Collection was modified; enumeration operation may not execute. (System.InvalidOperationException)
at System.Collections.Generic.List1.Enumerator[[Microsoft.Maui.Controls.Element, Microsoft.Maui.Controls, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null]].MoveNextRare()
at System.Collections.Generic.List1.Enumerator[[Microsoft.Maui.Controls.Element, Microsoft.Maui.Controls, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null]].MoveNext()
at Microsoft.Maui.Controls.Internals.PropertyPropagationExtensions.PropagatePropertyChanged(String propertyName, Element element, IEnumerable children) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/Internals/PropertyPropagationExtensions.cs:line 29
at Microsoft.Maui.Controls.VisualElement.Microsoft.Maui.Controls.IPropertyPropagationController.PropagatePropertyChanged(String propertyName) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/VisualElement/VisualElement.cs:line 1781
at Microsoft.Maui.Controls.VisualElement.OnIsVisibleChanged(Boolean oldValue, Boolean newValue) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/VisualElement/VisualElement.cs:line 1535
at Microsoft.Maui.Controls.VisualElement.<>c.<.cctor>b__435_6(BindableObject bindable, Object oldvalue, Object newvalue) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/VisualElement/VisualElement.cs:line 276
at Microsoft.Maui.Controls.BindableObject.OnBindablePropertySet(BindableProperty property, Object original, Object value, Boolean didChange, Boolean willFirePropertyChanged) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/BindableObject.cs:line 676
at Microsoft.Maui.Controls.Element.OnBindablePropertySet(BindableProperty property, Object original, Object value, Boolean changed, Boolean willFirePropertyChanged) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/Element/Element.cs:line 642
at Microsoft.Maui.Controls.BindableObject.SetValueActual(BindableProperty property, BindablePropertyContext context, Object value, Boolean currentlyApplying, SetValueFlags attributes, SetterSpecificity specificity, Boolean silent) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/BindableObject.cs:line 663
at Microsoft.Maui.Controls.BindableObject.SetValueCore(BindableProperty property, Object value, SetValueFlags attributes, SetValuePrivateFlags privateAttributes, SetterSpecificity specificity) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/BindableObject.cs:line 591
at Microsoft.Maui.Controls.Internals.TypedBinding2[[XXX.ViewModels.ConsultationHistoryPageViewModel, XXX, Version=3.3.0.0, Culture=neutral, PublicKeyToken=null],[System.Boolean, System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].ApplyCore(Object sourceObject, BindableObject target, BindableProperty property, Boolean fromTarget, SetterSpecificity specificity) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/TypedBinding.cs:line 325
at Microsoft.Maui.Controls.Internals.TypedBinding2[[XXX.ViewModels.ConsultationHistoryPageViewModel, XXX, Version=3.3.0.0, Culture=neutral, PublicKeyToken=null],[System.Boolean, System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].Apply(Boolean fromTarget) in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/TypedBinding.cs:line 167
at Microsoft.Maui.Controls.Internals.TypedBinding2.PropertyChangedProxy[[XXX.ViewModels.ConsultationHistoryPageViewModel, XXX, Version=3.3.0.0, Culture=neutral, PublicKeyToken=null],[System.Boolean, System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].<OnPropertyChanged>b__16_0() in /Users/wangyk/Projects/Practice/my_maui/src/Controls/src/Core/TypedBinding.cs:line 506
at Microsoft.Maui.Dispatching.Dispatcher.<>c__DisplayClass9_0.<DispatchImplementation>b__0() in /Users/wangyk/Projects/Practice/my_maui/src/Core/src/Dispatching/Dispatcher.iOS.cs:line 21
at CoreFoundation.DispatchQueue.static_dispatcher_to_managed(IntPtr context) in /Users/builder/azdo/_work/1/s/xamarin-macios/src/CoreFoundation/Dispatch.cs:line 379
at UIKit.UIApplication.UIApplicationMain(Int32 argc, String[] argv, IntPtr principalClassName, IntPtr delegateClassName) in /Users/builder/azdo/_work/1/s/xamarin-macios/src/UIKit/UIApplication.cs:line 61
at UIKit.UIApplication.Main(String[] args, Type principalClass, Type delegateClass) in /Users/builder/azdo/_work/1/s/xamarin-macios/src/UIKit/UIApplication.cs:line 96
at XXX.Program.Main(String[] args) in /Users/wangyk/Projects/app-maui/XXX/Platforms/iOS/Program.cs:line 15

Can you provide a sample so that I can try to reproduce it? Thanks!

maonaoda · 2025-03-04T14:43:34Z

@kubaflo
Please see #28162
and you can also see that the bug size of CollectionView`s Header has not been solved.

bmacombe · 2025-03-24T18:37:27Z

Now the question is... Is this a breaking change for a SR that means it should wait for net9.0? Or is it OK and people need to be aware of the change?

@mattleibow @kubaflo I think this is causing me issues in 9.0.50, we have some layout logic that depends on knowing the actually Set value of IsVisible, like the original behavior. I don't see how I can get the _isVisibleExplicit value even after the .net 10 changes

kubaflo requested a review from a team as a code owner January 25, 2024 12:40

kubaflo requested review from jsuarezruiz and tj-devel709 January 25, 2024 12:40

ghost added the community ✨ Community Contribution label Jan 25, 2024

kubaflo mentioned this pull request Jan 25, 2024

IsVisible false is not propagated to child controls #19139

Open

samhouts added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jan 25, 2024

jsuarezruiz reviewed Jan 26, 2024

View reviewed changes

rmarinho previously requested changes Jan 28, 2024

View reviewed changes

mattleibow reviewed Feb 5, 2024

View reviewed changes

src/Controls/tests/Core.UnitTests/GridTests.cs Outdated Show resolved Hide resolved

kubaflo force-pushed the applying-visibility-change-to-child-controls branch from 90d5d80 to 1b85ac4 Compare February 5, 2024 19:12

kubaflo added a commit to kubaflo/maui that referenced this pull request Feb 6, 2024

Added more unit tests (dotnet#20154)

b4370b4

mattleibow reviewed Feb 9, 2024

View reviewed changes

src/Controls/src/Core/VisualElement/VisualElement.cs Outdated Show resolved Hide resolved

kubaflo added a commit to kubaflo/maui that referenced this pull request Feb 10, 2024

Added more unit tests (dotnet#20154)

c091f2b

kubaflo force-pushed the applying-visibility-change-to-child-controls branch from b4370b4 to 549cd74 Compare February 10, 2024 00:33

Eilon added area-controls-general General issues that span multiple controls, or common base classes such as View or Element and removed legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor labels May 13, 2024

kubaflo added a commit to kubaflo/maui that referenced this pull request Jun 13, 2024

Added more unit tests (dotnet#20154)

08aeb53

kubaflo force-pushed the applying-visibility-change-to-child-controls branch from 549cd74 to 5de6439 Compare June 13, 2024 00:02

kubaflo changed the base branch from main to net9.0 September 1, 2024 00:19

kubaflo added a commit to kubaflo/maui that referenced this pull request Sep 1, 2024

Added more unit tests (dotnet#20154)

50c71e0

This comment was marked as off-topic.

Sign in to view

github-actions bot force-pushed the applying-visibility-change-to-child-controls branch from 98aeecd to 60d1f1f Compare February 20, 2025 09:14

jfversluis added this to the .NET 9 SR5 milestone Feb 20, 2025

Applying visibility change to child controls

51728af

kubaflo force-pushed the applying-visibility-change-to-child-controls branch from 60d1f1f to 51728af Compare February 20, 2025 12:41

jfversluis approved these changes Feb 21, 2025

View reviewed changes

kubaflo mentioned this pull request Feb 24, 2025

The header in a collectionview does not resize if you hide the content #28012

Closed

jfversluis merged commit d988ddf into dotnet:main Feb 25, 2025
123 checks passed

tj-devel709 pushed a commit that referenced this pull request Mar 3, 2025

Applying visibility change to child controls (#20154)

08be351

maonaoda mentioned this pull request Mar 4, 2025

[CollectionView]Crash occurs when switching CollectionView.IsVisible right after setting ItemsSource #28162

Closed

drasticactions mentioned this pull request Mar 10, 2025

CollectionView inside invisible StackLayout doesn't show on iOS #28263

Closed

This was referenced Mar 15, 2025

CollectionView display is broken when setting IsVisible after items are added - Fix #28425

Closed

[9.0.50] CollectionView display is broken when setting IsVisible after items are added #28415

Closed

Anandh-SF4665 mentioned this pull request Mar 26, 2025

Fixed SfPopup does not show up after repeated opening issue. syncfusion/maui-toolkit#141

Merged

sheiksyedm mentioned this pull request Mar 28, 2025

Visibility Property Not Updating as Expected in .NET MAUI #28677

Closed

jfversluis mentioned this pull request Apr 2, 2025

Revert Applying visibility change to child controls #28768

Merged

Bamich mentioned this pull request Apr 12, 2025

On iOS GestureRecognizers don't work on Span in a Label, which doesn't get IsVisible (=true) update from its parent #28949

Closed

github-actions bot locked and limited conversation to collaborators Apr 24, 2025

Conversation

kubaflo commented Jan 25, 2024 • edited by jfversluis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

Issues Fixed

Uh oh!

ghost commented Jan 25, 2024

Uh oh!

jsuarezruiz left a comment

Choose a reason for hiding this comment

Uh oh!

rmarinho left a comment

Choose a reason for hiding this comment

Uh oh!

kubaflo commented Jan 28, 2024

Uh oh!

tj-devel709 commented Jan 29, 2024

Uh oh!

mattleibow commented Feb 5, 2024

Uh oh!

mattleibow left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mattleibow commented Feb 5, 2024

Uh oh!

mattleibow commented Feb 6, 2024

Uh oh!

azure-pipelines bot commented Feb 6, 2024

Uh oh!

mattleibow commented Feb 6, 2024

Uh oh!

Uh oh!

jsuarezruiz commented Jun 11, 2024

Uh oh!

kubaflo commented Jun 13, 2024

Uh oh!

mattleibow commented Feb 12, 2025 • edited by jfversluis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as off-topic.

This comment was marked as off-topic.

azure-pipelines bot commented Feb 20, 2025

Uh oh!

jfversluis commented Feb 20, 2025

Uh oh!

kubaflo commented Feb 20, 2025

Uh oh!

azure-pipelines bot commented Feb 20, 2025

Uh oh!

Uh oh!

maonaoda commented Feb 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maonaoda commented Feb 28, 2025

Uh oh!

kubaflo commented Mar 2, 2025

Uh oh!

maonaoda commented Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bmacombe commented Mar 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

kubaflo commented Jan 25, 2024 •

edited by jfversluis

Loading

mattleibow commented Feb 12, 2025 •

edited by jfversluis

Loading

maonaoda commented Feb 28, 2025 •

edited

Loading

maonaoda commented Mar 4, 2025 •

edited

Loading