[iOS] Fix ShellContent Title Does Not Update at Runtime#26062
Merged
jfversluis merged 14 commits intodotnet:mainfrom Feb 13, 2025
Merged
[iOS] Fix ShellContent Title Does Not Update at Runtime#26062jfversluis merged 14 commits intodotnet:mainfrom
jfversluis merged 14 commits intodotnet:mainfrom
Conversation
Contributor
|
Hey there @devanathan-vaithiyanathan! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
jsuarezruiz
added
platform/ios
area-controls-shell
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This reverts commit ae6a031.
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
sheiksyedm
added
the
partner/syncfusion
PureWeen
requested changes
Jan 6, 2025
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellSectionRootHeader.cs
Show resolved
Hide resolved
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
@devanathan-vaithiyanathan Could you fix the conflict? Thanks in advance. |
Contributor
Author
@jsuarezruiz I have resolved the conflicts |
Member
|
/rebase |
PureWeen
previously requested changes
Jan 29, 2025
Member
PureWeen
left a comment
PureWeen
left a comment
There was a problem hiding this comment.
Can you add a couple scenarios here
- Add a shellcontent dynamically
- you're able to update the title of that new tab
- remove that shellcontent
- you're able to update the title of an exising tab
Contributor
Author
As per suggestion, I have modified the test. Please let me know if you have any concerns |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
/rebase |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
4 tasks
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
previously requested changes
Feb 12, 2025
|
Azure Pipelines successfully started running 3 pipeline(s). |
jfversluis
dismissed stale reviews from jsuarezruiz and PureWeen
Feedback addressed
Member
|
Failing test unrelated |
jfversluis
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The issue occurred because the ShellContent title did not update dynamically in response to property changes. On iOS, real-time updates were not reflected as the Title property changes were not being observed.
Description of Change
Implemented dynamic title updates for ShellContent by subscribing to the PropertyChanged event. This ensures that any changes to the Title property are observed and updated in real-time, resolving the issue where the title did not reflect updates dynamically.
Issues Fixed
Fixes #26049
Tested the behaviour in the following platforms
Output Screenshot
BeforeFix.mov
AfterFix.mov