[Windows/Android] Fix Dynamic ShellContent Title Updates at Runtime#27609
Open
devanathan-vaithiyanathan wants to merge 13 commits intodotnet:mainfrom
Open
[Windows/Android] Fix Dynamic ShellContent Title Updates at Runtime#27609devanathan-vaithiyanathan wants to merge 13 commits intodotnet:mainfrom
devanathan-vaithiyanathan wants to merge 13 commits intodotnet:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
Runtime scenarios for ShellContent were not properly handled. When ShellContent was added or removed dynamically, its property changes (such as title updates) were not tracked correctly.
Description of Change
Android: Added handling for ShellContent runtime changes in ShellSectionRenderer by subscribing and unsubscribing to ShellContent.PropertyChanged events. This ensures that property updates, such as title changes, are correctly applied when ShellContent is added or removed dynamically.
Windows: Moved title update handling from ShellContentHandler.Windows to ShellSectionHandler.Windows. This modification ensures that title changes are handled properly for both initial and dynamically added ShellContent items.
Issues Fixed
Fixes #27494
Regarding test case
Added a test case for runtime-added ShellContent title updates in PR #26062 . These tests are applicable to my changes as well
Tested the behavior in the following platforms.
Output Screenshot
Before-fix.mov
After-fix.mov
Before-fix.mp4
After-fix.mp4