[Android] Fixed incorrect tab content display in TabbedPage by Vignesh-SF3580 · Pull Request #27294 · dotnet/maui

Vignesh-SF3580 · 2025-01-23T08:25:37Z

Issue Detail

When opening the app and clicking directly on the fourth tab, the fifth tab's content is displayed instead of the correct content.

Root Cause:

The OffscreenPageLimit mapping was missing in the source, leading to incorrect preloading of tab contents.

Description of Change

Mapped the OffscreenPageLimit property to ensure proper preloading of tab contents, resolving the issue.

Tested the behavior in the following platforms

Android
Windows
iOS
Mac

Issues Fixed

Fixes #23732
Fixes #21640
Fixes #28933

Screenshots

Before Issue Fix	After Issue Fix
TabBarBefore.mov	TabBarAfter.mov

jsuarezruiz · 2025-01-23T09:57:21Z

/azp run

azure-pipelines · 2025-01-23T09:57:44Z

Azure Pipelines successfully started running 3 pipeline(s).

Copilot

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (1)

src/Controls/tests/TestCases.HostApp/Issues/23732Page.xaml: Language not supported

Comments suppressed due to low confidence (1)

src/Controls/tests/TestCases.HostApp/Issues/23732Page.xaml.cs:5

[nitpick] The class name '_23732Page' is unconventional. It should be renamed to 'Page23732'.

public partial class _23732Page : ContentPage

jsuarezruiz · 2025-01-24T08:04:39Z

/azp run

azure-pipelines · 2025-01-24T08:05:00Z

Azure Pipelines successfully started running 3 pipeline(s).

jfversluis

I think the failing test is actually valid in this case, please look into that @Vignesh-SF3580

Vignesh-SF3580 · 2025-01-28T12:07:59Z

I think the failing test is actually valid in this case, please look into that @Vignesh-SF3580

@jfversluis I have validated the test case failure and corrected it by removing the DisconnectHandler call, as the latest code automatically calls previous page's DisconnectHandler during navigation.

jsuarezruiz · 2025-01-29T12:00:47Z

/azp run

azure-pipelines · 2025-01-29T12:01:24Z

Azure Pipelines successfully started running 3 pipeline(s).

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue23732.cs

jsuarezruiz · 2025-02-04T08:50:47Z

/azp run

azure-pipelines · 2025-02-04T08:51:09Z

Azure Pipelines successfully started running 3 pipeline(s).

mattleibow

In the attached videos, I see the below had no animations but the after does have.

Is this a result of your fix or was the capture not correct?

mattleibow · 2025-02-04T08:59:32Z

src/Controls/tests/DeviceTests/Elements/TabbedPage/TabbedPageTests.cs

 					var nextPage = tabbedPage.Children[pageIndex];
 					tabbedPage.CurrentPage = nextPage;
 					await OnNavigatedToAsync(nextPage);
-					previousPage.Handler.DisconnectHandler();


Why was this removed, is something leaking?

@mattleibow As mentioned earlier, this test fails with a timeout exception when using DisconnectHandler with the fix. Since the latest code automatically calls the previous page's DisconnectHandler during navigation, I have removed this code.

Vignesh-SF3580 · 2025-02-05T07:43:33Z

In the attached videos, I see the below had no animations but the after does have.

Is this a result of your fix or was the capture not correct?

@mattleibow The issue occurs when navigating directly from the first to the fourth tab, where the content does not update properly, and animations are missing.

However, animations work when switching between other tabs. My fix ensures the tab content updates correctly, and animations now work as expected when switching from the first to the fourth tab also.

jsuarezruiz · 2025-02-11T12:27:16Z

/azp run

azure-pipelines · 2025-02-11T12:27:35Z

Azure Pipelines successfully started running 3 pipeline(s).

jfversluis

Still tests consistently failing here

Vignesh-SF3580 · 2025-02-17T13:42:11Z

Still tests consistently failing here

@jfversluis I have checked the test case failures in this PR, and the only failing test is "GridCellsHonorMaxWidth", that failure is not related to the fix I have added. All other tests have passed without any issues. Most probably re triggering the CI will clear the test case failures. Could you please check and let me know if you have any concerns?

jsuarezruiz · 2025-02-25T10:11:02Z

Still tests consistently failing here

@jfversluis I have checked the test case failures in this PR, and the only failing test is "GridCellsHonorMaxWidth", that failure is not related to the fix I have added. All other tests have passed without any issues. Most probably re triggering the CI will clear the test case failures. Could you please check and let me know if you have any concerns?

Rebased to avoid the GridCellsHonorMaxWidth failure.

jsuarezruiz · 2025-02-25T10:11:13Z

/rebase

azure-pipelines · 2025-02-28T13:49:42Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-03-18T08:57:40Z

/rebase

jsuarezruiz · 2025-03-26T07:54:46Z

/rebase

remi-appsolu · 2025-03-26T11:23:50Z

I have a workaround : #26014 (comment)

jsuarezruiz · 2025-05-12T14:20:16Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-05-12T14:20:28Z

Azure Pipelines successfully started running 1 pipeline(s).

jfversluis · 2025-08-19T09:40:35Z

/rebase

azure-pipelines · 2025-08-19T09:42:26Z

Azure Pipelines successfully started running 1 pipeline(s).

jfversluis · 2025-08-21T18:43:00Z

/azp run MAUI-public

azure-pipelines · 2025-08-21T18:43:22Z

Azure Pipelines successfully started running 1 pipeline(s).

issue fixed and testcases updated. updated Issue23732.cs updated testcases. updated the testcase by removing the DisconnectHandler. updated testcases. 21640 testcases added.

dotnet-policy-service bot added the community ✨ Community Contribution label Jan 23, 2025

karthikraja-arumugam added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Jan 23, 2025

jsuarezruiz added the platform/android label Jan 23, 2025

Vignesh-SF3580 marked this pull request as ready for review January 23, 2025 15:07

Copilot AI review requested due to automatic review settings January 23, 2025 15:07

Vignesh-SF3580 requested a review from a team as a code owner January 23, 2025 15:07

Vignesh-SF3580 requested review from StephaneDelcroix and mattleibow January 23, 2025 15:07

Copilot AI reviewed Jan 23, 2025

View reviewed changes

jsuarezruiz previously approved these changes Jan 24, 2025

View reviewed changes

jfversluis requested changes Jan 24, 2025

View reviewed changes

Vignesh-SF3580 dismissed jsuarezruiz’s stale review via 78c7162 January 28, 2025 11:54

jsuarezruiz suggested changes Jan 31, 2025

View reviewed changes

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue23732.cs Show resolved Hide resolved

mattleibow reviewed Feb 4, 2025

View reviewed changes

jfversluis requested changes Feb 14, 2025

View reviewed changes

github-actions bot force-pushed the fix-23732 branch from be39ba9 to c928f36 Compare March 18, 2025 08:58

jfversluis added the area-controls-tabbedpage TabbedPage label Mar 25, 2025

github-actions bot force-pushed the fix-23732 branch from c928f36 to 52c0de3 Compare March 26, 2025 07:55

Vignesh-SF3580 added 7 commits August 19, 2025 09:41

updated TabbedPageManager.cs

8440636

issue fixed and testcases updated.

4784b24

updated Issue23732.cs

6f94cab

updated testcases.

f9d9864

updated the testcase by removing the DisconnectHandler.

9754265

updated testcases.

5d5e153

21640 testcases added.

0f67bd4

github-actions bot force-pushed the fix-23732 branch from 52c0de3 to 0f67bd4 Compare August 19, 2025 09:41

dotnet deleted a comment from azure-pipelines bot Aug 21, 2025

jfversluis approved these changes Sep 2, 2025

View reviewed changes

jfversluis changed the base branch from main to inflight/current September 2, 2025 07:32

jfversluis merged commit bc7c5e7 into dotnet:inflight/current Sep 2, 2025
92 of 94 checks passed

jfversluis added this to the .NET 9 SR11 milestone Sep 2, 2025

PureWeen pushed a commit that referenced this pull request Sep 8, 2025

updated TabbedPageManager.cs (#27294)

b3bb014

issue fixed and testcases updated. updated Issue23732.cs updated testcases. updated the testcase by removing the DisconnectHandler. updated testcases. 21640 testcases added.

jfversluis modified the milestones: .NET 9 SR11, .NET 9 SR12 Sep 11, 2025

github-actions bot locked and limited conversation to collaborators Oct 11, 2025

Conversation

Vignesh-SF3580 commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue Detail

Root Cause:

Description of Change

Tested the behavior in the following platforms

Issues Fixed

Screenshots

Uh oh!

jsuarezruiz commented Jan 23, 2025

Uh oh!

azure-pipelines bot commented Jan 23, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented Jan 24, 2025

Uh oh!

azure-pipelines bot commented Jan 24, 2025

Uh oh!

jfversluis left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Vignesh-SF3580 commented Jan 28, 2025

Uh oh!

jsuarezruiz commented Jan 29, 2025

Uh oh!

azure-pipelines bot commented Jan 29, 2025

Uh oh!

Uh oh!

jsuarezruiz commented Feb 4, 2025

Uh oh!

azure-pipelines bot commented Feb 4, 2025

Uh oh!

mattleibow left a comment

Choose a reason for hiding this comment

Uh oh!

mattleibow Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

Vignesh-SF3580 Feb 5, 2025

Choose a reason for hiding this comment

Uh oh!

Vignesh-SF3580 commented Feb 5, 2025

Uh oh!

jsuarezruiz commented Feb 11, 2025

Uh oh!

azure-pipelines bot commented Feb 11, 2025

Uh oh!

jfversluis left a comment

Choose a reason for hiding this comment

Uh oh!

Vignesh-SF3580 commented Feb 17, 2025

Uh oh!

jsuarezruiz commented Feb 25, 2025

Uh oh!

jsuarezruiz commented Feb 25, 2025

Uh oh!

azure-pipelines bot commented Feb 28, 2025

Uh oh!

jsuarezruiz commented Mar 18, 2025

Uh oh!

jsuarezruiz commented Mar 26, 2025

Uh oh!

remi-appsolu commented Mar 26, 2025

Uh oh!

jsuarezruiz commented May 12, 2025 • edited by jfversluis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-pipelines bot commented May 12, 2025

Uh oh!

jfversluis commented Aug 19, 2025

Uh oh!

azure-pipelines bot commented Aug 19, 2025

Uh oh!

jfversluis commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Vignesh-SF3580 commented Jan 23, 2025 •

edited

Loading

jfversluis left a comment •

edited

Loading

jsuarezruiz commented May 12, 2025 •

edited by jfversluis

Loading

jfversluis commented Aug 21, 2025 •

edited

Loading