[Testing] Feature Matrix UITest Cases for CollectionView Grouping Feature#29002
Merged
PureWeen merged 10 commits intoinflight/candidatefrom Apr 24, 2025
unknown repository
Merged
[Testing] Feature Matrix UITest Cases for CollectionView Grouping Feature#29002PureWeen merged 10 commits intoinflight/candidatefrom unknown repository
PureWeen merged 10 commits intoinflight/candidatefrom
unknown repository
Conversation
Contributor
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive UI test cases and feature pages to validate the CollectionView grouping functionality while refactoring some legacy pages.
- Added new pages (CollectionViewFeaturePage, CollectionViewGroupingPage, etc.) and a corresponding view model (CollectionViewViewModel) with additional properties for grouping.
- Updated CorePageView to reference the new CollectionView feature page and removed obsolete pages.
Reviewed Changes
Copilot reviewed 12 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| HeaderFooterMainPage.xaml.cs | Removed outdated header/footer page. |
| HeaderFooterOptionsPage.xaml.cs | Updated to support dynamic header/footer options for CollectionView grouping. |
| CollectionViewHeaderPage.xaml.cs | Introduced to showcase header configurations. |
| CollectionViewViewModel.cs | Extended to support new properties (CanReorderItems, CanMixGroups) and a new ItemsSourceType value. |
| GroupingOptionsPage.xaml.cs | Added to manage options for grouped CollectionView. |
| CollectionViewGroupingPage.xaml.cs | Added to test grouping functionality. |
| CollectionViewFeaturePage.xaml.cs | Added as an entry point for the CollectionView feature matrix. |
| CollectionViewControlPage.xaml.cs | Removed in favor of the consolidated feature pages. |
| CorePageView.cs | Updated GalleryPageFactory to reference the new CollectionView feature page. |
Files not reviewed (6)
- src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/CollectionViewFeaturePage.xaml: Language not supported
- src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/CollectionViewGrouping/CollectionViewGroupingPage.xaml: Language not supported
- src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/CollectionViewGrouping/GroupingOptionsPage.xaml: Language not supported
- src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/HeaderFooter/CollectionViewHeaderPage.xaml: Language not supported
- src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/HeaderFooter/HeaderFooterOptionsPage.xaml: Language not supported
- src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/HeaderFooterMainPage.xaml: Language not supported
Comments suppressed due to low confidence (2)
src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/CollectionViewViewModel.cs:188
- Ensure that test cases are added for the new properties 'CanReorderItems' and 'CanMixGroups' in both TestCases.HostApp and TestCases.Shared.Tests.
public bool CanReorderItems
src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/CollectionViewViewModel.cs:218
- [nitpick] Consider clarifying the naming of the enum value 'ObservableCollectionT' so that it clearly differentiates from 'ObservableCollection25T' and 'ObservableCollection5T'.
ItemsSourceType.ObservableCollectionT => _observableCollection,
jsuarezruiz
previously approved these changes
Apr 23, 2025
PureWeen
approved these changes
Apr 24, 2025
PureWeen
pushed a commit
that referenced
this pull request
May 2, 2025
…ture (#29002) * Added GroupingFeature tests * updated changes * updated changes * Added test fails attribute * Corrected Mistakes * Updated Images * Corrected mistakes * Changes updated * Modified changes * Resolved Conflicts
SuthiYuvaraj
pushed a commit
to SuthiYuvaraj/maui
that referenced
this pull request
May 9, 2025
…ture (dotnet#29002) * Added GroupingFeature tests * updated changes * updated changes * Added test fails attribute * Corrected Mistakes * Updated Images * Corrected mistakes * Changes updated * Modified changes * Resolved Conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes a comprehensive set of UI test cases for the CollectionView control. The tests validate the Grouping feature functionality in CollectionView, including properties such as: IsGrouped, CanMixGroups, CanReorderItems, GroupHeaderTemplate, GroupFooterTemplate,Header, Footer, ItemsLayout, ItemTemplate, ItemsSource.
New Features :
CollectionViewFeaturePageandCollectionViewControlPageto showcase the CollectionView grouping feature. (src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/CollectionViewGrouping/CollectionViewFeaturePage.xaml[1]src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/CollectionViewGrouping/CollectionViewControlPage.xaml[2]CollectionViewViewModelto manage the data and behavior of the CollectionView, including support for grouped items, reordering, and custom templates. (src/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/CollectionViewGrouping/CollectionViewViewModel.cssrc/Controls/tests/TestCases.HostApp/FeatureMatrix/CollectionView/CollectionViewGrouping/CollectionViewViewModel.csR1-R292)Code Enhancements:
CorePageViewto include a newGalleryPageFactoryfor the CollectionView Feature Matrix. (src/Controls/tests/TestCases.HostApp/CoreViews/CorePageView.cssrc/Controls/tests/TestCases.HostApp/CoreViews/CorePageView.csR80)Issues Identified in Grouping Feature