[2025/04/28] Candidate - In Flight Branch#29158
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds multiple new UI test cases and updates platform-specific handler implementations for shell navigation, gesture management, toolbar appearance, and Maps initialization. Key changes include:
- New test pages to reproduce and verify issues (e.g., CollectionView selection, Drag & Drop, RefreshView color, DatePicker formatting).
- Updates in Windows handlers for Shell and gesture recognizers, along with minor refactorings and API updates.
- Adjustments in Maps initialization and CI pipeline variables for the inflight branch process.
Reviewed Changes
Copilot reviewed 183 out of 185 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Controls/tests/TestCases.HostApp/Issues/Issue22320.cs | New test case for CollectionView grouped selection |
| src/Controls/tests/TestCases.HostApp/Issues/Issue20177.cs | New test case for Shell ToolbarItems TextColor |
| src/Controls/tests/TestCases.HostApp/Issues/Issue17228.xaml.cs | New Shell page for back button image color test |
| src/Controls/tests/TestCases.HostApp/Issues/Issue17105.cs | New test case to verify password hint behavior on macOS |
| src/Controls/tests/TestCases.HostApp/Issues/Issue16973.cs | New test case for RefreshView color verification |
| src/Controls/tests/TestCases.HostApp/Issues/Issue12726.cs | New test for Drag & Drop response after runtime property changes |
| src/Controls/tests/TestCases.HostApp/Issues/Issue12500.cs | New Shell navigation test case with updated ViewModel binding |
| src/Controls/tests/TestCases.HostApp/Issues/Issue10805.cs | New DatePicker test case on UWP |
| src/Controls/src/Core/Toolbar/Toolbar.Windows.cs | Adjustment in text color update order for primary toolbar items |
| src/Controls/src/Core/Platform/GestureManager/GesturePlatformManager.Windows.cs | Improved subscription handling for drag & drop gestures |
| src/Controls/src/Core/Handlers/Shell/ShellItemHandler.Windows.cs | Enhanced ShellContent navigation logic using ProposeSection |
| src/Controls/src/Core/Handlers/Items/iOS/ObservableGroupedSource.cs | Minor adjustment in index incrementation logic |
| src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs | Updated OS version checks for tab bar visibility management |
| src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellItemRenderer.cs | Simplified iOS version check for tab bar hidden state |
| src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellToolbarAppearanceTracker.cs | Added tint color update for Shell toolbar on Android |
| src/Controls/src/Core/Compatibility/Handlers/ListView/Android/ListViewRenderer.cs | Added call to close context actions on detachment from window |
| src/Controls/Maps/src/AppHostBuilderExtensions.cs | Updated Maps initialization with new API signature |
| eng/pipelines/common/variables.yml | Pipeline variable updated to include the inflight branch condition |
Files not reviewed (2)
- eng/Versions.props: Language not supported
- src/Controls/tests/TestCases.HostApp/Issues/Issue17228.xaml: Language not supported
Comments suppressed due to low confidence (2)
src/Controls/tests/TestCases.HostApp/Issues/Issue17105.cs:20
- The test description indicates that the password hint should be hidden when the entry is focused, but a placeholder is still provided. Please verify if this placeholder text is intended or if it should be removed/modified to align with the expected behavior.
Placeholder = "Password: testing_password",
src/Controls/Maps/src/AppHostBuilderExtensions.cs:46
- Passing null as the third parameter may lead to unintended behavior if the updated MapsInitializer API expects a valid configuration object. Please verify this against the latest documentation.
MapsInitializer.Initialize(a, MapsInitializer.Renderer.Latest, null);
| [InlineData("https://example.com/test/%3Cvalue%3E")] // Escaped character from " <>`^{|} set (e.g., < >) | ||
| [InlineData("https://example.com/path/%09text")] // Escaped character from [0, 1F] range (e.g., tab %09) | ||
| [InlineData("https://example.com/test?query=%26value")] // Another escaped character from reserved set (e.g., & as %26) | ||
| public async Task WebViewShouldLoadEncodedUrl(string encodedUrl) |
Contributor
There was a problem hiding this comment.
@PureWeen This fails randomly on iOS. I don' t think Navigated is getting fired in this setup. Should we convert this to a UITest?
Member
Author
There was a problem hiding this comment.
Yea, I'll merge this one for now since it seems fairly rare
but we can probably just conver to UITest
@sheiksyedm
…and Drop Gesture (#27845) * Fixed-Drag-And-Drop-RunTime * Modified-Test * Reverted-test * Modified-Code * Reverted-Unwanted-Changes * Modified.
…ebViewSource (#28354) * WebView navigated event fix * Test sample changes.
* Fixed the refresh color is not applied to the refresh view * Added the test case for IOS
* Fixed bar textcolor used in secondary toolbar * Update MauiToolbar.xaml.cs * resolved the changes * Update Issue20177.cs * modified issue string * added windows snapshot
* [ci] Update inflight package name * Fix inflight signing * [ci] Use condition BUILD_SOURCEBRANCHNAME
…8905) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) * [Windows] Fix for 7144 ( IndicatorView using templated icons not working ) SyedAbdulAzeemSF4852 SyedAbdulAzeemSF4852 committed last week * Have added snapshots for iOS and Android * Have added the snapshots * [Windows] Fix for 7144 ( IndicatorView using templated icons not working )
* Fix Core API XML Documentation * Update Thickness.cs
…Color() (#27811) * remove excessive UpdateDate() call * adding Ui test * update UItest * adding snapshots * add a static date in test case * match date with snapshots * change preprocessor directive * add comment
* Use latest map renderer for Android Google Maps * Revert "Use latest map renderer for Android Google Maps" This reverts commit 66494aa. * Move use latest renderer to UseMauiMaps
…racters (#27003) * Fix code and test case commit * test case code updated * removed ui tests as it used user name included url * updated unit test case * updated fix and unit test case * updated the new class access specifier. * Removed unit test descriptions * Fix updated * updated the unit test case * Reverted unit test and added UI test case * updated test case description * updating ui test case with ignore windows comment * updated windows issue url * updating test case with comments. * updated the test case as device test * removed ui test * Fix build error * updated device test with conditional skip code * updating test case with internet connectivity checks. --------- Co-authored-by: Gerald Versluis <gerald@verslu.is>
* Fix Changes and testcases * Update ShellItemHandler.Windows.cs * commit for label changes * Update ShellItemHandler.Windows.cs
…ed (#25768) * Update TextFieldExtensions.cs fix added * Revert "Fixed CollectionViewHandler2 null reference exception if ItemsLayout is set for Tablet but not on mobile devices (#26152)" This reverts commit 0ddc794. * Reapply "Fixed CollectionViewHandler2 null reference exception if ItemsLayout is set for Tablet but not on mobile devices (#26152)" This reverts commit 4b9074c. * Moved fix to platform specific for macOS * Updated Screenshot for mac --------- Co-authored-by: Dhivya-SF4094 <127717131+Dhivya-SF4094@users.noreply.github.com>
* [Android] Custom back button image color * Added snapshots and excluded Windows form tests * Update CustomBackButtonShouldBeRed.png
…#29122) * Fixed the collection view highlighting issue * Remove unwanted code section * Added UI test case. * Updated the fix and added output images
… on Windows (#29058) * fix added * Test added * namespace changes added * modified the test * Windows and iOS snap added * Android snap added
…ture (#29002) * Added GroupingFeature tests * updated changes * updated changes * Added test fails attribute * Corrected Mistakes * Updated Images * Corrected mistakes * Changes updated * Modified changes * Resolved Conflicts
…29161) * Move test case UI to host app * Add missing snapshots for SelectionShouldNotMovedToTopWithGroupedCollection
* fix-29158 * Update Issue28098.cs * Update BlankScreenOnNavigationBack.png
PureWeen
force-pushed
the
inflight/candidate
branch
from
de14b65 to
bf34094
Compare
Member
Author
|
The crashing on the device tests is unrelated to this PR. For some reason the check isn't updating on this one when the green run of tests gets reran. It's green on a few runs |
rmarinho
approved these changes
May 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For more information about inflight process check
https://github.com/dotnet/maui/wiki/Inflight-Branch-Process
.NET MAUI Release Notes - May 2025
MAUI Product Fixes
Dependency Updates
Microsoft.Web.WebView2from1.0.2903.40to1.0.3179.45#29139Testing
Docs
Housekeeping
WinUI.targets#29256Full Changelog: 8511167...b498783