Skip to content

Fixed Test case failure in PR 29158 - [2025/04/28] Candidate#29168

Merged
PureWeen merged 3 commits intodotnet:inflight/candidatefrom
HarishKumarSF4517:harish_fix_29158
Apr 28, 2025
Merged

Fixed Test case failure in PR 29158 - [2025/04/28] Candidate#29168
PureWeen merged 3 commits intodotnet:inflight/candidatefrom
HarishKumarSF4517:harish_fix_29158

Conversation

@HarishKumarSF4517
Copy link
Copy Markdown
Contributor

Description

This pull request includes changes aimed at resolving test failures observed in the Candidate PR(#29158)
Key updates include replacing certain UI components to improve test compatibility, adding wait conditions for enhanced navigation stability, and implementing platform-specific logic for screenshot verification.

Test Case Updates:

Issue17105:

  • Updated to the latest Mac image.
  • Replaced Entry with UITestEntry and set IsCursorVisible = false to ensure consistent UI behavior.

Bugzilla32615Test:

  • Added App.WaitForElement to ensure UI readiness before interactions.

Issue8529:

  • Used App.WaitForElementTillPageNavigationSettled to handle potential navigation delays more robustly.

Issue28098:

  • This test fails intermittently due to scrollbar visibility, which appears randomly in CI.
  • Added logic to crop screenshots on Windows to ignore the inconsistent scrollbar region, reducing flakiness.

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Apr 24, 2025
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Hey there @@HarishKumarSF4517! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Apr 24, 2025
@HarishKumarSF4517 HarishKumarSF4517 marked this pull request as ready for review April 24, 2025 11:20
@HarishKumarSF4517 HarishKumarSF4517 requested a review from a team as a code owner April 24, 2025 11:20
@HarishKumarSF4517 HarishKumarSF4517 requested review from jsuarezruiz and rmarinho and removed request for a team April 24, 2025 11:20
@ghost ghost added test-flight area-testing Unit tests, device tests labels Apr 24, 2025
@PureWeen
Copy link
Copy Markdown
Member

/azp run MAUI-UITests-public

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@PureWeen PureWeen added this to the .NET 9 SR7 milestone Apr 24, 2025
@PureWeen PureWeen moved this from Todo to Ready To Review in MAUI SDK Ongoing Apr 24, 2025
@rmarinho
Copy link
Copy Markdown
Member

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Copy Markdown
Contributor

@bhavanesh2001 bhavanesh2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing new snapshot for BlankScreenOnNavigationBack on windows. Available in latest CI run.

@github-project-automation github-project-automation bot moved this from Ready To Review to Changes Requested in MAUI SDK Ongoing Apr 25, 2025
@HarishKumarSF4517
Copy link
Copy Markdown
Contributor Author

Missing new snapshot for BlankScreenOnNavigationBack on windows. Available in latest CI run.

Hi @bhavanesh2001, I have updated the snapshot for windows.

@ghost ghost moved this from Changes Requested to Ready To Review in MAUI SDK Ongoing Apr 25, 2025
@ghost ghost requested a review from bhavanesh2001 April 25, 2025 05:44
Copy link
Copy Markdown
Contributor

@bhavanesh2001 bhavanesh2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think rest of the failures here will be fixed with #29161

@jsuarezruiz
Copy link
Copy Markdown
Contributor

/azp run MAUI-UITests-public

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@github-project-automation github-project-automation bot moved this from Ready To Review to Approved in MAUI SDK Ongoing Apr 28, 2025
@PureWeen PureWeen merged commit de14b65 into dotnet:inflight/candidate Apr 28, 2025
72 of 77 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in MAUI SDK Ongoing Apr 28, 2025
PureWeen pushed a commit that referenced this pull request May 2, 2025
* fix-29158

* Update Issue28098.cs

* Update BlankScreenOnNavigationBack.png
SuthiYuvaraj pushed a commit to SuthiYuvaraj/maui that referenced this pull request May 9, 2025
…29168)

* fix-29158

* Update Issue28098.cs

* Update BlankScreenOnNavigationBack.png
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-testing Unit tests, device tests community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration test-flight

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants