[Windows] Fixed CollectionView.EmptyView can not be removed by setting it to Null by Dhivya-SF4094 · Pull Request #29487 · dotnet/maui

Dhivya-SF4094 · 2025-05-14T06:41:28Z

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Issue Details

In WinUI, setting the CollectionView's EmptyView to null does not fully remove the associated visual element. While the reference is cleared, the view remains in the visual tree and memory, leading to an inconsistent UI state.

Root Cause

When EmptyView was set to null, the handler exited early without performing the necessary cleanup. As a result, the visual element persisted in the UI tree and memory.

Description of Change

The logic now explicitly collapses the EmptyView's visibility when applicable and removes it from the logical tree to ensure it is detached from the visual hierarchy. Internal references are cleared, and the display flag is reset to maintain an accurate UI state.

#29463 - Issue 1: EmptyView Template is Not Displayed

Root Cause

The EmptyViewTemplate was not considered in the UpdateEmptyView, causing it to be ignored.

Description of Change

The EmptyViewTemplate is now properly managed to ensure it appears when appropriate.

Validated the behaviour in the following platforms

Android
Windows
iOS
Mac

Issues Fixed:

Fixes #18657
Fixes #29463
Fixes #18551
Fixes #23330

Screenshots

Before	After
18657_BeforeFix.mp4	18657_AfterFix.mp4

jsuarezruiz · 2025-05-16T11:19:31Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-05-16T11:19:44Z

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz · 2025-05-19T06:43:28Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-05-19T06:43:39Z

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz

These tests:

Seems to be crashing on Windows.
The app was expected to be running still, investigate as possible crash

Could you review if are related with the changes?

Dhivya-SF4094 · 2025-05-20T11:46:54Z

These tests:

Seems to be crashing on Windows. The app was expected to be running still, investigate as possible crash

Could you review if are related with the changes?

@jsuarezruiz Currently looking into the CI test failure on Windows.

Dhivya-SF4094 · 2025-05-22T11:13:23Z

These tests:

Seems to be crashing on Windows. The app was expected to be running still, investigate as possible crash

Could you review if are related with the changes?

@jsuarezruiz Fixed CI failure. Could you please review it once.

jsuarezruiz · 2025-05-26T07:27:04Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-05-26T07:27:18Z

Azure Pipelines successfully started running 1 pipeline(s).

src/Controls/src/Core/Handlers/Items/ItemsViewHandler.Windows.cs

MauiBot · 2026-03-21T20:46:58Z

🤖 AI Summary

📊 Expand Full Review — 919a4e9 · Added snapshot for iOS 26

🔍 Pre-Flight — Context & Validation

Issue: #18657 - [Windows] CollectionView.EmptyView can not be removed by setting it to Null (also #29463, #18551, #23330)
PR: #29487 - [Windows] Fixed CollectionView.EmptyView can not be removed by setting it to Null
Platforms Affected: Windows (runtime fix is Windows-only in ItemsViewHandler.Windows.cs)
Files Changed: 1 implementation (ItemsViewHandler.Windows.cs), 2 test source files (Issue18657.cs HostApp + UITest), 1 test modification (Issue25224.xaml.cs), 5 screenshot assets

Key Findings

The runtime fix is strictly Windows-only: only src/Controls/src/Core/Handlers/Items/ItemsViewHandler.Windows.cs was changed.
The PR fixes four linked issues: EmptyView = null not cleaning up visual tree ([Windows] CollectionView.EmptyView can not be removed by setting it to Null #18657), EmptyViewTemplate not displayed ([Windows] EmptyViewTemplate Not Working in CarouselView #29463), broader EmptyViewTemplate behavior (EmptyViewTemplate does not do anything #18551), DataTemplateSelector null issue on Windows ([MAUI] I5_EmptyView - The data template selector cannot display the correct string. #23330).
When EmptyView and EmptyViewTemplate are both null, the old code exited early without cleaning up _emptyView/_formsEmptyView or calling SetEmptyView(null, null). The PR now calls RemoveEmptyView(), disconnects the handler for _formsEmptyView, nulls both fields, and calls SetEmptyView(null, null).
When EmptyViewTemplate is non-null, the old code ignored it. The PR now calls RealizeEmptyViewTemplate() in this case.
Gate ❌ FAILED because the Issue18657.RemoveEmptyViewAtRuntime UITest PASSES without the fix on Android — the fix is irrelevant on Android since the bug only exists in the Windows handler. "Without Fix" PASSED instead of FAILed, so the gate correctly detects the test doesn't catch the bug on Android.
The test uses VerifyScreenshot(), so Android test outcome depends on Android behavior, not Windows behavior.
Issue25224.xaml.cs got a null guard in SearchTermDataTemplateSelector.OnSelectTemplate to avoid null crashes during template selection.
Several Copilot inline review suggestions were addressed: disconnecting handler in null branch, using ?.ToString() for emptyView string cast, and using more descriptive AutomationIds (Issue18657Button, Issue18657EmptyView).
Prior agent review found in PR comments (from MauiBot) — that review also concluded REQUEST CHANGES due to same Android-vs-Windows platform mismatch.

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
PR	PR #29487	Refactor `UpdateEmptyView()` on Windows: null both `emptyView` and `emptyViewTemplate` → actively call `RemoveEmptyView()`, disconnect handler, null fields, call `SetEmptyView(null,null)`; also handle `EmptyViewTemplate` case via `RealizeEmptyViewTemplate()`.	❌ GATE FAILED (Android cannot validate Windows fix)	`ItemsViewHandler.Windows.cs`, `Issue18657.cs` (HostApp+UITest), `Issue25224.xaml.cs`	Runtime fix is Windows-only; Android gate is not meaningful for this PR.

🔧 Fix — Analysis & Comparison

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
1	try-fix (claude-opus-4.6)	Unconditional reset-first: always clean up old `_emptyView`/`_formsEmptyView` at start of `UpdateEmptyView()`, then conditionally build new view. No helper method.	⚠️ BLOCKED	`ItemsViewHandler.Windows.cs`	Android cannot validate Windows-only fix; compiles cleanly.
2	try-fix (claude-sonnet-4.6)	State-driven visibility: delegate null cleanup to `UpdateEmptyViewVisibility()` rather than inline in `UpdateEmptyView()`; `UpdateEmptyViewVisibility` becomes the single authority for visual state.	⚠️ BLOCKED	`ItemsViewHandler.Windows.cs`	Android passes but cannot validate Windows-only path.
3	try-fix (gpt-5.3-codex)	Mapper-first lifecycle: shift null-clearing and template-realization responsibility into `MapEmptyView`/`MapEmptyViewTemplate` mapper entry points instead of `UpdateEmptyView()`.	⚠️ BLOCKED	`ItemsViewHandler.Windows.cs`	Android passed; Windows-only path still unvalidatable on Android.
PR	PR #29487	Refactor `UpdateEmptyView()` on Windows: null case actively removes/disconnects empty view; template case uses `RealizeEmptyViewTemplate()`.	❌ GATE FAILED	`ItemsViewHandler.Windows.cs`, test files	Windows-only fix; Android gate not meaningful.

Cross-Pollination

(pending)

Exhausted: No
Selected Fix: Pending

github-actions · 2026-03-24T11:38:14Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 29487

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 29487"

Dhivya-SF4094 · 2026-03-24T11:39:11Z

Validated and addressed the AI summary.

Copilot

Pull request overview

This PR fixes Windows (WinUI) ItemsView/CollectionView empty-view handling so that EmptyView and EmptyViewTemplate updates correctly detach/hide the empty view, including when EmptyView is set back to null. It also adds a new UITest + baseline screenshots to prevent regressions.

Changes:

Update WinUI ItemsViewHandler empty-view logic to properly remove/collapse the empty view and to honor EmptyViewTemplate.
Add a new issues page + UITest for #18657 and add snapshot baselines across platforms.
Add a null guard in a DataTemplateSelector used by an existing issue page.

Reviewed changes

Copilot reviewed 4 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/Controls/src/Core/Handlers/Items/ItemsViewHandler.Windows.cs	Adjusts WinUI empty view creation/removal and template realization logic.
src/Controls/tests/TestCases.HostApp/Issues/Issue18657.cs	Adds a repro page for removing `EmptyView` at runtime.
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue18657.cs	Adds an Appium UITest asserting the empty view is removed (via screenshot).
src/Controls/tests/TestCases.HostApp/Issues/Issue25224.xaml.cs	Handles `null` items in a template selector (to support `EmptyViewTemplate` scenarios).
src/Controls/tests/TestCases.WinUI.Tests/snapshots/windows/RemoveEmptyViewAtRuntime.png	New WinUI screenshot baseline for the new test.
src/Controls/tests/TestCases.Android.Tests/snapshots/android/RemoveEmptyViewAtRuntime.png	New Android screenshot baseline for the new test.
src/Controls/tests/TestCases.iOS.Tests/snapshots/ios/RemoveEmptyViewAtRuntime.png	New iOS screenshot baseline for the new test.
src/Controls/tests/TestCases.Mac.Tests/snapshots/mac/RemoveEmptyViewAtRuntime.png	New Mac screenshot baseline for the new test.

src/Controls/src/Core/Handlers/Items/ItemsViewHandler.Windows.cs

src/Controls/tests/TestCases.HostApp/Issues/Issue18657.cs

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue18657.cs

src/Controls/src/Core/Handlers/Items/ItemsViewHandler.Windows.cs

sheiksyedm · 2026-03-26T07:23:13Z

/azp run maui-pr-uitests , maui-pr-devicetests

azure-pipelines · 2026-03-26T07:23:32Z

Azure Pipelines successfully started running 2 pipeline(s).

MauiBot · 2026-03-29T20:15:20Z

🚦 Gate - Test Before and After Fix

📊 Expand Full Gate — 919a4e9 · Added snapshot for iOS 26

Gate Result: ❌ FAILED

Platform: ANDROID · Base: main · Merge base: 720a9d4a

Test	Without Fix (expect FAIL)	With Fix (expect PASS)
🖥️ Issue18657 `Issue18657`	❌ PASS — 2237s	✅ PASS — 518s

🔴 Without fix — 🖥️ Issue18657: PASS ❌ · 2237s

(truncated to last 15,000 chars)

nux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010:    at AndroidDeviceExtensions.PushAndInstallPackageAsync(AndroidDevice device, PushAndInstallCommand command, CancellationToken token) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010:    at AndroidDeviceExtensions.PushAndInstallPackageAsync(AndroidDevice device, PushAndInstallCommand command, CancellationToken token) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010:    at Xamarin.Android.Tasks.FastDeploy.InstallPackage(Boolean installed) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010:    at Xamarin.Android.Tasks.FastDeploy.InstallPackage(Boolean installed) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010:    at Xamarin.Android.Tasks.FastDeploy.RunInstall() [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]

Build FAILED.

/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: Mono.AndroidTools.InstallFailedException: Unexpected install output: cmd: Failure calling service package: Broken pipe (32) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010:  [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010:    at Mono.AndroidTools.Internal.AdbOutputParsing.CheckInstallSuccess(String output, String packageName) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010:    at Mono.AndroidTools.AndroidDevice.<>c__DisplayClass105_0.<InstallPackage>b__0(Task`1 t) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010:    at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: --- End of stack trace from previous location --- [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010:    at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010:    at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: --- End of stack trace from previous location --- [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010:    at AndroidDeviceExtensions.PushAndInstallPackageAsync(AndroidDevice device, PushAndInstallCommand command, CancellationToken token) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010:    at AndroidDeviceExtensions.PushAndInstallPackageAsync(AndroidDevice device, PushAndInstallCommand command, CancellationToken token) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010:    at Xamarin.Android.Tasks.FastDeploy.InstallPackage(Boolean installed) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010:    at Xamarin.Android.Tasks.FastDeploy.InstallPackage(Boolean installed) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010:    at Xamarin.Android.Tasks.FastDeploy.RunInstall() [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
    0 Warning(s)
    1 Error(s)

Time Elapsed 00:15:56.79
* daemon not running; starting now at tcp:5037
* daemon started successfully
  Determining projects to restore...
  All projects are up-to-date for restore.
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  Graphics -> /home/vsts/work/1/s/artifacts/bin/Graphics/Debug/net10.0-android36.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  Essentials -> /home/vsts/work/1/s/artifacts/bin/Essentials/Debug/net10.0-android36.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  Core -> /home/vsts/work/1/s/artifacts/bin/Core/Debug/net10.0-android36.0/Microsoft.Maui.dll
  Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  Maps -> /home/vsts/work/1/s/artifacts/bin/Maps/Debug/net10.0-android36.0/Microsoft.Maui.Maps.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.Core/Debug/net10.0-android36.0/Microsoft.Maui.Controls.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  Controls.Xaml -> /home/vsts/work/1/s/artifacts/bin/Controls.Xaml/Debug/net10.0-android36.0/Microsoft.Maui.Controls.Xaml.dll
  Microsoft.AspNetCore.Components.WebView.Maui -> /home/vsts/work/1/s/artifacts/bin/Microsoft.AspNetCore.Components.WebView.Maui/Debug/net10.0-android36.0/Microsoft.AspNetCore.Components.WebView.Maui.dll
  Controls.Foldable -> /home/vsts/work/1/s/artifacts/bin/Controls.Foldable/Debug/net10.0-android36.0/Microsoft.Maui.Controls.Foldable.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  Controls.Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.Maps/Debug/net10.0-android36.0/Microsoft.Maui.Controls.Maps.dll
  Controls.TestCases.HostApp -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Controls.TestCases.HostApp.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  Graphics -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  Essentials -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  Core -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.dll
  Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Maps.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  Controls.Foldable -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Foldable.dll
  Microsoft.AspNetCore.Components.WebView.Maui -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.AspNetCore.Components.WebView.Maui.dll
  Controls.Xaml -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Xaml.dll
  Controls.Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Maps.dll

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:08:49.94
Broadcasting: Intent { act=android.intent.action.CLOSE_SYSTEM_DIALOGS flg=0x400000 }
Broadcast completed: result=0
Broadcasting: Intent { act=android.intent.action.CLOSE_SYSTEM_DIALOGS flg=0x400000 }
Broadcast completed: result=0
  Determining projects to restore...
  Restored /home/vsts/work/1/s/src/TestUtils/src/VisualTestUtils/VisualTestUtils.csproj (in 1.51 sec).
  Restored /home/vsts/work/1/s/src/TestUtils/src/UITest.NUnit/UITest.NUnit.csproj (in 2.15 sec).
  Restored /home/vsts/work/1/s/src/TestUtils/src/UITest.Core/UITest.Core.csproj (in 3 ms).
  Restored /home/vsts/work/1/s/src/TestUtils/src/VisualTestUtils.MagickNet/VisualTestUtils.MagickNet.csproj (in 4.71 sec).
  Restored /home/vsts/work/1/s/src/Controls/tests/CustomAttributes/Controls.CustomAttributes.csproj (in 5 ms).
  Restored /home/vsts/work/1/s/src/TestUtils/src/UITest.Appium/UITest.Appium.csproj (in 376 ms).
  Restored /home/vsts/work/1/s/src/Controls/tests/TestCases.Android.Tests/Controls.TestCases.Android.Tests.csproj (in 2.04 sec).
  Restored /home/vsts/work/1/s/src/TestUtils/src/UITest.Analyzers/UITest.Analyzers.csproj (in 2.04 sec).
  5 of 13 projects are up-to-date for restore.
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  Graphics -> /home/vsts/work/1/s/artifacts/bin/Graphics/Debug/net10.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  Essentials -> /home/vsts/work/1/s/artifacts/bin/Essentials/Debug/net10.0/Microsoft.Maui.Essentials.dll
  Controls.CustomAttributes -> /home/vsts/work/1/s/artifacts/bin/Controls.CustomAttributes/Debug/net10.0/Controls.CustomAttributes.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  Core -> /home/vsts/work/1/s/artifacts/bin/Core/Debug/net10.0/Microsoft.Maui.dll
  Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.Core/Debug/net10.0/Microsoft.Maui.Controls.dll
  VisualTestUtils -> /home/vsts/work/1/s/artifacts/bin/VisualTestUtils/Debug/netstandard2.0/VisualTestUtils.dll
  UITest.Core -> /home/vsts/work/1/s/artifacts/bin/UITest.Core/Debug/net10.0/UITest.Core.dll
  VisualTestUtils.MagickNet -> /home/vsts/work/1/s/artifacts/bin/VisualTestUtils.MagickNet/Debug/netstandard2.0/VisualTestUtils.MagickNet.dll
  UITest.NUnit -> /home/vsts/work/1/s/artifacts/bin/UITest.NUnit/Debug/net10.0/UITest.NUnit.dll
  UITest.Appium -> /home/vsts/work/1/s/artifacts/bin/UITest.Appium/Debug/net10.0/UITest.Appium.dll
  UITest.Analyzers -> /home/vsts/work/1/s/artifacts/bin/UITest.Analyzers/Debug/netstandard2.0/UITest.Analyzers.dll
  Controls.TestCases.Android.Tests -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
Test run for /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll (.NETCoreApp,Version=v10.0)
VSTest version 18.0.1 (x64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
/home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.8.2+699d445a1a (64-bit .NET 10.0.0)
[xUnit.net 00:00:00.11]   Discovering: Controls.TestCases.Android.Tests
[xUnit.net 00:00:00.43]   Discovered:  Controls.TestCases.Android.Tests
NUnit Adapter 4.5.0.0: Test execution started
Running selected tests in /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
   NUnit3TestExecutor discovered 1 of 1 NUnit test cases using Current Discovery mode, Non-Explicit run
>>>>> 03/29/2026 19:57:14 FixtureSetup for Issue18657(Android)
>>>>> 03/29/2026 19:57:17 RemoveEmptyViewAtRuntime Start
>>>>> 03/29/2026 19:57:21 RemoveEmptyViewAtRuntime Stop
  Passed RemoveEmptyViewAtRuntime [4 s]
NUnit Adapter 4.5.0.0: Test execution complete

Test Run Successful.
Total tests: 1
     Passed: 1
 Total time: 34.4364 Seconds

🟢 With fix — 🖥️ Issue18657: PASS ✅ · 518s

  Determining projects to restore...
  All projects are up-to-date for restore.
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  Graphics -> /home/vsts/work/1/s/artifacts/bin/Graphics/Debug/net10.0-android36.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  Essentials -> /home/vsts/work/1/s/artifacts/bin/Essentials/Debug/net10.0-android36.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  Core -> /home/vsts/work/1/s/artifacts/bin/Core/Debug/net10.0-android36.0/Microsoft.Maui.dll
  Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  Maps -> /home/vsts/work/1/s/artifacts/bin/Maps/Debug/net10.0-android36.0/Microsoft.Maui.Maps.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.Core/Debug/net10.0-android36.0/Microsoft.Maui.Controls.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  Microsoft.AspNetCore.Components.WebView.Maui -> /home/vsts/work/1/s/artifacts/bin/Microsoft.AspNetCore.Components.WebView.Maui/Debug/net10.0-android36.0/Microsoft.AspNetCore.Components.WebView.Maui.dll
  Controls.Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.Maps/Debug/net10.0-android36.0/Microsoft.Maui.Controls.Maps.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  Controls.Xaml -> /home/vsts/work/1/s/artifacts/bin/Controls.Xaml/Debug/net10.0-android36.0/Microsoft.Maui.Controls.Xaml.dll
  Controls.Foldable -> /home/vsts/work/1/s/artifacts/bin/Controls.Foldable/Debug/net10.0-android36.0/Microsoft.Maui.Controls.Foldable.dll
  Controls.TestCases.HostApp -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Controls.TestCases.HostApp.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  Graphics -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  Essentials -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  Core -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.dll
  Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Maps.dll
  Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  Microsoft.AspNetCore.Components.WebView.Maui -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.AspNetCore.Components.WebView.Maui.dll
  Controls.Xaml -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Xaml.dll
  Controls.Foldable -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Foldable.dll
  Controls.Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Maps.dll

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:06:44.46
Broadcasting: Intent { act=android.intent.action.CLOSE_SYSTEM_DIALOGS flg=0x400000 }
Broadcast completed: result=0
Broadcasting: Intent { act=android.intent.action.CLOSE_SYSTEM_DIALOGS flg=0x400000 }
Broadcast completed: result=0
  Determining projects to restore...
  All projects are up-to-date for restore.
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  Graphics -> /home/vsts/work/1/s/artifacts/bin/Graphics/Debug/net10.0/Microsoft.Maui.Graphics.dll
  Controls.CustomAttributes -> /home/vsts/work/1/s/artifacts/bin/Controls.CustomAttributes/Debug/net10.0/Controls.CustomAttributes.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  Essentials -> /home/vsts/work/1/s/artifacts/bin/Essentials/Debug/net10.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  Core -> /home/vsts/work/1/s/artifacts/bin/Core/Debug/net10.0/Microsoft.Maui.dll
  Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684011
  Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.Core/Debug/net10.0/Microsoft.Maui.Controls.dll
  UITest.Core -> /home/vsts/work/1/s/artifacts/bin/UITest.Core/Debug/net10.0/UITest.Core.dll
  UITest.Appium -> /home/vsts/work/1/s/artifacts/bin/UITest.Appium/Debug/net10.0/UITest.Appium.dll
  VisualTestUtils -> /home/vsts/work/1/s/artifacts/bin/VisualTestUtils/Debug/netstandard2.0/VisualTestUtils.dll
  UITest.NUnit -> /home/vsts/work/1/s/artifacts/bin/UITest.NUnit/Debug/net10.0/UITest.NUnit.dll
  VisualTestUtils.MagickNet -> /home/vsts/work/1/s/artifacts/bin/VisualTestUtils.MagickNet/Debug/netstandard2.0/VisualTestUtils.MagickNet.dll
  UITest.Analyzers -> /home/vsts/work/1/s/artifacts/bin/UITest.Analyzers/Debug/netstandard2.0/UITest.Analyzers.dll
  Controls.TestCases.Android.Tests -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
Test run for /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll (.NETCoreApp,Version=v10.0)
VSTest version 18.0.1 (x64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
/home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.8.2+699d445a1a (64-bit .NET 10.0.0)
[xUnit.net 00:00:00.17]   Discovering: Controls.TestCases.Android.Tests
[xUnit.net 00:00:00.55]   Discovered:  Controls.TestCases.Android.Tests
NUnit Adapter 4.5.0.0: Test execution started
Running selected tests in /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
   NUnit3TestExecutor discovered 1 of 1 NUnit test cases using Current Discovery mode, Non-Explicit run
>>>>> 03/29/2026 20:15:05 FixtureSetup for Issue18657(Android)
>>>>> 03/29/2026 20:15:08 RemoveEmptyViewAtRuntime Start
>>>>> 03/29/2026 20:15:11 RemoveEmptyViewAtRuntime Stop
  Passed RemoveEmptyViewAtRuntime [3 s]
NUnit Adapter 4.5.0.0: Test execution complete

Test Run Successful.
Total tests: 1
     Passed: 1
 Total time: 18.1107 Seconds

⚠️ Issues found

❌ Issue18657 PASSED without fix (should fail) — tests don't catch the bug

📁 Fix files reverted (2 files)

eng/pipelines/ci-copilot.yml
src/Controls/src/Core/Handlers/Items/ItemsViewHandler.Windows.cs

dotnet-policy-service bot added community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration labels May 14, 2025

sheiksyedm added the area-controls-collectionview CollectionView, CarouselView, IndicatorView label May 14, 2025

rmarinho previously approved these changes May 14, 2025

View reviewed changes

Dhivya-SF4094 dismissed rmarinho’s stale review via 35a31be May 14, 2025 14:25

Dhivya-SF4094 marked this pull request as ready for review May 14, 2025 14:27

Dhivya-SF4094 requested a review from a team as a code owner May 14, 2025 14:27

Dhivya-SF4094 requested review from jfversluis and jsuarezruiz May 14, 2025 14:27

jsuarezruiz suggested changes May 20, 2025

View reviewed changes

jsuarezruiz reviewed Jun 17, 2025

View reviewed changes

src/Controls/src/Core/Handlers/Items/ItemsViewHandler.Windows.cs Show resolved Hide resolved

MauiBot added s/agent-changes-requested AI agent recommends changes - found a better alternative or issues s/agent-fix-win AI found a better alternative fix than the PR s/agent-reviewed PR was reviewed by AI agent workflow (full 4-phase review) labels Mar 21, 2026

Dhivya-SF4094 and others added 6 commits March 24, 2026 15:52

Added screenshot for iOS

213fa08

Fixed CollectionView.EmptyView can not be removed by setting it to Null

0764ed7

Updated fix in UpdateEmptyViewVisibility

6d4172f

Updated fix In ItemsViewHandler

080a314

Added snapshots

a9d2030

Fixed CI failure

72c154f

Dhivya-SF4094 changed the title ~~Fixed CollectionView.EmptyView can not be removed by setting it to Null~~ [Windows] Fixed CollectionView.EmptyView can not be removed by setting it to Null Mar 24, 2026

Dhivya-SF4094 force-pushed the fix-18657 branch from bb26b9e to 72c154f Compare March 24, 2026 11:38

Copilot AI review requested due to automatic review settings March 24, 2026 11:38

Addressed AI summary

3ac064b

Copilot started reviewing on behalf of Dhivya-SF4094 March 24, 2026 11:38 View session

Copilot AI reviewed Mar 24, 2026

View reviewed changes

Updated UpdateEmptyView() and modified AutomationId

7cb0e4e

This was referenced Mar 26, 2026

System.TimeoutException #33245

Open

CI UItests failure System.TimeoutException : Timed out waiting for element... #33220

Open

Added snapshot for iOS 26

919a4e9

MauiBot added s/agent-review-incomplete AI agent could not complete all phases (blocker, timeout, error) and removed s/agent-changes-requested AI agent recommends changes - found a better alternative or issues labels Mar 29, 2026

Conversation

Dhivya-SF4094 commented May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue Details

Root Cause

Description of Change

Root Cause

Description of Change

Validated the behaviour in the following platforms

Issues Fixed:

Screenshots

Uh oh!

jsuarezruiz commented May 16, 2025

Uh oh!

azure-pipelines bot commented May 16, 2025

Uh oh!

jsuarezruiz commented May 19, 2025

Uh oh!

azure-pipelines bot commented May 19, 2025

Uh oh!

jsuarezruiz left a comment

Choose a reason for hiding this comment

Uh oh!

Dhivya-SF4094 commented May 20, 2025

Uh oh!

Dhivya-SF4094 commented May 22, 2025

Uh oh!

jsuarezruiz commented May 26, 2025

Uh oh!

azure-pipelines bot commented May 26, 2025

Uh oh!

Uh oh!

MauiBot commented Mar 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 AI Summary

Key Findings

Fix Candidates

Fix Candidates

Cross-Pollination

Uh oh!

github-actions bot commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Dhivya-SF4094 commented Mar 24, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sheiksyedm commented Mar 26, 2026

Uh oh!

azure-pipelines bot commented Mar 26, 2026

Uh oh!

MauiBot commented Mar 29, 2026

🚦 Gate - Test Before and After Fix

Gate Result: ❌ FAILED

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Dhivya-SF4094 commented May 14, 2025 •

edited

Loading

MauiBot commented Mar 21, 2026 •

edited

Loading

github-actions bot commented Mar 24, 2026 •

edited

Loading