Fixed BindingContext of the Window TitleBar is not being passed on to its child content.

[NirmalKumarYuvaraj]

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Issue Details:

BindingContext of the Window TitleBar is not being passed on to its child content (Content, LeadingContent, TrailingContent).

Description of Change

• Added an override for the OnBindingContextChanged method in the TitleBar class to propagate the BindingContext to its child elements (Content, LeadingContent, and TrailingContent).
• Updated the OnLeadingChanged, OnContentChanged, and OnTrailingContentChanged methods to clear and reapply the inherited BindingContext when the respective properties change.

Validated the behaviour in the following platforms

• Android
• Windows
• iOS
• Mac

Issues Fixed

Fixes #24831

Output

Before	After

[dotnet-policy-service]

Hey there @@NirmalKumarYuvaraj! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

[Copilot]

Pull Request Overview

This PR fixes the issue where the BindingContext of the Window TitleBar was not propagated to its child content by adding an override for OnBindingContextChanged in the TitleBar class and updating the property change handlers.

• Propagated BindingContext changes to Content, LeadingContent, and TrailingContent.
• Added test cases in TestCases.Shared.Tests and updated the host sample in TestCases.HostApp to validate the fix.
• Updated PublicAPI files to include the new override method.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

File	Description
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue24831.cs	Added a test case to verify BindingContext propagation for the TitleBar.
src/Controls/tests/TestCases.HostApp/Issues/Issue24831.cs	Implemented a sample demonstrating the TitleBar BindingContext propagation fix.
src/Controls/src/Core/TitleBar/TitleBar.cs	Overrode OnBindingContextChanged and adjusted OnLeadingChanged, OnContentChanged, and OnTrailingContentChanged to propagate the BindingContext.
PublicAPI Unshipped Files	Declared the new override in the public API for multiple target frameworks.

[jsuarezruiz]

@NirmalKumarYuvaraj Could you rebase to fix the conflicts?

[NirmalKumarYuvaraj]

@NirmalKumarYuvaraj Could you rebase to fix the conflicts?

@jsuarezruiz , I have rebased.

[jsuarezruiz]

@NirmalKumarYuvaraj Could you rebase to fix the conflicts?

@jsuarezruiz , I have rebased.

Sorry, but requires rebase again :(

[NirmalKumarYuvaraj]

@NirmalKumarYuvaraj Could you rebase to fix the conflicts?

@jsuarezruiz , I have rebased.

Sorry, but requires rebase again :(

Rebased

[jsuarezruiz]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[MauiBot]

⚠️ Merge Conflict Detected — This PR has merge conflicts with its target branch. Please rebase onto the target branch and resolve the conflicts.

[kubaflo]

Could you please resolve conflicts?

[github-actions]

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 30080

Or

• Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 30080"

[NirmalKumarYuvaraj]

@kubaflo , I have resolved the conflicts. Please let me know if you have any concerns.

[kubaflo]

Could you please review the AI's summary?

[sheiksyedm]

/azp run maui-pr-uitests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[NirmalKumarYuvaraj]

@kubaflo , The Last AI summary is incomplete. Gate failed due to baseline snap missing. I have attached the baseline snap for windows.

[MauiBot]

🤖 AI Summary

📊 Expand Full Review — b7f19c7 · Merge branch 'inflight/current' into fix-24831

---

🔍 Pre-Flight — Context & Validation

---

Issue: #24831 - The BindingContext of the Window TitleBar is not being passed on to its child content
PR: #30080 - Fixed BindingContext of the Window TitleBar is not being passed on to its child content
Platforms Affected: Windows, MacCatalyst (TitleBar is only available on these platforms — NOT Android/iOS)
Files Changed: 1 implementation (TitleBar.cs), 2 test (Issue24831.cs HostApp + SharedTests), 7 PublicAPI.Unshipped.txt files, misc .github/ workflow files

Key Findings

• TitleBar extends TemplatedView; its Content, LeadingContent, and TrailingContent are stored as bindable properties — NOT as logical/visual children — so MAUI's inherited BindingContext propagation never reaches them
• PR adds OnBindingContextChanged() override and updates OnLeadingChanged, OnContentChanged, OnTrailingContentChanged to propagate/clear BindingContext via SetInheritedBindingContext
• UITest (Issue24831) is correctly guarded with #if MACCATALYST || WINDOWS — it does NOT compile on Android
• Gate FAILED on Android because: test is platform-gated (#if MACCATALYST || WINDOWS); no Android-compatible test exists for this feature; HostApp page mistakenly uses PlatformAffected.All instead of restricting to Windows/MacCatalyst
• Prior agent review ran on Windows where Gate ✅ PASSED; PR was subsequently MERGED
• Only existing TitleBar unit test is TitleBarDoesNotLeak (memory test, not BindingContext)
• Copilot code review left a resolved nitpick: extract duplicate BindingContext propagation into a helper method

Gate Failure Root Cause (Android)

The Gate ❌ FAILED on Android because the UITest for Issue24831 is wrapped in #if MACCATALYST || WINDOWS and does not compile/run on Android. The HostApp page uses PlatformAffected.All, which caused the gate test detector to attempt running the test on Android — but the test class does not exist in Android builds.

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
PR	PR #30080	Override OnBindingContextChanged() + update On*Changed handlers to propagate/clear BindingContext via SetInheritedBindingContext	✅ PASSED (Windows Gate)	TitleBar.cs	Canonical MAUI pattern; PR already merged

---

🔧 Fix — Analysis & Comparison

---

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
1	try-fix (claude-opus-4.6)	AddLogicalChild/RemoveLogicalChild in property handlers + SetChildInheritedBindingContext override	✅ PASS	2 files	Framework propagates automatically via logical child mechanism; overrides internal method
2	try-fix (claude-sonnet-4.6)	SetBinding/RemoveBinding on child BindingContextProperty with TitleBar as explicit source	✅ PASS	2 files	Binding infra handles propagation; unconventional use of binding for BindingContext itself
3	try-fix (gpt-5.3-codex)	Centralized propagation via PropertyChanged event handler	✅ PASS	2 files	Single handler; string-based property name comparisons less robust
4	try-fix (gpt-5.4, gemini unavailable)	Bind ContentView wrappers' BindingContext to TemplatedParent.BindingContext in BuildDefaultTemplate()	✅ PASS	2 files	Template-level fix; fragile if user replaces ControlTemplate
5	try-fix (claude-sonnet-4.6)	Override IVisualTreeElement.GetVisualChildren() to expose content views as visual tree children	❌ FAIL	2 files	MAUI BindingContext uses LogicalChildrenInternal, not visual tree
PR	PR #30080	Override OnBindingContextChanged() + SetInheritedBindingContext in each property-changed handler	✅ PASSED (Windows Gate)	1 file	Canonical MAUI pattern; matches ContentView/Frame/Border

Cross-Pollination

Model	Round	New Ideas?	Details
claude-opus-4.6	2	No	Design space exhausted
claude-sonnet-4.6	2	Yes	Visual children approach → ran as Attempt 5 → ❌ FAIL (wrong subsystem)
gpt-5.3-codex	2	Yes	Owner-driven (Window subscription) → wrong problem scope; round 2 idea: slot host elements (variant of Attempt 1)
gpt-5.4	2	Yes	Framework modification (too risky/broad); round 2 idea: bind template root BindingContext (variant of Attempt 4)
All models	3	No	Round 2 new ideas are variants of existing approaches; exhausted

Exhausted: Yes
Selected Fix: PR's fix — most canonical/idiomatic approach in MAUI codebase. Matches pattern used by ContentView, Frame, and Border. Directly handles both orderings (BindingContext-before-content and content-before-BindingContext). Minimal, clear, and maintainable. The 4 alternative passing approaches all had trade-offs: Attempt 1 overrides an internal method; Attempt 2 is unconventional binding usage; Attempt 3 uses string comparisons; Attempt 4 is fragile against ControlTemplate replacement.

---

📋 Report — Final Recommendation

---

⚠️ Final Recommendation: REQUEST CHANGES

Phase Status

Phase	Status	Notes
Pre-Flight	✅ COMPLETE	Issue #24831, TitleBar BindingContext propagation; Windows/MacCatalyst only
Gate	❌ FAILED	Android — test is `#if MACCATALYST
Try-Fix	✅ COMPLETE	5 attempts: 4 passing alternatives, 1 fail (visual children); PR's fix selected
Report	✅ COMPLETE

Summary

PR #30080 correctly fixes BindingContext propagation for TitleBar on Windows/MacCatalyst and was validated on Windows (Gate ✅ PASSED in prior review). However, on Android, the Gate ❌ FAILED because the UITest is correctly scoped to #if MACCATALYST || WINDOWS but the HostApp page uses PlatformAffected.All, which caused the gate test detector to attempt Android testing. The fix itself is sound; the issue is a test scoping mismatch in the HostApp page.

Root Cause (Gate Failure)

Issue24831.cs (HostApp) declares [Issue(..., PlatformAffected.All)] — but TitleBar is a Windows/MacCatalyst-only feature and the corresponding test class (TestCases.Shared.Tests) is wrapped in #if MACCATALYST || WINDOWS. On Android, the test class does not exist in the compiled output, so no test can fail without the fix, no test can pass with the fix — the gate cannot verify correctness and rightly fails.

The fix in TitleBar.cs is correct: It uses SetInheritedBindingContext in OnBindingContextChanged() and in each On*Changed handler — the canonical MAUI pattern matching ContentView, Frame, and Border.

Fix Quality

The PR's core fix is correct and idiomatic:

• Overrides OnBindingContextChanged() to propagate BindingContext to all three slot views when TitleBar's context changes
• Updates OnLeadingChanged, OnContentChanged, OnTrailingContentChanged to set/clear context when slot views are reassigned
• Calls base.OnBindingContextChanged() at the end — correct MAUI convention
• Uses SetInheritedBindingContext (not direct .BindingContext = assignment) — correct for inherited propagation

Issue (non-functional, test scoping): Issue24831.cs in HostApp declares PlatformAffected.All. Since TitleBar only exists on Windows/MacCatalyst, this should be scoped appropriately (e.g., PlatformAffected.Windows | PlatformAffected.macOS or the platform-specific equivalent). This is the only actionable change needed to fix the Android Gate failure.

Try-Fix results: 4 independent passing approaches were found. All had trade-offs versus the PR's fix:

• Attempt 1 (logical children): Overrides an internal SetChildInheritedBindingContext method
• Attempt 2 (explicit binding): Unconventional use of binding infrastructure for BindingContext itself
• Attempt 3 (PropertyChanged): String-based property name comparisons; less robust
• Attempt 4 (template wrappers): Fragile if user replaces ControlTemplate

The PR's fix is the simplest, most maintainable, and most consistent with MAUI conventions.

Selected Fix: PR

Requested Change

Fix PlatformAffected.All → correct Windows/MacCatalyst-scoped value in src/Controls/tests/TestCases.HostApp/Issues/Issue24831.cs to prevent false gate failures on Android.

---

[kubaflo]

🚦 Gate — Test Verification

📊 Expand Full Gate — b7f19c7 · Merge branch 'inflight/current' into fix-24831

---

Gate Result: ❌ FAILED

Platform: android

---