Skip to content

[Windows] Revert cleanup of AccessibilityExtensions#31608

Merged
PureWeen merged 2 commits intodotnet:inflight/candidatefrom
MartyIX:feature/2025-09-14-revert-27052
Sep 18, 2025
Merged

[Windows] Revert cleanup of AccessibilityExtensions#31608
PureWeen merged 2 commits intodotnet:inflight/candidatefrom
MartyIX:feature/2025-09-14-revert-27052

Conversation

@MartyIX
Copy link
Copy Markdown
Contributor

@MartyIX MartyIX commented Sep 14, 2025

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description of Change

Partial revert of #27052. This PR adds a test to make sure that any new PR does not introduce a similar regression.

Issues Fixed

Fixes #31606

@MartyIX MartyIX requested a review from a team as a code owner September 14, 2025 19:09
@MartyIX MartyIX mentioned this pull request Sep 14, 2025
Closed
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Sep 14, 2025
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

dotnet-policy-service bot commented Sep 14, 2025

Hey there @@MartyIX! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@jfversluis
Copy link
Copy Markdown
Member

jfversluis commented Sep 15, 2025

/azp run MAUI-public

@jfversluis jfversluis added this to the .NET 9 SR12 milestone Sep 15, 2025
@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Sep 15, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@jfversluis jfversluis added the p/0 Current heighest priority issues that we are targeting for a release. label Sep 15, 2025
@PureWeen PureWeen moved this from Todo to Ready To Review in MAUI SDK Ongoing Sep 16, 2025
PureWeen
PureWeen requested changes Sep 16, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MartyIX should this have a UITest part?

@github-project-automation github-project-automation bot moved this from Ready To Review to Changes Requested in MAUI SDK Ongoing Sep 16, 2025
@MartyIX
Copy link
Copy Markdown
Contributor Author

MartyIX commented Sep 16, 2025

@MartyIX should this have a UITest part?

I added it intentionally to make sure that it works for customers (it's a bit surprising that there is no test that would catch it). The PR can be a simple revert and it would be OK as well.

@PureWeen PureWeen moved this from Changes Requested to Ready To Review in MAUI SDK Ongoing Sep 16, 2025
jfversluis
jfversluis previously approved these changes Sep 16, 2025
View reviewed changes
@jfversluis
Copy link
Copy Markdown
Member

jfversluis commented Sep 16, 2025 •
edited
Loading

/azp run MAUI-UITests-public

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Sep 16, 2025

Azure Pipelines successfully started running 1 pipeline(s).

PureWeen
PureWeen requested changes Sep 16, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needs host code to run the test

Merge when that's added

@github-project-automation github-project-automation bot moved this from Ready To Review to Changes Requested in MAUI SDK Ongoing Sep 16, 2025
@MartyIX MartyIX force-pushed the feature/2025-09-14-revert-27052 branch from 0c01cf2 to 8b2496e Compare September 16, 2025 13:45
@MartyIX
Copy link
Copy Markdown
Contributor Author

MartyIX commented Sep 16, 2025

Added the test code. Please AZP for me to upload snapshots later.

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Sep 16, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@PureWeen
Copy link
Copy Markdown
Member

PureWeen commented Sep 16, 2025

/azp run MAUI-UITests-public

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Sep 16, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@MartyIX MartyIX force-pushed the feature/2025-09-14-revert-27052 branch from 8b2496e to 5742cf4 Compare September 16, 2025 13:56
@PureWeen
Copy link
Copy Markdown
Member

PureWeen commented Sep 16, 2025

/azp run MAUI-UITests-public

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Sep 16, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@PureWeen PureWeen moved this from Changes Requested to Ready To Review in MAUI SDK Ongoing Sep 16, 2025
@github-project-automation github-project-automation bot moved this from Ready To Review to Approved in MAUI SDK Ongoing Sep 16, 2025
@PureWeen
Copy link
Copy Markdown
Member

PureWeen commented Sep 17, 2025

/azp run MAUI-DeviceTests-public

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Sep 17, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@PureWeen PureWeen changed the base branch from main to inflight/candidate September 18, 2025 20:23
@PureWeen PureWeen merged commit 8faf90c into dotnet:inflight/candidate Sep 18, 2025
111 of 113 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in MAUI SDK Ongoing Sep 18, 2025
@MartyIX MartyIX deleted the feature/2025-09-14-revert-27052 branch September 18, 2025 20:25
github-actions bot pushed a commit that referenced this pull request Sep 18, 2025
@MartyIX @PureWeen
[Windows] Revert cleanup of AccessibilityExtensions (#31608)
bc9e9e7 
* revert

* test
github-actions bot pushed a commit that referenced this pull request Sep 23, 2025
@MartyIX @PureWeen
[Windows] Revert cleanup of AccessibilityExtensions (#31608)
b84a9de 
* revert

* test
github-actions bot pushed a commit that referenced this pull request Sep 23, 2025
@MartyIX @PureWeen
[Windows] Revert cleanup of AccessibilityExtensions (#31608)
261b5db 
* revert

* test
@PureWeen
Copy link
Copy Markdown
Member

PureWeen commented Sep 24, 2025

/backport to release/9.0.1xx-sr11

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 24, 2025

Started backporting to release/9.0.1xx-sr11: https://github.com/dotnet/maui/actions/runs/17977802558

@github-actions github-actions bot mentioned this pull request Sep 24, 2025
Merged
This was referenced Oct 20, 2025
Merged
Merged
Merged
Merged
Closed
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jfversluis jfversluis jfversluis approved these changes

@PureWeen PureWeen PureWeen approved these changes

Assignees

No one assigned

Labels

community ✨ Community Contribution p/0 Current heighest priority issues that we are targeting for a release. platform/windows

Projects

MAUI SDK Ongoing
Status: Done

Milestone

.NET 9 SR12

Development

Successfully merging this pull request may close these issues.

MAUI 9.0.110 crashes on Windows when SemanticProperties.Description is set for ToolbarItem

4 participants

@MartyIX @jfversluis @PureWeen @jsuarezruiz