-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Shell] Update logic for iOS large title display in ShellItemRenderer #33246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jfversluis
merged 4 commits into
dotnet:inflight/current
from
kubaflo:shell-large-text-display
Mar 3, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| namespace Maui.Controls.Sample.Issues; | ||
|
|
||
| [Issue(IssueTracker.Github, 33037, "iOS Large Title display disappears when scrolling in Shell", PlatformAffected.iOS)] | ||
| public class Issue33037 : TestShell | ||
| { | ||
| protected override void Init() | ||
| { | ||
| var page = new ContentPage | ||
| { | ||
| Title = "Large Title Test" | ||
| }; | ||
|
|
||
| // Explicitly set LargeTitleDisplay to Always — this should show a large title | ||
| Microsoft.Maui.Controls.PlatformConfiguration.iOSSpecific.Page.SetLargeTitleDisplay( | ||
| page, | ||
| Microsoft.Maui.Controls.PlatformConfiguration.iOSSpecific.LargeTitleDisplayMode.Always); | ||
|
|
||
| var scrollView = new ScrollView | ||
| { | ||
| AutomationId = "TestScrollView", | ||
| Content = new VerticalStackLayout | ||
| { | ||
| Children = | ||
| { | ||
| new Label | ||
| { | ||
| Text = "Large Title Test Page", | ||
| AutomationId = "PageTitle", | ||
| FontSize = 18, | ||
| Margin = new Thickness(20, 10) | ||
| } | ||
| } | ||
| } | ||
| }; | ||
|
|
||
| // Add enough items to make the page scrollable | ||
| var layout = (VerticalStackLayout)scrollView.Content; | ||
| for (int i = 0; i < 30; i++) | ||
| { | ||
| layout.Children.Add(new Label | ||
| { | ||
| Text = $"Item {i}", | ||
| AutomationId = $"Item{i}", | ||
| Margin = new Thickness(20, 5) | ||
| }); | ||
| } | ||
|
|
||
| page.Content = scrollView; | ||
| AddContentPage(page); | ||
| } | ||
| } |
Binary file added
BIN
+29.9 KB
src/Controls/tests/TestCases.Mac.Tests/snapshots/mac/Issue33037_AfterScroll.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+33.2 KB
src/Controls/tests/TestCases.Mac.Tests/snapshots/mac/Issue33037_BeforeScroll.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
34 changes: 34 additions & 0 deletions
34
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue33037.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| #if TEST_FAILS_ON_ANDROID && TEST_FAILS_ON_WINDOWS | ||
| using NUnit.Framework; | ||
| using UITest.Appium; | ||
| using UITest.Core; | ||
|
|
||
| namespace Microsoft.Maui.TestCases.Tests.Issues; | ||
|
|
||
| public class Issue33037 : _IssuesUITest | ||
| { | ||
| public Issue33037(TestDevice testDevice) : base(testDevice) | ||
| { | ||
| } | ||
|
|
||
| public override string Issue => "iOS Large Title display disappears when scrolling in Shell"; | ||
|
|
||
| [Test] | ||
| [Category(UITestCategories.Shell)] | ||
| public void LargeTitleTransitionsOnScroll() | ||
| { | ||
| // Verify page loaded with large title visible | ||
| App.WaitForElement("PageTitle"); | ||
|
|
||
| // Take a screenshot before scrolling to verify large title is shown | ||
| VerifyScreenshot("Issue33037_BeforeScroll"); | ||
|
|
||
| // Scroll down to trigger the large title → standard title transition | ||
| App.ScrollDown("TestScrollView"); | ||
| App.ScrollDown("TestScrollView"); | ||
|
|
||
| // Take screenshot after scrolling — title should have transitioned to standard size | ||
| VerifyScreenshot("Issue33037_AfterScroll", retryTimeout: TimeSpan.FromSeconds(2)); | ||
| } | ||
| } | ||
| #endif |
Binary file added
BIN
+119 KB
src/Controls/tests/TestCases.iOS.Tests/snapshots/ios-26/Issue33037_AfterScroll.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+85.4 KB
...Controls/tests/TestCases.iOS.Tests/snapshots/ios-26/Issue33037_BeforeScroll.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+119 KB
src/Controls/tests/TestCases.iOS.Tests/snapshots/ios/Issue33037_AfterScroll.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+85.4 KB
src/Controls/tests/TestCases.iOS.Tests/snapshots/ios/Issue33037_BeforeScroll.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling error in comment: "doen't" should be "doesn't".