Skip to content

[Android] Fix Circle Stroke color is incorrectly updated as Fill color. #33643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kubaflo merged 1 commit into from
Feb 23, 2026
Merged

[Android] Fix Circle Stroke color is incorrectly updated as Fill color. #33643

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/Core/maps/src/Handlers/Map/MapHandler.Android.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,14 +176,19 @@ void CircleOnPropertyChanged(ICircleMapElement mauiCircle)
var nativeCircle = GetNativeCircle(mauiCircle);

if (nativeCircle == null)
{
return;

}

if (mauiCircle.Stroke is SolidPaint solidPaint)
nativeCircle.FillColor = solidPaint.Color.AsColor();
{
nativeCircle.StrokeColor = solidPaint.Color.AsColor();
}

if (mauiCircle.Fill is SolidPaint solidFillPaint)
{
nativeCircle.FillColor = solidFillPaint.Color.AsColor();
}
Comment on lines 178 to +191
Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added braces around the null check, Stroke assignment, and Fill assignment are inconsistent with the coding style used elsewhere in this file. The PolygonOnPropertyChanged and PolylineOnPropertyChanged methods (lines 142-171) use the same patterns without braces for single-statement if blocks. For consistency with the existing codebase, consider removing the braces from these if statements to match the style of similar methods in this file.

Copilot uses AI. Check for mistakes.

nativeCircle.Center = new LatLng(mauiCircle.Center.Latitude, mauiCircle.Center.Longitude);
nativeCircle.Radius = mauiCircle.Radius.Meters;
Expand Down
Loading