[Android] Fix Circle Stroke color is incorrectly updated as Fill color.

[NirmalKumarYuvaraj]

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description of Change

This pull request fixes a bug in the CircleOnPropertyChanged method of the Android map handler where the circle's stroke color was incorrectly applied to FillColor instead of StrokeColor.

Root Cause: A copy-paste error in CircleOnPropertyChanged caused the Stroke paint to be assigned to nativeCircle.FillColor instead of nativeCircle.StrokeColor. The sibling methods PolygonOnPropertyChanged and PolylineOnPropertyChanged correctly set StrokeColor, but the circle method had the wrong property name.

Fix: Changed the assignment from nativeCircle.FillColor to nativeCircle.StrokeColor when mapping mauiCircle.Stroke to the native circle, ensuring stroke and fill colors are applied to the correct native properties.

Bug fix and code clarity improvements:

• Fixed assignment to set nativeCircle.StrokeColor (instead of FillColor) from the Stroke property, ensuring the circle's stroke color is updated correctly.
• Added braces and an explicit null check for nativeCircle to improve code readability and prevent potential null reference errors.

Issues Fixed

Fixes #33642

Output

Before	After
Before.mov	After.mov

[Copilot]

Pull request overview

This PR fixes a critical bug in the Android map handler where the circle's stroke color was incorrectly being assigned to the fill color property, causing visual rendering issues. The fix ensures that mauiCircle.Stroke correctly updates nativeCircle.StrokeColor instead of nativeCircle.FillColor.

Changes:

• Fixed the stroke color assignment bug by changing nativeCircle.FillColor to nativeCircle.StrokeColor when processing the Stroke property
• Added braces around if statements for improved code readability

[Copilot]

The added braces around the null check, Stroke assignment, and Fill assignment are inconsistent with the coding style used elsewhere in this file. The PolygonOnPropertyChanged and PolylineOnPropertyChanged methods (lines 142-171) use the same patterns without braces for single-statement if blocks. For consistency with the existing codebase, consider removing the braces from these if statements to match the style of similar methods in this file.

[rmarinho]

🤖 AI Summary

📊 Expand Full Review

---

🔍 Pre-Flight — Context & Validation

---

📝 Review Session — Fixed - 33642 · 5374f28

---

Issue: #33642 - [Android] Circle Stroke color is incorrectly updated as Fill color.
PR: #33643 - [Android] Fixed Circle Stroke color is incorrectly updated as Fill color.
Platforms Affected: Android only
Files Changed: 1 implementation file (src/Core/maps/src/Handlers/Map/MapHandler.Android.cs), no test files

Issue Summary

On Android, when Circle.StrokeColor is updated at runtime (e.g., via a button click), the change is incorrectly applied to nativeCircle.FillColor instead of nativeCircle.StrokeColor. This is a clear copy-paste bug in CircleOnPropertyChanged in MapHandler.Android.cs. iOS is not affected. Issue was reproduced and verified in MAUI 10.0.30.

Root Cause

In the original CircleOnPropertyChanged method, the Stroke property branch was assigning the wrong native property:

if (mauiCircle.Stroke is SolidPaint solidPaint)
    nativeCircle.FillColor = solidPaint.Color.AsColor();  // BUG: should be StrokeColor

The Stroke update was applied to FillColor instead of StrokeColor.

PR Fix

The fix correctly changes nativeCircle.FillColor → nativeCircle.StrokeColor in the Stroke branch. The PR also adds braces around all single-statement if blocks (cosmetic change).

Reviewer Feedback

• Copilot reviewer (unresolved): The added braces are inconsistent with PolygonOnPropertyChanged and PolylineOnPropertyChanged which use brace-free style for single-statement if blocks.

Disagreements / Edge Cases

File:Line	Reviewer Says	Author Says	Status
MapHandler.Android.cs:179-191	Remove extra braces for style consistency	Added braces for readability/clarity	⚠️ INVESTIGATE

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
PR	PR #33643	Change nativeCircle.FillColor → nativeCircle.StrokeColor in Stroke branch; add braces	⏳ PENDING (Gate)	MapHandler.Android.cs (+7/-2)	Original PR fix

Test Status

⚠️ No UI tests exist for this issue. No files matching Issue33642 or Issue33643 were found in TestCases.HostApp or TestCases.Shared.Tests. Gate phase cannot be verified without tests.

Prior Agent Review

A prior agent review was posted on 2026-02-18. Same commit SHA (5374f289). Findings are consistent with this review. Importing prior findings.

---

🚦 Gate — Test Verification

---

📝 Review Session — Fixed - 33642 · 5374f28

---

Result: ❌ FAILED — No tests exist for this issue
Platform: android
Mode: N/A — No tests to run

Gate Status

No UI test files were found for issue #33642 or PR #33643:

• src/Controls/tests/TestCases.HostApp/Issues/Issue33642* — NOT FOUND
• src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue33642* — NOT FOUND

The PR does not include any automated tests to verify the fix. Gate verification cannot be performed without tests.

Action Required: Tests must be added before Gate can pass. The write-tests-agent can help create UI tests for this issue.

The bug is a Map control Android-only issue — an automated UI test should:

1. Create a Map with a Circle element that has an initial StrokeColor
2. Trigger a StrokeColor change at runtime
3. Verify the circle's stroke color updates (not the fill color)

Gate: ❌ FAILED (no tests)

---

🔧 Fix — Analysis & Comparison

---

📝 Review Session — Fixed - 33642 · 5374f28

---

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
PR	PR #33643	Change nativeCircle.FillColor → nativeCircle.StrokeColor in Stroke branch; add braces	⏳ PENDING (Gate)	MapHandler.Android.cs (+7/-2)	Original PR

Exhausted: N/A — Gate failed (no tests exist). try-fix skipped as a result.
Selected Fix: PR's fix — The bug is a trivially correct one-line fix (FillColor → StrokeColor in the Stroke branch). No alternative exploration was possible without tests to validate against.

Reason Phase Skipped

Gate ❌ FAILED because no UI tests exist for this issue. try-fix was also skipped since it requires Gate to pass first and functioning tests to validate against.

The fix itself is clearly correct — PolygonOnPropertyChanged in the same file shows the correct pattern:

if (mauiPolygon.Stroke is SolidPaint solidPaint)
    nativePolygon.StrokeColor = solidPaint.Color.AsColor();  // correct pattern

---

📋 Report — Final Recommendation

---

📝 Review Session — Fixed - 33642 · 5374f28

---

⚠️ Final Recommendation: REQUEST CHANGES

Summary

PR #33643 fixes a clear one-line copy-paste bug in CircleOnPropertyChanged on Android where the Stroke property update was incorrectly setting nativeCircle.FillColor instead of nativeCircle.StrokeColor. The core bug fix is correct and necessary. However, the PR has issues that should be addressed before merge:

1. No tests — No automated tests were added; the PR cannot be merged without tests to prevent regression
2. Style inconsistency — Added braces conflict with the existing brace-free style in sibling methods in the same file
3. Inaccurate description — Claims "explicit null check added" but the null check already existed

Root Cause

Copy-paste bug in CircleOnPropertyChanged — when the Stroke branch was written, it mistakenly assigned nativeCircle.FillColor (same as the Fill branch) instead of nativeCircle.StrokeColor. This caused any runtime update to Circle.StrokeColor on Android to visually update the fill color instead of the stroke.

Fix Quality

The one-line fix (FillColor → StrokeColor) is correct. The adjacent PolygonOnPropertyChanged method shows the correct pattern:

if (mauiPolygon.Stroke is SolidPaint solidPaint)
    nativePolygon.StrokeColor = solidPaint.Color.AsColor();  // ✅ correct pattern

---

PR Finalization Review

⚠️ Title: Needs Minor Update

Current: [Android] Fixed Circle Stroke color is incorrectly updated as Fill color.
Recommended: [Android] Map: Fix Circle stroke color incorrectly updating fill color

Issues:

• Starts with "Fixed" (past tense). PR titles should use present tense "Fix"
• Verbose — can be shortened
• Missing component qualifier "Map"

⚠️ Description: Needs Updates

Issues with current description:

1. ❌ Missing required NOTE block at the top
2. ❌ Inaccurate: Claims "Added braces and an explicit null check for nativeCircle" — the null check already existed, only braces were added around the existing return; statement
3. ❌ Missing root cause context (copy-paste bug)

Suggested description:

<!-- Please let the below note in for people that find this PR -->
> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you!

### Root Cause

In `CircleOnPropertyChanged` in `MapHandler.Android.cs`, a copy-paste error caused `nativeCircle.FillColor` to be set from `mauiCircle.Stroke` (the stroke property) instead of `nativeCircle.StrokeColor`. At runtime, any update to `Circle.StrokeColor` on Android would incorrectly update the fill color instead of the stroke.

### Description of Change

Fixes `CircleOnPropertyChanged` in `MapHandler.Android.cs`:

- **Bug fix:** Changed `nativeCircle.FillColor = solidPaint.Color.AsColor()` → `nativeCircle.StrokeColor = solidPaint.Color.AsColor()` in the `mauiCircle.Stroke` branch, so the stroke color is now correctly applied.
- **Code clarity:** Added braces around single-statement `if` blocks.

The bug only affected Android; iOS was not affected.

### Issues Fixed

Fixes #33642

---

Code Review Findings

🔴 Missing Tests

No UI test files were added for this issue. Tests are required to prevent regression.

Missing files:

• src/Controls/tests/TestCases.HostApp/Issues/Issue33642.cs — MISSING
• src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue33642.cs — MISSING

Use write-tests-agent to create tests that:

1. Create a Map with a Circle that has an initial StrokeColor
2. Trigger a StrokeColor change at runtime via button click
3. Verify the stroke color updates correctly (not fill color)

🟡 Style Inconsistency — Extra Braces

The PR adds braces around single-statement if blocks in CircleOnPropertyChanged, but the sibling methods PolygonOnPropertyChanged (lines 142-157) and PolylineOnPropertyChanged (lines 159-171) use the brace-free style throughout. This inconsistency was also flagged by the Copilot reviewer in an unresolved code review comment.

Sibling method style (existing, no braces):

if (nativePolygon == null)
    return;

if (mauiPolygon.Stroke is SolidPaint solidPaint)
    nativePolygon.StrokeColor = solidPaint.Color.AsColor();

PR's CircleOnPropertyChanged (with braces — inconsistent):

if (nativeCircle == null)
{
    return;
}

if (mauiCircle.Stroke is SolidPaint solidPaint)
{
    nativeCircle.StrokeColor = solidPaint.Color.AsColor();
}

Suggested (consistent with file style):

if (nativeCircle == null)
    return;

if (mauiCircle.Stroke is SolidPaint solidPaint)
    nativeCircle.StrokeColor = solidPaint.Color.AsColor();

if (mauiCircle.Fill is SolidPaint solidFillPaint)
    nativeCircle.FillColor = solidFillPaint.Color.AsColor();

nativeCircle.Center = new LatLng(mauiCircle.Center.Latitude, mauiCircle.Center.Longitude);
nativeCircle.Radius = mauiCircle.Radius.Meters;
nativeCircle.StrokeWidth = (float)mauiCircle.StrokeThickness;

✅ Core Fix is Correct

The one-line fix (nativeCircle.FillColor → nativeCircle.StrokeColor in the Stroke branch) correctly resolves the bug. The Fill branch was already correct and remains untouched. No public API changes, no breaking changes. Android-only scope is appropriate.

---

Phases Summary

Phase	Status	Notes
Pre-Flight	✅ COMPLETE	Issue #33642 confirmed Android-only bug
Gate	❌ FAILED	No UI tests exist for this issue
Fix	⚠️ SKIPPED	Gate did not pass (no tests to validate against)
Report	✅ COMPLETE	Code review performed; REQUEST CHANGES

---

📋 Expand PR Finalization Review

---

Title: ✅ Good

Current: [Android] Fixed Circle Stroke color is incorrectly updated as Fill color.

Description: ⚠️ Needs Update

• Trailing period should be removed
• "Fixed" is past tense — MAUI PR titles use imperative form ("Fix", not "Fixed")
• Describes the bug symptom rather than the fix
• Missing component name ("Map") for better searchability
• Title is long and verbose

✨ Suggested PR Description

[!NOTE]
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description of Change

This pull request fixes a bug in the CircleOnPropertyChanged method of the Android map handler where the circle's stroke color was incorrectly applied to FillColor instead of StrokeColor.

Root Cause: A copy-paste error in CircleOnPropertyChanged caused the Stroke paint to be assigned to nativeCircle.FillColor instead of nativeCircle.StrokeColor. The sibling methods PolygonOnPropertyChanged and PolylineOnPropertyChanged correctly set StrokeColor, but the circle method had the wrong property name.

Fix: Changed the assignment from nativeCircle.FillColor to nativeCircle.StrokeColor when mapping mauiCircle.Stroke to the native circle, ensuring stroke and fill colors are applied to the correct native properties.

Issues Fixed

Fixes #33642

Code Review: ✅ Passed

Code Review — PR #33643

File: src/Core/maps/src/Handlers/Map/MapHandler.Android.cs

---

✅ Looks Good

Core bug fix is correct.

The one-line change:

// Before (bug):
nativeCircle.FillColor = solidPaint.Color.AsColor();  // from mauiCircle.Stroke

// After (fix):
nativeCircle.StrokeColor = solidPaint.Color.AsColor();  // from mauiCircle.Stroke

This is the correct fix. The Stroke property of ICircleMapElement should map to StrokeColor on the native Circle object, not FillColor. The sibling methods PolygonOnPropertyChanged and PolylineOnPropertyChanged already use StrokeColor correctly for their stroke assignments.

---

🟡 Suggestions

Unnecessary brace additions create style inconsistency

File: src/Core/maps/src/Handlers/Map/MapHandler.Android.cs
Lines: 179–190 (the modified CircleOnPropertyChanged method)

The PR adds braces to all single-statement if blocks in CircleOnPropertyChanged:

// Added by this PR (with braces):
if (nativeCircle == null)
{
    return;
}

if (mauiCircle.Stroke is SolidPaint solidPaint)
{
    nativeCircle.StrokeColor = solidPaint.Color.AsColor();
}

However, the adjacent sibling methods PolygonOnPropertyChanged and PolylineOnPropertyChanged (immediately above in the same file) use the no-brace style:

// Existing style in PolygonOnPropertyChanged / PolylineOnPropertyChanged:
if (nativePolygon == null)
    return;

if (mauiPolygon.Stroke is SolidPaint solidPaint)
    nativePolygon.StrokeColor = solidPaint.Color.AsColor();

Recommendation: Remove the added braces from CircleOnPropertyChanged to match the style of PolygonOnPropertyChanged and PolylineOnPropertyChanged. The braces are not necessary for correctness and the inconsistency makes the method stand out without reason.

Note: This was already flagged by the automated Copilot reviewer in review comment (unresolved).

---

No Other Issues Found

The change is minimal and targeted. No performance, null safety, or behavioral concerns beyond the above.

---