Fix CoreCLR iOS/MacCatalyst Helix jobs to use internal queues#34306
Merged
mattleibow merged 1 commit intonet11.0from Mar 3, 2026
Merged
Fix CoreCLR iOS/MacCatalyst Helix jobs to use internal queues#34306mattleibow merged 1 commit intonet11.0from
mattleibow merged 1 commit intonet11.0from
Conversation
The CoreCLR iOS and MacCatalyst send-to-helix steps were missing the HelixInternal and HelixAccessToken parameters, causing them to always use .open queues. This fails on internal AzDO projects (dnceng/internal) with: 'Helix .open queues should only be used from public AzDO projects.' Add the same runAsPublic conditional that all other Helix jobs already use (including CoreCLR Android). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 34306Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 34306" |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes CoreCLR iOS and MacCatalyst device-test Helix submissions so internal Azure DevOps runs use internal Helix queues (and authenticate correctly), matching the behavior of the other device-test jobs.
Changes:
- Adds
runAsPublicconditionals to set/p:HelixInternal=True|Falsefor CoreCLR iOS and MacCatalyst send-to-helix steps. - Passes
HelixAccessTokento those CoreCLR iOS/MacCatalyst send-to-helix steps so internal queues can be used fromdnceng/internal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description
The CoreCLR iOS and MacCatalyst
send-to-helixsteps instage-device-tests.ymlwere missing theHelixInternalandHelixAccessTokenparameters. This caused them to always use.openHelix queues, which fails on internal Azure DevOps projects (dnceng/internal) with:All other Helix jobs (Mono iOS, Mono MacCatalyst, Mono Android, CoreCLR Android, Windows) already had the correct
runAsPublicconditional. Only CoreCLR iOS and CoreCLR MacCatalyst were missing it.Changes
eng/pipelines/arcade/stage-device-tests.yml: Add the${{ if eq(parameters.runAsPublic, true) }}conditional to the CoreCLR iOS and MacCatalyst send-to-helix steps, matching the pattern used by all other jobs:HelixInternal=Falsefor public builds,HelixInternal=Truefor internal buildsHelixAccessTokenfor authenticated access to internal queues