Skip to content

Translate ref readonly in new synthetic call factory and unskip arglist tests#68951

Merged
jjonescz merged 2 commits intodotnet:features/RefReadonlyfrom
jjonescz:RefReadonly-10-MainFollowUp
Jul 12, 2023
Merged

Translate ref readonly in new synthetic call factory and unskip arglist tests#68951
jjonescz merged 2 commits intodotnet:features/RefReadonlyfrom
jjonescz:RefReadonly-10-MainFollowUp

Conversation

@jjonescz
Copy link
Copy Markdown
Member

Changes that became possible only after merging main into the feature branch in #68950.
Test plan: #68056.

@jjonescz jjonescz added this to the C# 12.0 milestone Jul 10, 2023
@ghost ghost added the untriaged Issues and PRs which have not yet been triaged by a lead label Jul 10, 2023
@jjonescz jjonescz force-pushed the RefReadonly-10-MainFollowUp branch 2 times, most recently from 4d99843 to 268a62a Compare July 10, 2023 11:10
@jjonescz jjonescz force-pushed the RefReadonly-10-MainFollowUp branch from 268a62a to 836d07b Compare July 10, 2023 12:29
@jjonescz jjonescz marked this pull request as ready for review July 10, 2023 13:59
@jjonescz jjonescz requested a review from a team as a code owner July 10, 2023 13:59
@jjonescz jjonescz requested review from AlekseyTs and jcouv July 10, 2023 13:59
Copy link
Copy Markdown
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 2)

@jjonescz
Copy link
Copy Markdown
Member Author

@jcouv for a quick second review, thanks

@jcouv jcouv self-assigned this Jul 11, 2023
Copy link
Copy Markdown
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 2)

@jaredpar jaredpar modified the milestones: C# 12.0, 17.8 Jul 11, 2023
@jjonescz jjonescz merged commit e10eb7f into dotnet:features/RefReadonly Jul 12, 2023
@jjonescz jjonescz deleted the RefReadonly-10-MainFollowUp branch July 12, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers Feature - Ref Readonly Parameters `ref readonly` parameters untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants