Update rule ID for 'Unnecessary call to Set.Contains'#69282
Merged
333fred merged 2 commits intodotnet:mainfrom Aug 23, 2023
Merged
Update rule ID for 'Unnecessary call to Set.Contains'#69282333fred merged 2 commits intodotnet:mainfrom
333fred merged 2 commits intodotnet:mainfrom
Conversation
Another PR used CA1865, so this rule now uses CA1868
ghost
added
Area-Infrastructure
untriaged
333fred
reviewed
Jul 31, 2023
Member
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
333fred
approved these changes
Aug 22, 2023
Member
333fred
left a comment
333fred
left a comment
There was a problem hiding this comment.
LGTM (commit 2), provided tests are passing. @dotnet/roslyn-compiler for a second review.
333fred
removed
the
untriaged
jjonescz
approved these changes
Aug 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #69179.
Another analyzer used CA1865, so this rule now uses CA1868.
Also fixed a diagnostic found during final testing of the PR for the analyzer.