Skip to content

Update rule ID for 'Unnecessary call to Set.Contains' #69282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
333fred merged 2 commits into from
Aug 23, 2023
Merged

Update rule ID for 'Unnecessary call to Set.Contains' #69282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b7a3ad
Update ID for 'Unnecessary call to Set.Contains'
mpidash Jul 28, 2023
ab0b7ae
Fix CA1868: Unnecessary call to Set.Contains
mpidash Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/config/globalconfigs/Common.globalconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ dotnet_diagnostic.CA1067.severity = warning
dotnet_diagnostic.CA1068.severity = warning
dotnet_diagnostic.CA1200.severity = warning
dotnet_diagnostic.CA1821.severity = warning
dotnet_diagnostic.CA1865.severity = warning
dotnet_diagnostic.CA1868.severity = warning
Comment thread
333fred marked this conversation as resolved.
dotnet_diagnostic.CA2009.severity = warning

# CA2012: Use ValueTasks correctly
Expand Down
6 changes: 1 addition & 5 deletions src/Compilers/CSharp/Portable/Parser/DocumentationCommentParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,14 +330,10 @@ private void ParseXmlAttributes(ref XmlNameSyntax elementName, SyntaxListBuilder
{
var attr = this.ParseXmlAttribute(elementName);
string attrName = attr.Name.ToString();
if (_attributesSeen.Contains(attrName))
if (!_attributesSeen.Add(attrName))
{
attr = this.WithXmlParseError(attr, XmlParseErrorCode.XML_DuplicateAttribute, attrName);
}
else
{
_attributesSeen.Add(attrName);
}

attrs.Add(attr);
}
Expand Down