Fix issues where internal pattern matching state was being copied#69336
Merged
CyrusNajmabadi merged 5 commits intodotnet:mainfrom Aug 10, 2023
Merged
Fix issues where internal pattern matching state was being copied#69336CyrusNajmabadi merged 5 commits intodotnet:mainfrom
CyrusNajmabadi merged 5 commits intodotnet:mainfrom
Conversation
ghost
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Aug 2, 2023
| /// <summary> | ||
| /// Not readonly as this value caches data within it, and so it needs to be able to mutate. | ||
| /// </summary> | ||
| public WordSimilarityChecker SimilarityChecker; |
Contributor
Author
There was a problem hiding this comment.
the alternative is to accept that thsi caching optimization was never working, remove it entirely, and make all this stuff readonly.
Contributor
Author
1 similar comment
Contributor
Author
akhera99
approved these changes
Aug 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.