Skip to content

Move SB metadata to intermediates#71934

Merged
ellahathaway merged 1 commit intodotnet:mainfrom
ellahathaway:sb-metadata
Feb 6, 2024
Merged

Move SB metadata to intermediates#71934
ellahathaway merged 1 commit intodotnet:mainfrom
ellahathaway:sb-metadata

Conversation

@ellahathaway
Copy link
Copy Markdown
Member

The changes in this pull request aim to improve the UX and guideance around the SourceBuild metadata by placing the metadata on explicit source-build intermediates.

The changes include:

  • Removing existing SourceBuild metadata from all non-intermediate dependencies.
  • Defining new explicit intermediate dependencies and adding SourceBuild metadata to those dependencies.

Related to dotnet/source-build#3373 and dotnet/source-build#4073

@ellahathaway ellahathaway requested a review from a team February 2, 2024 18:06
@ellahathaway ellahathaway requested a review from a team as a code owner February 2, 2024 18:06
@ghost ghost added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Feb 2, 2024
@ellahathaway
Copy link
Copy Markdown
Member Author

ellahathaway commented Feb 6, 2024

@dotnet/roslyn-infrastructure - soft ping. Would really appreciate getting a review on this. Thanks!

Edited: meant to ping infra but originally pinged analysis.

@jasonmalinowski
Copy link
Copy Markdown
Member

@dotnet/roslyn-infrastructure would be the better reviewers here.

@sharwell
Copy link
Copy Markdown
Contributor

sharwell commented Feb 6, 2024

I merged a similar one for dotnet/roslyn-analyzers. I have no idea what it means though.

@ellahathaway ellahathaway merged commit 8cdc0cc into dotnet:main Feb 6, 2024
@ellahathaway ellahathaway deleted the sb-metadata branch February 6, 2024 20:42
@ghost ghost added this to the Next milestone Feb 6, 2024
@jjonescz jjonescz modified the milestones: Next, 17.10 P2 Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants