Skip to content

Move SB metadata to intermediates#38545

Merged
mmitche merged 4 commits intodotnet:mainfrom
ellahathaway:sb-metadata
Feb 6, 2024
Merged

Move SB metadata to intermediates#38545
mmitche merged 4 commits intodotnet:mainfrom
ellahathaway:sb-metadata

Conversation

@ellahathaway
Copy link
Copy Markdown
Member

The changes in this pull request aim to improve the UX and guideance around the SourceBuild metadata by placing the metadata on explicit source-build intermediates.

The changes include:

  • Removing existing SourceBuild metadata from all non-intermediate dependencies.
  • Defining new explicit intermediate dependencies and adding SourceBuild metadata to those dependencies.

Related to dotnet/source-build#3373 and dotnet/source-build#4073

@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Feb 5, 2024
@ellahathaway ellahathaway requested a review from a team February 5, 2024 18:49
@mmitche
Copy link
Copy Markdown
Member

mmitche commented Feb 6, 2024

You should resolve the conflicts after it passes, then I can immediately merge. Otherwise you're going to fight incoming changes.

@ellahathaway
Copy link
Copy Markdown
Member Author

You should resolve the conflicts after it passes, then I can immediately merge. Otherwise you're going to fight incoming changes.

@mmitche Done! Thanks!

@mmitche mmitche merged commit 786ee06 into dotnet:main Feb 6, 2024
@ellahathaway ellahathaway deleted the sb-metadata branch February 6, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Infrastructure untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants