Skip to content

Fix Marble verification with Coordinator root certificate#782

Merged
thomasten merged 2 commits into
masterfrom
t/fix-verify-marble-with-root
Jan 8, 2025
Merged

Fix Marble verification with Coordinator root certificate#782
thomasten merged 2 commits into
masterfrom
t/fix-verify-marble-with-root

Conversation

@thomasten
Copy link
Copy Markdown
Member

@thomasten thomasten commented Jan 1, 2025

External apps should be able to verify connections to Marbles by either the Coordinator root certificate or the Coordinator intermediate certificate (docs). For this to work, the Marble's certificate chain must include the Coordinator intermediate certificate, not the Marble Root certificate. This chain is verifiable by any of (i) Coordinator Root, (ii) Coordinator Intermediate, (iii) Marble Root.

Proposed changes

  • Add an integration test that covers (i) and (ii) [(iii) already covered by multiple tests where test marble client connects to test marble server]
  • Replace Marble Root with Coordinator Intermediate in Marble cert chain to fix (i)

@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 1, 2025

Deploy Preview for marblerun-docs canceled.

Name Link
🔨 Latest commit 7076f3f
🔍 Latest deploy log https://app.netlify.com/sites/marblerun-docs/deploys/6775c2401fda160008d0eee3

@thomasten thomasten added the bug fix This change fixes a user facing bug from the previous release label Jan 1, 2025
@thomasten thomasten marked this pull request as ready for review January 1, 2025 22:45
Comment thread coordinator/core/marbleapi.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix This change fixes a user facing bug from the previous release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants