Fix Marble verification with Coordinator root certificate#782
Merged
Conversation
✅ Deploy Preview for marblerun-docs canceled.
|
daniel-weisse
approved these changes
Jan 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External apps should be able to verify connections to Marbles by either the Coordinator root certificate or the Coordinator intermediate certificate (docs). For this to work, the Marble's certificate chain must include the Coordinator intermediate certificate, not the Marble Root certificate. This chain is verifiable by any of (i) Coordinator Root, (ii) Coordinator Intermediate, (iii) Marble Root.
Proposed changes