Skip to content

Support injection of Coordinator root and intermediate certificates into Marble environment#784

Merged
daniel-weisse merged 1 commit intomasterfrom
dw/coordinator-root-template
Jan 9, 2025
Merged

Support injection of Coordinator root and intermediate certificates into Marble environment#784
daniel-weisse merged 1 commit intomasterfrom
dw/coordinator-root-template

Conversation

@daniel-weisse
Copy link
Copy Markdown
Member

@daniel-weisse daniel-weisse commented Jan 7, 2025

Proposed changes

  • Support injection of the Coordinator's root and intermediate certificates into a Marble's environment by adding a missing set up step to the manifest templating dry run function
  • Add docs on how to inject the Coordinator's root certificate into a Marble's environment
  • Clean up duplicated structs in /coordinator/core/marblerapi.go

Additional info

@daniel-weisse daniel-weisse added the feature This change introduces new functionality label Jan 7, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Jan 7, 2025

Deploy Preview for marblerun-docs ready!

Name Link
🔨 Latest commit 89e7cb9
🔍 Latest deploy log https://app.netlify.com/sites/marblerun-docs/deploys/677f82ba199d090008f0c5c2
😎 Deploy Preview https://deploy-preview-784--marblerun-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@daniel-weisse daniel-weisse force-pushed the dw/coordinator-root-template branch from 97330a2 to 17ecbb5 Compare January 9, 2025 07:52
@daniel-weisse daniel-weisse changed the title Support injection of Coordinator root certificate into Marble environment Support injection of Coordinator root and intermediate certificates into Marble environment Jan 9, 2025
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
@daniel-weisse daniel-weisse force-pushed the dw/coordinator-root-template branch from 17ecbb5 to 89e7cb9 Compare January 9, 2025 08:03
Copy link
Copy Markdown
Member

@thomasten thomasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniel-weisse daniel-weisse merged commit ea27924 into master Jan 9, 2025
@daniel-weisse daniel-weisse deleted the dw/coordinator-root-template branch January 9, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature This change introduces new functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants