Skip to content

Update dependencies#18

Merged
smileisak merged 4 commits intoedixos:mainfrom
ekarlso:update-dependencies
Sep 24, 2024
Merged

Update dependencies#18
smileisak merged 4 commits intoedixos:mainfrom
ekarlso:update-dependencies

Conversation

@ekarlso
Copy link
Copy Markdown
Contributor

@ekarlso ekarlso commented Aug 14, 2024

Terraform 1.8.x
Terraform provider 0.48.0 (Remove deprecated resources)
Crossplane deps

Description of your changes

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

@ekarlso ekarlso requested a review from smileisak as a code owner August 14, 2024 10:12
Copy link
Copy Markdown
Member

@smileisak smileisak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ekarlso,

Thanks again for your PR! :) However, I noticed that no new resources have been added or updated in the config folder.

When adding new resources to the OVH Terraform provider, they should be included in the config folder and referenced in the external_name.go file.

The following new resources need to be configured to be generated as CRDs with their corresponding controller logic:
New Resource: ovh_cloud_project_gateway_interface
(PR #697)

New Resource: ovh_cloud_project_region_loadbalancer_log_subscription
(PR #657)

New Resource: ovh_dbaas_logs_token
(PR #649)

New Resource: ovh_iploadbalancing_udp_frontend
(PR #587)

New Resource: ovh_domain_zone_dnssec
(PR #589)

New Resource: ovh_vps
(PR #594)

New Resource: ovh_ip_firewall
(PR #596)

New Resource: ovh_ip_firewall_rule
(PR #601)

New Resource: ovh_ip_mitigation
(PR #604)

Please ensure these resources are added and updated accordingly.

@ekarlso
Copy link
Copy Markdown
Contributor Author

ekarlso commented Sep 11, 2024

Hi, so I am excluding the ovh_vps resource as it causes issues as described here: crossplane/upjet#372 (comment)

@ekarlso
Copy link
Copy Markdown
Contributor Author

ekarlso commented Sep 16, 2024

I forgot that the change is pending crossplane/upjet#437 to get merged first. I've pinged them in their pull.

ekarlso and others added 4 commits September 24, 2024 16:09
Terraform 1.8.x
Terraform provider 0.48.0 (Remove deprecated resources)
Crossplane deps

Signed-off-by: ekarlso <endre.karlson@xait.com>
Signed-off-by: Ismail KABOUBI <ikaboubi@gmail.com>
@smileisak
Copy link
Copy Markdown
Member

I have fixed dependencies, rolled back to main's go.mod version.

@smileisak smileisak merged commit ca2736f into edixos:main Sep 24, 2024
@ekarlso ekarlso deleted the update-dependencies branch September 24, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants