Update dependencies#18
Conversation
smileisak
left a comment
There was a problem hiding this comment.
Hi @ekarlso,
Thanks again for your PR! :) However, I noticed that no new resources have been added or updated in the config folder.
When adding new resources to the OVH Terraform provider, they should be included in the config folder and referenced in the external_name.go file.
The following new resources need to be configured to be generated as CRDs with their corresponding controller logic:
New Resource: ovh_cloud_project_gateway_interface
(PR #697)
New Resource: ovh_cloud_project_region_loadbalancer_log_subscription
(PR #657)
New Resource: ovh_dbaas_logs_token
(PR #649)
New Resource: ovh_iploadbalancing_udp_frontend
(PR #587)
New Resource: ovh_domain_zone_dnssec
(PR #589)
New Resource: ovh_vps
(PR #594)
New Resource: ovh_ip_firewall
(PR #596)
New Resource: ovh_ip_firewall_rule
(PR #601)
New Resource: ovh_ip_mitigation
(PR #604)
Please ensure these resources are added and updated accordingly.
|
Hi, so I am excluding the ovh_vps resource as it causes issues as described here: crossplane/upjet#372 (comment) |
|
I forgot that the change is pending crossplane/upjet#437 to get merged first. I've pinged them in their pull. |
Terraform 1.8.x Terraform provider 0.48.0 (Remove deprecated resources) Crossplane deps Signed-off-by: ekarlso <endre.karlson@xait.com>
Signed-off-by: Ismail KABOUBI <ikaboubi@gmail.com>
|
I have fixed dependencies, rolled back to main's go.mod version. |
Terraform 1.8.x
Terraform provider 0.48.0 (Remove deprecated resources)
Crossplane deps
Description of your changes
Fixes #
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested