Upgrade crossplane-runtime to v1.17.0#437
Conversation
|
@smcavallo Any on on when you will get an update on this? |
|
@smcavallo thanks for your contribution 🙏 Can you please rebase onto main? I intend to merge this PR next. |
b427a06 to
fc0d4e8
Compare
524f040 to
fa20c25
Compare
|
The PR has become a mess, but I've verified that we'll be able to merge it after #451. |
Signed-off-by: smcavallo <smcavallo@hotmail.com>
Signed-off-by: smcavallo <smcavallo@hotmail.com>
Signed-off-by: smcavallo <smcavallo@hotmail.com>
Signed-off-by: smcavallo <smcavallo@hotmail.com>
fa20c25 to
bd4838e
Compare
mergenci
left a comment
There was a problem hiding this comment.
Thanks @smcavallo. LGTM. I consumed this PR in provider-upjet-aws. There were no compile errors, except the fact that clusterauth external client required implementing breaking changes introduced in crossplane-runtime v1.17.0.
Special thanks to @gravufo for their patience, understanding, and support during the long time they had to wait 🙏 Thank you @rickard-von-essen and Daniela for keeping me accountable over Slack. I'm grateful to have members like you in our community 🙏
Consumed Upjet PRs: - crossplane/upjet#454 - crossplane/upjet#450 - crossplane/upjet#451 - crossplane/upjet#437 - crossplane/upjet#462 - crossplane/upjet#461 Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Consumed Upjet PRs: - crossplane/upjet#454 - crossplane/upjet#450 - crossplane/upjet#451 - crossplane/upjet#437 - crossplane/upjet#462 - crossplane/upjet#461 Signed-off-by: Cem Mergenci <cmergenci@gmail.com> Signed-off-by: ido-re <ido.reychan@gmail.com>
Consumed Upjet PRs: - crossplane/upjet#454 - crossplane/upjet#450 - crossplane/upjet#451 - crossplane/upjet#437 - crossplane/upjet#462 - crossplane/upjet#461 Signed-off-by: Cem Mergenci <cmergenci@gmail.com> Signed-off-by: ido-re <ido.reychan@gmail.com>
Consumed Upjet PRs: - crossplane/upjet#454 - crossplane/upjet#450 - crossplane/upjet#451 - crossplane/upjet#437 - crossplane/upjet#462 - crossplane/upjet#461 Signed-off-by: Cem Mergenci <cmergenci@gmail.com> Signed-off-by: ido-re <ido.reychan@gmail.com>
Consumed Upjet PRs: - crossplane/upjet#454 - crossplane/upjet#450 - crossplane/upjet#451 - crossplane/upjet#437 - crossplane/upjet#462 - crossplane/upjet#461 Signed-off-by: Cem Mergenci <cmergenci@gmail.com> Signed-off-by: ido-re <ido.reychan@gmail.com>
Consumed Upjet PRs: - crossplane/upjet#454 - crossplane/upjet#450 - crossplane/upjet#451 - crossplane/upjet#437 - crossplane/upjet#462 - crossplane/upjet#461 Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Consumed Upjet PRs: - crossplane/upjet#454 - crossplane/upjet#450 - crossplane/upjet#451 - crossplane/upjet#437 - crossplane/upjet#462 - crossplane/upjet#461 Signed-off-by: Cem Mergenci <cmergenci@gmail.com> Signed-off-by: ido-re <ido.reychan@gmail.com>
Consumed Upjet PRs: - crossplane/upjet#454 - crossplane/upjet#450 - crossplane/upjet#451 - crossplane/upjet#437 - crossplane/upjet#462 - crossplane/upjet#461 Signed-off-by: Cem Mergenci <cmergenci@gmail.com> Signed-off-by: ido-re <ido.reychan@gmail.com>
Consumed Upjet PRs: - crossplane/upjet#454 - crossplane/upjet#450 - crossplane/upjet#451 - crossplane/upjet#437 - crossplane/upjet#462 - crossplane/upjet#461 Signed-off-by: Cem Mergenci <cmergenci@gmail.com> Signed-off-by: ido-re <ido.reychan@gmail.com>
Consumed Upjet PRs: - crossplane/upjet#454 - crossplane/upjet#450 - crossplane/upjet#451 - crossplane/upjet#437 - crossplane/upjet#462 - crossplane/upjet#461 Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
Consumed Upjet PRs: - crossplane/upjet#454 - crossplane/upjet#450 - crossplane/upjet#451 - crossplane/upjet#437 - crossplane/upjet#462 - crossplane/upjet#461 Signed-off-by: Cem Mergenci <cmergenci@gmail.com> Signed-off-by: ido-re <ido.reychan@gmail.com>
Consumed Upjet PRs: - crossplane/upjet#454 - crossplane/upjet#450 - crossplane/upjet#451 - crossplane/upjet#437 - crossplane/upjet#462 - crossplane/upjet#461 Signed-off-by: Cem Mergenci <cmergenci@gmail.com> Signed-off-by: ido-re <ido.reychan@gmail.com>
Signed-off-by: smcavallo smcavallo@hotmail.com
Description of your changes
Upgrade crossplane-runtime to v1.17.0 with associated new implementations
See - https://github.com/crossplane/crossplane-runtime/releases/tag/v1.17.0
Implements
DisconnectonExternalClientinterfaceSee - crossplane/crossplane-runtime#754
Implements
ExternalDeletereturn type on methodExternalClient.Delete()See - crossplane/crossplane-runtime#296
Upgrades go per error below:
go: module github.com/crossplane/crossplane-runtime@v1.17.0 requires go >= 1.22.0; switching to go1.22.7When attempting to upgrade an upjet-based provider to
v1.17.0ofcrossplane-runtimethe below error is generated.This PR should resolve that and allow consumers to upgrade to the newer runtime.
This is a breaking change in that any consumer who uses the newer version of
upjetwill also be forced to upgrade the newer version ofcrossplane-runtime(and also go >= 1.22.0)Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested